dave/storkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

story-kit: merge 166_story_add_done_column_to_pipeline_board

Browse Source 
Add Done column to pipeline board. Adds the 'done' stage to
PipelineState, exposes it via the WebSocket and REST API, and
renders a Done column in the frontend pipeline board view.

Squash merge from feature/story-166_story_add_done_column_to_pipeline_board.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Dave
2026-02-24 23:42:59 +00:00
parent d442dbeae8
commit 150f654e04
6 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/api/client.test.ts
View File

@@ -266,6 +266,7 @@ describe("ChatWebSocket", () => {
current: [],
qa: [],
merge: [],
done: [],
};
instances[1].simulateMessage({ type: "pipeline_state", ...freshState });

3
frontend/src/api/client.ts
View File

@@ -32,6 +32,7 @@ export interface PipelineState {
current: PipelineStageItem[];
qa: PipelineStageItem[];
merge: PipelineStageItem[];
done: PipelineStageItem[];
}
export type WsResponse =
@@ -45,6 +46,7 @@ export type WsResponse =
current: PipelineStageItem[];
qa: PipelineStageItem[];
merge: PipelineStageItem[];
done: PipelineStageItem[];
}
| {
type: "permission_request";
@@ -346,6 +348,7 @@ export class ChatWebSocket {
current: data.current,
qa: data.qa,
merge: data.merge,
done: data.done,
});
if (data.type === "permission_request")
this.onPermissionRequest?.(

2
frontend/src/components/Chat.tsx
View File

@@ -72,6 +72,7 @@ export function Chat({ projectPath, onCloseProject }: ChatProps) {
current: [],
qa: [],
merge: [],
done: [],
});
const [claudeSessionId, setClaudeSessionId] = useState<string | null>(null);
const [activityStatus, setActivityStatus] = useState<string | null>(null);
@@ -1074,6 +1075,7 @@ export function Chat({ projectPath, onCloseProject }: ChatProps) {
stateVersion={agentStateVersion}
/>
<StagePanel title="Done" items={pipeline.done} />
<StagePanel title="To Merge" items={pipeline.merge} />
<StagePanel title="QA" items={pipeline.qa} />
<StagePanel title="Current" items={pipeline.current} />

1
frontend/src/components/LozengeFlyContext.test.tsx
View File

@@ -13,6 +13,7 @@ function makePipeline(overrides: Partial<PipelineState> = {}): PipelineState {
current: [],
qa: [],
merge: [],
done: [],
...overrides,
};
}

8
server/src/http/workflow.rs
View File

@@ -36,9 +36,10 @@ pub struct PipelineState {
pub current: Vec<UpcomingStory>,
pub qa: Vec<UpcomingStory>,
pub merge: Vec<UpcomingStory>,
pub done: Vec<UpcomingStory>,
}
/// Load the full pipeline state (all 4 active stages).
/// Load the full pipeline state (all 5 active stages).
pub fn load_pipeline_state(ctx: &AppContext) -> Result<PipelineState, String> {
let agent_map = build_active_agent_map(ctx);
Ok(PipelineState {
@@ -46,6 +47,7 @@ pub fn load_pipeline_state(ctx: &AppContext) -> Result<PipelineState, String> {
current: load_stage_items(ctx, "2_current", &agent_map)?,
qa: load_stage_items(ctx, "3_qa", &agent_map)?,
merge: load_stage_items(ctx, "4_merge", &agent_map)?,
done: load_stage_items(ctx, "5_done", &HashMap::new())?,
})
}
@@ -607,6 +609,7 @@ mod tests {
("2_current", "20_story_current"),
("3_qa", "30_story_qa"),
("4_merge", "40_story_merge"),
("5_done", "50_story_done"),
] {
let dir = root.join(".story_kit").join("work").join(stage);
fs::create_dir_all(&dir).unwrap();
@@ -631,6 +634,9 @@ mod tests {
assert_eq!(state.merge.len(), 1);
assert_eq!(state.merge[0].story_id, "40_story_merge");
assert_eq!(state.done.len(), 1);
assert_eq!(state.done[0].story_id, "50_story_done");
}
#[test]

15
server/src/http/ws.rs
View File

@@ -73,6 +73,7 @@ enum WsResponse {
current: Vec<crate::http::workflow::UpcomingStory>,
qa: Vec<crate::http::workflow::UpcomingStory>,
merge: Vec<crate::http::workflow::UpcomingStory>,
done: Vec<crate::http::workflow::UpcomingStory>,
},
/// `.story_kit/project.toml` was modified; the frontend should re-fetch the
/// agent roster. Does NOT trigger a pipeline state refresh.
@@ -136,6 +137,7 @@ impl From<PipelineState> for WsResponse {
current: s.current,
qa: s.qa,
merge: s.merge,
done: s.done,
}
}
}
@@ -569,12 +571,14 @@ mod tests {
current: vec![],
qa: vec![],
merge: vec![],
done: vec![],
};
let json = serde_json::to_value(&resp).unwrap();
assert_eq!(json["type"], "pipeline_state");
assert_eq!(json["upcoming"].as_array().unwrap().len(), 1);
assert_eq!(json["upcoming"][0]["story_id"], "10_story_test");
assert!(json["current"].as_array().unwrap().is_empty());
assert!(json["done"].as_array().unwrap().is_empty());
}
#[test]
@@ -696,6 +700,12 @@ mod tests {
}],
qa: vec![],
merge: vec![],
done: vec![UpcomingStory {
story_id: "50_story_done".to_string(),
name: Some("Done Story".to_string()),
error: None,
agent: None,
}],
};
let resp: WsResponse = state.into();
let json = serde_json::to_value(&resp).unwrap();
@@ -706,6 +716,8 @@ mod tests {
assert_eq!(json["current"][0]["story_id"], "2_story_b");
assert!(json["qa"].as_array().unwrap().is_empty());
assert!(json["merge"].as_array().unwrap().is_empty());
assert_eq!(json["done"].as_array().unwrap().len(), 1);
assert_eq!(json["done"][0]["story_id"], "50_story_done");
}
#[test]
@@ -715,6 +727,7 @@ mod tests {
current: vec![],
qa: vec![],
merge: vec![],
done: vec![],
};
let resp: WsResponse = state.into();
let json = serde_json::to_value(&resp).unwrap();
@@ -723,6 +736,7 @@ mod tests {
assert!(json["current"].as_array().unwrap().is_empty());
assert!(json["qa"].as_array().unwrap().is_empty());
assert!(json["merge"].as_array().unwrap().is_empty());
assert!(json["done"].as_array().unwrap().is_empty());
}
// ── WsResponse JSON round-trip (string form) ────────────────────
@@ -849,6 +863,7 @@ mod tests {
}],
qa: vec![],
merge: vec![],
done: vec![],
};
let resp: WsResponse = state.into();
let json = serde_json::to_value(&resp).unwrap();