storkit: done 431_story_qa_agent_reviews_code_changes_against_acceptance_criteria

This commit is contained in:
dave
2026-03-28 15:33:19 +00:00
parent 9935311c35
commit b811b9188f
@@ -0,0 +1,24 @@
---
name: "QA agent reviews code changes against acceptance criteria"
---
# Story 431: QA agent reviews code changes against acceptance criteria
## User Story
As a project owner, I want the QA agent to actually verify that the coder's implementation matches the story's acceptance criteria, so that incomplete or incorrect work is caught before merge.
## Acceptance Criteria
- [ ] QA agent reads the story's acceptance criteria before reviewing code
- [ ] QA agent reads the full diff against master to understand what changed
- [ ] For each AC, QA agent verifies the code addresses it and explains how
- [ ] QA agent flags incomplete implementations: todo!(), unimplemented!(), missing match arms, placeholder values
- [ ] QA agent checks that new code has corresponding test coverage
- [ ] QA agent produces a structured report: each AC with pass/fail and explanation
- [ ] If any AC is not met, QA rejects the story with a clear reason so the coder can fix it
- [ ] Deterministic gates (clippy, tests) still run as a prerequisite before the AC review
## Out of Scope
- TBD