From b811b9188fc51d17aa846ff343d5b7db6a8e7b9e Mon Sep 17 00:00:00 2001 From: dave Date: Sat, 28 Mar 2026 15:33:19 +0000 Subject: [PATCH] storkit: done 431_story_qa_agent_reviews_code_changes_against_acceptance_criteria --- ...ode_changes_against_acceptance_criteria.md | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .storkit/work/5_done/431_story_qa_agent_reviews_code_changes_against_acceptance_criteria.md diff --git a/.storkit/work/5_done/431_story_qa_agent_reviews_code_changes_against_acceptance_criteria.md b/.storkit/work/5_done/431_story_qa_agent_reviews_code_changes_against_acceptance_criteria.md new file mode 100644 index 00000000..07c85eeb --- /dev/null +++ b/.storkit/work/5_done/431_story_qa_agent_reviews_code_changes_against_acceptance_criteria.md @@ -0,0 +1,24 @@ +--- +name: "QA agent reviews code changes against acceptance criteria" +--- + +# Story 431: QA agent reviews code changes against acceptance criteria + +## User Story + +As a project owner, I want the QA agent to actually verify that the coder's implementation matches the story's acceptance criteria, so that incomplete or incorrect work is caught before merge. + +## Acceptance Criteria + +- [ ] QA agent reads the story's acceptance criteria before reviewing code +- [ ] QA agent reads the full diff against master to understand what changed +- [ ] For each AC, QA agent verifies the code addresses it and explains how +- [ ] QA agent flags incomplete implementations: todo!(), unimplemented!(), missing match arms, placeholder values +- [ ] QA agent checks that new code has corresponding test coverage +- [ ] QA agent produces a structured report: each AC with pass/fail and explanation +- [ ] If any AC is not met, QA rejects the story with a clear reason so the coder can fix it +- [ ] Deterministic gates (clippy, tests) still run as a prerequisite before the AC review + +## Out of Scope + +- TBD