storkit: merge 463_story_configurable_rate_limit_notification_suppression

This commit is contained in:
dave
2026-04-03 12:56:39 +00:00
parent f199bf3979
commit 8059df8330
4 changed files with 234 additions and 14 deletions
+12
View File
@@ -526,6 +526,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Should complete without panic
run_setup_commands(tmp.path(), &config).await;
@@ -548,6 +549,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Should complete without panic
run_setup_commands(tmp.path(), &config).await;
@@ -570,6 +572,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Setup command failures are non-fatal — should not panic or propagate
run_setup_commands(tmp.path(), &config).await;
@@ -592,6 +595,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Teardown failures are best-effort — should not propagate
assert!(run_teardown_commands(tmp.path(), &config).await.is_ok());
@@ -613,6 +617,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
let info = create_worktree(&project_root, "42_fresh_test", &config, 3001)
.await
@@ -641,6 +646,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// First creation
let _info1 = create_worktree(&project_root, "43_reuse_test", &config, 3001)
@@ -710,6 +716,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
let result = remove_worktree_by_story_id(tmp.path(), "99_nonexistent", &config).await;
@@ -737,6 +744,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
create_worktree(&project_root, "88_remove_by_id", &config, 3001)
.await
@@ -811,6 +819,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Even though setup commands fail, create_worktree must succeed
// so the agent can start and fix the problem itself.
@@ -841,6 +850,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// First creation — no setup commands, should succeed
create_worktree(&project_root, "173_reuse_fail", &empty_config, 3001)
@@ -861,6 +871,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
// Second call — worktree exists, setup commands fail, must still succeed
let result = create_worktree(&project_root, "173_reuse_fail", &failing_config, 3002).await;
@@ -887,6 +898,7 @@ mod tests {
max_coders: None,
max_retries: 2,
base_branch: None,
rate_limit_notifications: true,
};
let info = create_worktree(&project_root, "77_remove_async", &config, 3001)
.await