175 Commits

Author SHA1 Message Date
Dave
cffe63680d Fix MCP server URL to match actual running port (3010)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 16:17:54 +00:00
Dave
f5fffd64b8 story-kit: create 266_story_matrix_bot_structured_conversation_history 2026-03-17 16:17:34 +00:00
Dave
ad68bc912f story-kit: remove 266_story_matrix_bot_structured_conversation_history 2026-03-17 16:17:20 +00:00
Dave
d02d53d112 story-kit: create 266_story_matrix_bot_structured_conversation_history 2026-03-17 16:14:07 +00:00
Dave
3ce7276e89 Fix TS narrowing errors in Chat.test.tsx
TypeScript control flow analysis can't track reassignment inside vi.mock
callbacks, causing lastSendChatArgs to narrow to never. Use non-null
assertions after the explicit toBeNull() guard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-17 16:13:29 +00:00
Dave
6d87e64859 story-kit: queue 265_story_spikes_skip_merge_and_stop_for_human_review for QA 2026-03-17 16:11:52 +00:00
Dave
83db282892 Bump version to 0.2.0
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-17 16:08:59 +00:00
Dave
f5d5196bf5 Fix cross-signing bootstrap by passing UIA password auth
The homeserver requires User-Interactive Authentication before accepting
cross-signing keys. Pass the bot's password so bootstrap succeeds.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-17 16:08:39 +00:00
Dave
7ec869baa8 Fixing mcp location 2026-03-17 15:58:40 +00:00
Dave
1a257b3057 story-kit: start 265_story_spikes_skip_merge_and_stop_for_human_review 2026-03-17 15:58:28 +00:00
Dave
b9fd87ed7c story-kit: create 265_story_spikes_skip_merge_and_stop_for_human_review 2026-03-17 15:58:24 +00:00
Dave
fda763d3f0 story-kit: create 260_refactor_upgrade_libsqlite3_sys 2026-03-17 15:47:07 +00:00
Dave
77d89b17e8 story-kit: done 260_refactor_upgrade_libsqlite3_sys 2026-03-17 15:47:01 +00:00
Dave
df0fa46591 Revert "story-kit: merge 260_refactor_upgrade_libsqlite3_sys"
This reverts commit ea062400e5.
2026-03-17 15:45:52 +00:00
Dave
1f5d70ce0d story-kit: done 264_bug_claude_code_session_id_not_persisted_across_browser_refresh 2026-03-17 15:41:43 +00:00
Dave
0d46c86469 story-kit: merge 264_bug_claude_code_session_id_not_persisted_across_browser_refresh 2026-03-17 15:41:41 +00:00
Dave
a439f8fdcb story-kit: queue 264_bug_claude_code_session_id_not_persisted_across_browser_refresh for merge 2026-03-17 15:39:34 +00:00
Dave
1adddf4e4c story-kit: create 247_story_human_qa_gate_with_rejection_flow 2026-03-17 15:37:25 +00:00
Dave
23484716e2 story-kit: create 265_story_spikes_skip_merge_and_stop_for_human_review 2026-03-17 15:36:52 +00:00
Dave
92085f9071 story-kit: done 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption 2026-03-17 15:35:01 +00:00
Dave
ce899b569e story-kit: merge 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption 2026-03-17 15:34:58 +00:00
Dave
da7216630b story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:33:11 +00:00
Dave
b57c270144 story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:31:25 +00:00
Dave
230b8fdc35 story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:28:49 +00:00
Dave
75b2446801 story-kit: done 262_story_bot_error_notifications_for_story_failures 2026-03-17 15:27:51 +00:00
Dave
96779c9caf story-kit: merge 262_story_bot_error_notifications_for_story_failures 2026-03-17 15:27:48 +00:00
Dave
bf5d9ff6b1 story-kit: queue 264_bug_claude_code_session_id_not_persisted_across_browser_refresh for QA 2026-03-17 15:25:47 +00:00
Dave
c551faeea3 story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:19:41 +00:00
Dave
3f38f90a50 story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:19:33 +00:00
Dave
26a1328c89 story-kit: queue 262_story_bot_error_notifications_for_story_failures for merge 2026-03-17 15:18:57 +00:00
Dave
21b45b8dd7 story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for merge 2026-03-17 15:18:32 +00:00
Dave
3a860bd2d5 story-kit: start 264_bug_claude_code_session_id_not_persisted_across_browser_refresh 2026-03-17 15:16:14 +00:00
Dave
c2c95c18b4 story-kit: create 264_bug_claude_code_session_id_not_persisted_across_browser_refresh 2026-03-17 15:15:51 +00:00
Dave
e3a301009b story-kit: queue 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption for QA 2026-03-17 15:08:23 +00:00
Dave
c90bdc8907 story-kit: queue 262_story_bot_error_notifications_for_story_failures for QA 2026-03-17 15:07:17 +00:00
Dave
dba12a38c2 story-kit: start 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption 2026-03-17 15:00:34 +00:00
Dave
4b60452b27 story-kit: start 262_story_bot_error_notifications_for_story_failures 2026-03-17 14:57:27 +00:00
Dave
d2f677ae0c story-kit: create 263_story_matrix_bot_self_signs_device_keys_at_startup_for_verified_encryption 2026-03-17 14:56:59 +00:00
Dave
427bb6929a Ignoring some folders to keep vite running across merges 2026-03-17 14:48:37 +00:00
Dave
78c04ee576 story-kit: create 262_story_bot_error_notifications_for_story_failures 2026-03-17 14:44:04 +00:00
Dave
3309d26142 story-kit: done 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 14:38:08 +00:00
Dave
5a4a2aaa17 story-kit: merge 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 14:38:05 +00:00
Dave
d3786253ef story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for merge 2026-03-17 14:35:34 +00:00
Dave
76db12a53e story-kit: queue 262_story_bot_error_notifications_for_story_failures for QA 2026-03-17 14:25:37 +00:00
Dave
4eb5a01774 story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for QA 2026-03-17 14:20:40 +00:00
Dave
198f9ff5bf story-kit: start 262_story_bot_error_notifications_for_story_failures 2026-03-17 14:20:39 +00:00
Dave
e30773d088 story-kit: done 261_story_bot_notifications_when_stories_move_between_stages 2026-03-17 14:05:04 +00:00
Dave
a4affca9be story-kit: merge 261_story_bot_notifications_when_stories_move_between_stages 2026-03-17 14:05:02 +00:00
Dave
a067091354 story-kit: queue 261_story_bot_notifications_when_stories_move_between_stages for merge 2026-03-17 14:02:47 +00:00
Dave
da423d9c97 story-kit: queue 261_story_bot_notifications_when_stories_move_between_stages for QA 2026-03-17 13:58:47 +00:00
Dave
d6d080e30a story-kit: start 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 13:57:34 +00:00
Dave
9098c1ba9d story-kit: done 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 13:57:28 +00:00
Dave
511c5809f2 story-kit: remove 263_refactor_extract_common_matrix_messaging_for_story_notifications 2026-03-17 13:48:54 +00:00
Dave
ace8e59536 story-kit: create 262_story_bot_error_notifications_for_story_failures 2026-03-17 13:48:49 +00:00
Dave
fa128c52d9 story-kit: queue 262_story_bot_error_notifications_for_story_failures for merge 2026-03-17 13:48:41 +00:00
Dave
621cdea6df story-kit: start 261_story_bot_notifications_when_stories_move_between_stages 2026-03-17 13:48:31 +00:00
Dave
68233e3355 story-kit: queue 261_story_bot_notifications_when_stories_move_between_stages for merge 2026-03-17 13:48:17 +00:00
Dave
99d298035b story-kit: queue 262_story_bot_error_notifications_for_story_failures for merge 2026-03-17 13:45:56 +00:00
Dave
73b41d1c6c story-kit: queue 262_story_bot_error_notifications_for_story_failures for merge 2026-03-17 13:44:49 +00:00
Dave
1a56844661 story-kit: queue 261_story_bot_notifications_when_stories_move_between_stages for merge 2026-03-17 13:42:50 +00:00
Dave
48ff0ba205 story-kit: queue 261_story_bot_notifications_when_stories_move_between_stages for merge 2026-03-17 13:41:49 +00:00
Dave
50b29e0bed story-kit: done 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:41:35 +00:00
Dave
ea062400e5 story-kit: merge 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:41:33 +00:00
Dave
b0e4e04c9d story-kit: done 258_bug_auto_assign_not_called_after_merge_failure 2026-03-17 13:38:45 +00:00
Dave
02fe364349 story-kit: create 263_refactor_extract_common_matrix_messaging_for_story_notifications 2026-03-17 13:38:43 +00:00
Dave
3602f882d2 story-kit: merge 258_bug_auto_assign_not_called_after_merge_failure 2026-03-17 13:38:42 +00:00
Dave
730e7324ea story-kit: queue 260_refactor_upgrade_libsqlite3_sys for merge 2026-03-17 13:38:24 +00:00
Dave
ae73d95d50 story-kit: queue 262_story_bot_error_notifications_for_story_failures for QA 2026-03-17 13:36:34 +00:00
Dave
ae6dd3217b story-kit: queue 258_bug_auto_assign_not_called_after_merge_failure for merge 2026-03-17 13:35:27 +00:00
Dave
9a6f63b591 story-kit: queue 258_bug_auto_assign_not_called_after_merge_failure for QA 2026-03-17 13:32:08 +00:00
Dave
421eaec7ba story-kit: start 262_story_bot_error_notifications_for_story_failures 2026-03-17 13:27:28 +00:00
Dave
2c4e376054 story-kit: start 261_story_bot_notifications_when_stories_move_between_stages 2026-03-17 13:27:24 +00:00
Dave
1896a0ac49 story-kit: start 258_bug_auto_assign_not_called_after_merge_failure 2026-03-17 13:23:57 +00:00
Dave
b8d3978a54 story-kit: queue 260_refactor_upgrade_libsqlite3_sys for QA 2026-03-17 13:22:31 +00:00
Dave
72c50b6ffc story-kit: create 262_story_bot_error_notifications_for_story_failures 2026-03-17 13:20:14 +00:00
Dave
bab77fe105 story-kit: create 261_story_bot_notifications_when_stories_move_between_stages 2026-03-17 13:20:12 +00:00
Dave
1d935192e1 story-kit: done 259_story_move_story_kit_ignores_into_story_kit_gitignore 2026-03-17 13:15:04 +00:00
Dave
f89f78d77d story-kit: merge 259_story_move_story_kit_ignores_into_story_kit_gitignore 2026-03-17 13:15:02 +00:00
Dave
09a71b4515 story-kit: queue 259_story_move_story_kit_ignores_into_story_kit_gitignore for merge 2026-03-17 13:12:12 +00:00
Dave
988562fc82 story-kit: done 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 13:10:55 +00:00
Dave
ed0d5d9253 story-kit: merge 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 13:10:51 +00:00
Dave
bb265d7bd5 story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 13:08:13 +00:00
Dave
126a6f8dc3 story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 13:07:33 +00:00
Dave
3b66b89c90 story-kit: remove 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 13:07:03 +00:00
Dave
e9879ce1c7 story-kit: create 92_spike_stop_auto_committing_intermediate_pipeline_moves 2026-03-17 13:06:37 +00:00
Dave
d30192b6a3 story-kit: create 92_spike_stop_auto_committing_intermediate_pipeline_moves 2026-03-17 13:06:26 +00:00
Dave
93c4f06818 story-kit: queue 259_story_move_story_kit_ignores_into_story_kit_gitignore for QA 2026-03-17 13:06:24 +00:00
Dave
7dab810572 story-kit: start 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:01:20 +00:00
Dave
cb7dde9fc1 story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 13:01:15 +00:00
Dave
7f70d1118f story-kit: create 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:01:10 +00:00
Dave
5638402745 story-kit: create 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:01:09 +00:00
Dave
e90bf38fa2 story-kit: create 260_refactor_upgrade_libsqlite3_sys 2026-03-17 13:00:48 +00:00
Dave
46ab4cdd8a story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 13:00:18 +00:00
Dave
7341fca72e story-kit: start 259_story_move_story_kit_ignores_into_story_kit_gitignore 2026-03-17 12:57:20 +00:00
Dave
fdb4a4fb62 story-kit: create 259_story_move_story_kit_ignores_into_story_kit_gitignore 2026-03-17 12:56:39 +00:00
Dave
87791c755e story-kit: create 259_story_move_story_kit_ignores_into_story_kit_gitignore 2026-03-17 12:53:52 +00:00
Dave
a4ce5f8f7c story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for QA 2026-03-17 12:52:04 +00:00
Dave
a9a84bee6d story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 12:52:01 +00:00
Dave
34755d3f63 story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 12:50:00 +00:00
Dave
ec553a5b8a story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 12:49:40 +00:00
Dave
076324c470 Fix pipe buffer deadlock in quality gate test runner
run_command_with_timeout piped stdout/stderr but only read them after
the child exited. When test output exceeded the 64KB OS pipe buffer,
the child blocked on write() while the parent blocked on waitpid() —
a permanent deadlock that caused every merge pipeline to hang.

Drain both pipes in background threads so the buffers never fill.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 12:49:12 +00:00
Dave
5ed2737edc story-kit: accept 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch 2026-03-17 12:48:11 +00:00
Dave
0eafddd186 story-kit: done 257_story_rename_storkit_to_story_kit_in_header 2026-03-17 12:46:33 +00:00
Dave
7d4f722942 story-kit: merge 257_story_rename_storkit_to_story_kit_in_header 2026-03-17 12:46:30 +00:00
Dave
5d80d289c4 story-kit: create 258_bug_auto_assign_not_called_after_merge_failure 2026-03-17 12:35:08 +00:00
Dave
7c6e1b445d Make merge_agent_work async to avoid MCP 60-second tool timeout
The merge pipeline (squash merge + quality gates) takes well over 60
seconds. Claude Code's MCP HTTP transport times out at 60s, causing
"completed with no output" — the mergemaster retries fruitlessly.

merge_agent_work now starts the pipeline as a background task and
returns immediately. A new get_merge_status tool lets the mergemaster
poll until the job reaches a terminal state. Also adds a double-start
guard so concurrent calls for the same story are rejected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 12:15:42 +00:00
Dave
a85d1a1170 story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for merge 2026-03-17 12:14:53 +00:00
Dave
afc1ab5e0e story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for merge 2026-03-17 11:51:29 +00:00
Dave
32b6439f2f story-kit: create 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 11:46:28 +00:00
Dave
85e56e0ea8 story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for merge 2026-03-17 11:45:29 +00:00
Dave
b63fa6be4f story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 11:43:23 +00:00
Dave
f012311303 story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for merge 2026-03-17 11:39:28 +00:00
Dave
af0aa007ca story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for merge 2026-03-17 11:36:05 +00:00
Dave
b2aec94d4c story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for QA 2026-03-17 11:35:03 +00:00
Dave
2ac550008a story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 11:32:49 +00:00
Dave
ebbbfed1d9 Add 10-minute timeout to test commands and disable e2e in merge pipeline
Test commands in run_project_tests now use wait-timeout to enforce a
600-second ceiling, preventing hung processes (e.g. Playwright with no
server) from blocking the merge pipeline indefinitely. Also disables
e2e tests in script/test until the merge workspace can run them safely.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 11:32:44 +00:00
Dave
fd6ef83f76 story-kit: queue 257_story_rename_storkit_to_story_kit_in_header for QA 2026-03-17 11:29:57 +00:00
Dave
473461b65d story-kit: start 257_story_rename_storkit_to_story_kit_in_header 2026-03-17 11:24:55 +00:00
Dave
dc8d639d02 story-kit: create 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 11:24:20 +00:00
Dave
594fc500cf story-kit: create 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch 2026-03-17 11:24:15 +00:00
Dave
5448a99759 story-kit: done 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 11:24:09 +00:00
Dave
f5524b3ae1 story-kit: accept 255_story_show_agent_logs_in_expanded_story_popup 2026-03-17 11:23:36 +00:00
Dave
4585537dd8 story-kit: create 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch 2026-03-17 11:23:19 +00:00
Dave
57911fd9e7 story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-17 11:23:11 +00:00
Dave
b6f5169b56 story-kit: start 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch 2026-03-17 11:23:07 +00:00
Dave
a4b99c68da story-kit: done 255_story_show_agent_logs_in_expanded_story_popup 2026-03-17 11:23:04 +00:00
Dave
85062c338f story-kit: done 254_story_add_refactor_work_item_type 2026-03-17 11:23:01 +00:00
Dave
a7f3d283ec story-kit: done 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 11:22:57 +00:00
Dave
6cc9d1bde9 story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for merge 2026-03-17 11:14:16 +00:00
Dave
a82fa37730 story-kit: accept 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes 2026-03-17 03:26:24 +00:00
Dave
06ceab3e22 story-kit: merge 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-17 01:02:34 +00:00
Dave
58438f3ab6 story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for merge 2026-03-17 01:02:04 +00:00
Dave
59bb7dbc3a story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for merge 2026-03-17 00:59:38 +00:00
Dave
9c2471fbcc story-kit: queue 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch for merge 2026-03-17 00:52:34 +00:00
Dave
f383d0cb4f story-kit: queue 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression for QA 2026-03-17 00:52:02 +00:00
Dave
be61803af0 story-kit: merge 255_story_show_agent_logs_in_expanded_story_popup 2026-03-17 00:49:43 +00:00
Dave
c132d4f5c0 story-kit: queue 255_story_show_agent_logs_in_expanded_story_popup for merge 2026-03-17 00:49:20 +00:00
Dave
263ba440dc story-kit: queue 255_story_show_agent_logs_in_expanded_story_popup for merge 2026-03-17 00:46:33 +00:00
Dave
2fae9066e2 story-kit: merge 254_story_add_refactor_work_item_type 2026-03-17 00:40:37 +00:00
Dave
3553f59078 story-kit: queue 254_story_add_refactor_work_item_type for merge 2026-03-17 00:39:55 +00:00
Dave
78ea96d0a9 story-kit: queue 255_story_show_agent_logs_in_expanded_story_popup for QA 2026-03-17 00:36:40 +00:00
Dave
79d3eccc46 story-kit: queue 254_story_add_refactor_work_item_type for merge 2026-03-17 00:34:56 +00:00
Dave
c21a087399 story-kit: queue 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch for merge 2026-03-17 00:30:47 +00:00
Dave
67942d466c story-kit: done 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes 2026-03-17 00:30:26 +00:00
Dave
1d6a4fa8c6 story-kit: queue 254_story_add_refactor_work_item_type for QA 2026-03-17 00:29:53 +00:00
Dave
250f3ff819 story-kit: accept 242_story_status_slash_command 2026-03-17 00:26:51 +00:00
Dave
a02ea3c292 story-kit: queue 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes for merge 2026-03-17 00:25:50 +00:00
Dave
bbc5d9c90c story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 00:21:03 +00:00
Dave
24f6a5c7cc story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for merge 2026-03-17 00:13:44 +00:00
Dave
ab3420fa90 story-kit: queue 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch for merge 2026-03-17 00:13:12 +00:00
Dave
4c6228abee story-kit: queue 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes for QA 2026-03-17 00:12:25 +00:00
Dave
6df28d5393 story-kit: queue 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch for merge 2026-03-17 00:04:39 +00:00
Dave
2ad59ba155 story-kit: accept 249_story_agent_assignment_via_story_front_matter 2026-03-17 00:04:13 +00:00
Dave
319fc3823a story-kit: queue 250_bug_merge_pipeline_cherry_pick_fails_with_bad_revision_on_merge_queue_branch for merge 2026-03-17 00:04:12 +00:00
Dave
b9f3449021 story-kit: support agent assignment via story front matter (story 249)
Adds an optional `agent:` field to story file front matter so that a
specific agent can be requested for a story. The auto-assign loop now:

1. Reads the front-matter `agent` field for each story before picking
   a free agent.
2. If a preferred agent is named, uses it when free; skips the story
   (without falling back) when that agent is busy.
3. Falls back to the existing `find_free_agent_for_stage` behaviour
   when no preference is specified.

Ported from feature branch that predated the agents.rs module refactoring.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 00:03:49 +00:00
Dave
cd7444ac5c story-kit: done 249_story_agent_assignment_via_story_front_matter 2026-03-17 00:03:21 +00:00
Dave
f5d9c98e74 story-kit: queue 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification for QA 2026-03-16 23:59:22 +00:00
Dave
7cd19e248c story-kit: start 245_bug_chat_history_persistence_lost_on_page_refresh_story_145_regression 2026-03-16 23:57:48 +00:00
Dave
ec5024a089 story-kit: start 255_story_show_agent_logs_in_expanded_story_popup 2026-03-16 23:57:05 +00:00
Dave
9041cd1d16 story-kit: start 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-16 23:53:53 +00:00
Dave
0a0624795c story-kit: create 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification 2026-03-16 23:53:26 +00:00
Dave
d8d0d7936c story-kit: queue 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes for QA 2026-03-16 23:46:47 +00:00
Dave
55ea8e6aaf story-kit: accept 251_bug_archive_sweep_not_moving_stories_from_done_to_archived 2026-03-16 23:44:13 +00:00
Dave
1598d2a453 story-kit: done 251_bug_archive_sweep_not_moving_stories_from_done_to_archived 2026-03-16 23:44:09 +00:00
Dave
0120de5f00 story-kit: queue 249_story_agent_assignment_via_story_front_matter for QA 2026-03-16 23:44:00 +00:00
Dave
21835bc37d story-kit: queue 254_story_add_refactor_work_item_type for QA 2026-03-16 23:42:04 +00:00
Dave
f01fa6c527 story-kit: start 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes 2026-03-16 23:41:05 +00:00
Dave
a51488a0ce story-kit: create 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes 2026-03-16 23:40:02 +00:00
Dave
9054ac013e story-kit: accept 252_story_coder_agents_must_find_root_causes_for_bugs 2026-03-16 23:38:24 +00:00
Dave
95eea3a624 story-kit: start 254_story_add_refactor_work_item_type 2026-03-16 23:35:18 +00:00
Dave
6b9390b243 story-kit: start 255_story_show_agent_logs_in_expanded_story_popup 2026-03-16 23:34:24 +00:00
Dave
3ed9b7a185 story-kit: create 255_story_show_agent_logs_in_expanded_story_popup 2026-03-16 23:29:20 +00:00
Dave
bd7426131f story-kit: create 255_story_show_agent_logs_in_expanded_story_popup 2026-03-16 23:29:05 +00:00
Dave
e0132a7807 story-kit: create 255_bug_agent_logs_tab_shows_no_output_in_expanded_story_popup 2026-03-16 23:28:24 +00:00
Dave
b829783a84 story-kit: queue 253_bug_watcher_and_auto_assign_do_not_reinitialize_when_project_root_changes for QA 2026-03-16 23:27:28 +00:00
55 changed files with 2209 additions and 257 deletions

View File

@@ -59,7 +59,8 @@
"mcp__story-kit__*",
"Edit",
"Write",
"Bash(find *)"
"Bash(find *)",
"Bash(sqlite3 *)"
]
}
}

15
.gitignore vendored
View File

@@ -4,23 +4,10 @@
# Local environment (secrets)
.env
# App specific
# App specific (root-level; story-kit subdirectory patterns live in .story_kit/.gitignore)
store.json
.story_kit_port
# Bot config (contains credentials)
.story_kit/bot.toml
# Matrix SDK state store
.story_kit/matrix_store/
# Agent worktrees and merge workspace (managed by the server, not tracked in git)
.story_kit/worktrees/
.story_kit/merge_workspace/
# Coverage reports (generated by cargo-llvm-cov, not tracked in git)
.story_kit/coverage/
# Rust stuff
target

View File

@@ -2,7 +2,7 @@
"mcpServers": {
"story-kit": {
"type": "http",
"url": "http://localhost:3001/mcp"
"url": "http://localhost:3010/mcp"
}
}
}

13
.story_kit/.gitignore vendored Normal file
View File

@@ -0,0 +1,13 @@
# Bot config (contains credentials)
bot.toml
# Matrix SDK state store
matrix_store/
matrix_device_id
# Agent worktrees and merge workspace (managed by the server, not tracked in git)
worktrees/
merge_workspace/
# Coverage reports (generated by cargo-llvm-cov, not tracked in git)
coverage/

View File

@@ -0,0 +1,24 @@
---
name: "Upgrade libsqlite3-sys"
---
# Refactor 260: Upgrade libsqlite3-sys
## Description
Upgrade the `libsqlite3-sys` dependency from `0.35.0` to `0.37.0`. The crate is used with `features = ["bundled"]` for static builds.
## Version Notes
- Current: `libsqlite3-sys 0.35.0` (pinned transitively by `matrix-sdk 0.16.0``matrix-sdk-sqlite``rusqlite 0.37.x`)
- Target: `libsqlite3-sys 0.37.0`
- Latest upstream rusqlite: `0.39.0`
- **Blocker**: `matrix-sdk 0.16.0` pins `rusqlite 0.37.x` which pins `libsqlite3-sys 0.35.0`. A clean upgrade requires either waiting for matrix-sdk to bump their rusqlite dep, or upgrading matrix-sdk itself.
- **Reverted 2026-03-17**: A previous coder vendored the entire rusqlite crate with a fake `0.37.99` version and patched its libsqlite3-sys dep. This was too hacky — reverted to clean `0.35.0`.
## Acceptance Criteria
- [ ] `libsqlite3-sys` is upgraded to `0.37.0` via a clean dependency path (no vendored forks)
- [ ] `cargo build` succeeds
- [ ] All tests pass
- [ ] No `[patch.crates-io]` hacks or vendored crates

View File

@@ -0,0 +1,21 @@
---
name: "Matrix bot structured conversation history"
---
# Story 266: Matrix bot structured conversation history
## User Story
As a user chatting with the Matrix bot, I want it to remember and own its prior responses naturally, so that conversations feel like talking to one continuous entity rather than a new instance each message.
## Acceptance Criteria
- [ ] Conversation history is passed as structured API messages (user/assistant turns) rather than a flattened text prefix
- [ ] Claude recognises its prior responses as its own, maintaining consistent personality across a conversation
- [ ] Per-room history survives server restarts (persisted to disk or database)
- [ ] Rolling window trimming still applies to keep context bounded
- [ ] Multi-user rooms still attribute messages to the correct sender
## Out of Scope
- TBD

View File

@@ -6,7 +6,7 @@ name: "Stop auto-committing intermediate pipeline moves"
## Goal
Determine how to stop the filesystem watcher from auto-committing every pipeline stage move (upcoming -> current -> qa -> merge) while still committing at terminal states (creation in upcoming, acceptance in archived). This keeps git history clean while preserving cross-machine portability for completed work.
Determine how to stop the filesystem watcher from auto-committing every pipeline stage move (upcoming -> current -> qa -> merge -> done -> archive) while still committing at terminal states (creation in upcoming, acceptance in done and archived). This keeps git history clean while preserving cross-machine portability for completed work.
## Context

View File

@@ -1,36 +0,0 @@
---
name: "Chat history persistence lost on page refresh (story 145 regression)"
---
## Rejection Notes
**2026-03-16:** Previous coder produced zero code changes — feature branch had no diff against master. The coder must actually use `git bisect` to find the breaking commit and produce a surgical fix. Do not submit with no code changes.
# Bug 245: Chat history persistence lost on page refresh (story 145 regression)
## Description
Story 145 implemented localStorage persistence for chat history across page reloads. This is no longer working — refreshing the page loses all conversation context. This is a regression of the feature delivered in story 145.
## How to Reproduce
1. Open the web UI and have a conversation with the agent
2. Refresh the page (F5 or Cmd+R)
## Actual Result
Chat history is gone after refresh — the UI shows a blank conversation.
## Expected Result
Chat history is restored from localStorage on page load, as implemented in story 145.
## Acceptance Criteria
- [ ] Chat messages survive a full page refresh
- [ ] Chat messages are restored from localStorage on component mount
- [ ] Behaviour matches the original acceptance criteria from story 145
## Investigation Notes
**Use `git bisect` to find the commit that broke this.** Story 145 delivered working localStorage persistence — something after that regressed it. Find the breaking commit, understand the root cause, and fix it there. Do NOT layer on a new implementation. Revert or surgically fix the regression.

View File

@@ -0,0 +1,33 @@
---
name: "Spikes skip merge and stop for human review"
agent: coder-opus
---
# Story 265: Spikes skip merge and stop for human review
## User Story
As a user, I want spike work items to stop after QA instead of auto-advancing to the merge stage, so that I can review the spike's findings and prototype code in the worktree before deciding what to do with them.
## Context
Spikes are investigative — their value is the findings and any prototype code, not a merge to master. The user needs to:
- Read the spike document with findings
- Review prototype code in the worktree
- Optionally build and run the prototype to validate the approach
- Then manually decide: archive the spike and create follow-up stories, or reject and re-investigate
Currently all work items follow the same pipeline: coder → QA → merge → done. Spikes should diverge after QA and wait for human review instead of auto-advancing to merge.
## Acceptance Criteria
- [ ] Items with `_spike_` in the filename skip the merge stage after QA passes
- [ ] After QA, spike items remain accessible for human review (worktree preserved, not cleaned up)
- [ ] Spikes do not auto-advance to `4_merge/` — they stay in `3_qa/` or move to a review-hold state
- [ ] The human can manually archive the spike when done reviewing
- [ ] Non-spike items (stories, bugs, refactors) continue through the full pipeline as before
## Out of Scope
- New UI for spike review (manual file inspection is fine)
- Changes to the spike creation flow

View File

@@ -0,0 +1,68 @@
---
name: "Chat history persistence lost on page refresh (story 145 regression)"
agent: coder-opus
---
## Rejection Notes
**2026-03-16:** Previous coder produced zero code changes — feature branch had no diff against master. The coder must actually use `git bisect` to find the breaking commit and produce a surgical fix. Do not submit with no code changes.
**2026-03-17:** Re-opened. Multiple fix attempts have failed. See investigation notes below for the actual root cause.
# Bug 245: Chat history persistence lost on page refresh (story 145 regression)
## Description
Story 145 implemented localStorage persistence for chat history across page reloads. This is no longer working — refreshing the page loses all conversation context. This is a regression of the feature delivered in story 145.
## How to Reproduce
1. Open the web UI and have a conversation with the agent
2. Refresh the page (F5 or Cmd+R)
3. Send a new message
4. The LLM has no knowledge of the prior conversation
## Actual Result
Chat history is gone after refresh — the UI shows a blank conversation. Even if messages appear in the UI (loaded from localStorage), the LLM does not receive them as context on the next exchange.
## Expected Result
Chat history is restored from localStorage on page load, as implemented in story 145. The LLM should receive the full conversation history when the user sends a new message after refresh.
## Acceptance Criteria
- [ ] Chat messages survive a full page refresh (visible in UI)
- [ ] Chat messages are restored from localStorage on component mount
- [ ] After refresh, the LLM receives full prior conversation history as context when the user sends the next message
- [ ] Behaviour matches the original acceptance criteria from story 145
## Investigation Notes (2026-03-17)
### Root cause analysis
The frontend correctly:
1. Persists messages to localStorage in `useChatHistory.ts` (key: `storykit-chat-history:{projectPath}`)
2. Loads them on mount
3. Sends the FULL history array to the backend via `wsRef.current?.sendChat(newHistory, config)` in `Chat.tsx` line ~558
The backend bug is in `server/src/llm/chat.rs`:
- The `chat()` function receives the full `messages: Vec<Message>` from the client
- Line ~283: `let mut current_history = messages.clone()` — correctly clones full history
- Lines ~299-318: Adds 2 system prompts at position 0 and 1
- Lines ~323-404: Main LLM loop generates new assistant/tool messages
- **Line ~407: `ChatResult { messages: new_messages }` — BUG: returns ONLY the newly generated turn, not the full `current_history`**
During streaming, the `on_update()` callbacks DO send `current_history[2..]` (full history minus system prompts), which is correct. But there may be a reconciliation issue on the frontend where the final state doesn't include the full history.
### Key files
- `frontend/src/hooks/useChatHistory.ts` — localStorage persistence
- `frontend/src/components/Chat.tsx` — sends full history, handles `onUpdate` callbacks
- `frontend/src/api/client.ts` — WebSocket client
- `server/src/http/ws.rs` — WebSocket handler, passes messages to chat()
- `server/src/llm/chat.rs`**THE BUG** at line ~407, ChatResult returns only new_messages
### What NOT to do
- Do NOT layer on a new localStorage implementation. The localStorage code works fine.
- Do NOT add server-side persistence. The "dumb pipe" architecture is correct.
- The fix should be surgical — ensure the full conversation history round-trips correctly through the backend.

View File

@@ -0,0 +1,34 @@
---
name: "Bot must verify other users' cross-signing identity before checking device verification"
agent: mergemaster
---
# Story 256: Bot must verify other users' cross-signing identity before checking device verification
## User Story
As a Matrix user messaging the bot, I want the bot to correctly recognize my cross-signing-verified devices, so that my messages are not rejected when I have a valid verified identity.
## Acceptance Criteria
- [ ] The bot's `check_sender_verified` function (or equivalent) verifies the sender's identity trust status, not just individual device verification
- [ ] When @yossarian:crashlabs.io (who has valid cross-signing keys) sends a message in an encrypted room, the bot accepts it instead of rejecting with 'no cross-signing-verified device found'
- [ ] The bot still rejects messages from users who genuinely have no cross-signing setup
- [ ] Existing tests (if any) continue to pass after the change
## Out of Scope
- TBD
## Test Results
<!-- story-kit-test-results: {"unit":[{"name":"sender_with_cross_signing_identity_is_accepted","status":"pass","details":"Verifies get_user_identity Some(_) → accepted"},{"name":"sender_without_cross_signing_identity_is_rejected","status":"pass","details":"Verifies get_user_identity None → rejected"}],"integration":[]} -->
### Unit Tests (2 passed, 0 failed)
- ✅ sender_with_cross_signing_identity_is_accepted — Verifies get_user_identity Some(_) → accepted
- ✅ sender_without_cross_signing_identity_is_rejected — Verifies get_user_identity None → rejected
### Integration Tests (0 passed, 0 failed)
*No integration tests recorded.*

View File

@@ -0,0 +1,15 @@
---
name: "Rename StorkIt to Story Kit in the header"
---
# Story 257: Rename "StorkIt" to "Story Kit" in the header
## Description
The ChatHeader component displays "StorkIt" as the app title. It should say "Story Kit" instead.
## Acceptance Criteria
- [ ] The header in `ChatHeader.tsx` displays "Story Kit" instead of "StorkIt"
- [ ] The test in `ChatHeader.test.tsx` is updated to match
- [ ] All existing tests pass

View File

@@ -0,0 +1,26 @@
---
name: "Auto-assign not called after merge failure"
---
# Bug 258: Auto-assign not called after merge failure
## Description
When the background merge pipeline fails (e.g. quality gate timeout), `auto_assign_available_work` is never called. The story stays in `4_merge/` with no agent assigned, requiring manual intervention.
### Root cause
In `pool.rs`, `start_merge_agent_work` spawns a tokio task that calls `run_merge_pipeline`. On failure, the task updates the job status to `Failed` but does NOT call `auto_assign_available_work`. The only call to `auto_assign` in the merge pipeline is inside `run_merge_pipeline` on the success path (line ~1251).
The `spawn_pipeline_advance` completion handler does call `auto_assign` after the mergemaster agent exits, but only on the success path (post-merge tests pass → move to done → auto_assign). On failure, it returns early without triggering auto-assign.
There is no periodic sweep — auto-assign is purely reactive (watcher events, agent completions, startup).
### Impact
After a merge failure, the story is permanently stuck in `4_merge/` with no agent. The only way to unstick it is to restart the server or manually trigger a watcher event.
## Acceptance Criteria
- [ ] After a merge pipeline failure, `auto_assign_available_work` is called so the mergemaster can retry
- [ ] Stories in `4_merge/` do not get permanently stuck after transient merge failures

View File

@@ -0,0 +1,20 @@
---
name: "Move story-kit ignores into .story_kit/.gitignore"
---
# Story 259: Move story-kit ignores into .story_kit/.gitignore
## User Story
As a developer using story-kit, I want story-kit-specific gitignore patterns to live inside .story_kit/.gitignore, so that the host project's root .gitignore stays clean and story-kit concerns are self-contained.
## Acceptance Criteria
- [ ] A .gitignore file exists at .story_kit/.gitignore containing all story-kit-specific ignore patterns
- [ ] The root .gitignore no longer contains story-kit-specific ignore patterns
- [ ] The deterministic project scaffold process creates .story_kit/.gitignore when initialising a new project
- [ ] Existing repos continue to work correctly after the change (no previously-ignored files become tracked)
## Out of Scope
- TBD

View File

@@ -0,0 +1,19 @@
---
name: "Bot notifications when stories move between stages"
agent: coder-opus
---
# Story 261: Bot notifications when stories move between stages
## User Story
As a user, I want to receive bot notifications in the channel whenever a story moves between pipeline stages, so that I can track progress without manually checking status.
## Acceptance Criteria
- [ ] Bot sends a notification to the channel each time a story transitions between stages (e.g. upcoming → current, current → QA, QA → merge, merge → done)
- [ ] Notification includes the story number, name, and the stage transition (from → to)
## Out of Scope
- TBD

View File

@@ -0,0 +1,24 @@
---
name: "Bot error notifications for story failures (with shared messaging)"
---
# Story 262: Bot error notifications for story failures
## User Story
As a user, I want to receive bot notifications with an error icon in the channel whenever a story errors out (e.g. merge failure), so that I'm immediately aware of problems.
## Design Constraint
Story 261 adds stage-transition notifications using the same Matrix messaging path. Extract a shared utility/module for sending Matrix messages so that both error notifications (this story) and stage-transition notifications (261) use the same code path. Do not duplicate Matrix message-sending logic.
## Acceptance Criteria
- [ ] Bot sends an error notification to the channel when a story encounters a failure (e.g. merge failure)
- [ ] Notification includes an error icon to distinguish it from normal stage-transition notifications
- [ ] Notification includes the story number, name, and a description of the error
- [ ] Matrix message-sending logic is in a shared module usable by both error and stage-transition notifications
## Out of Scope
- Stage-transition notifications (covered by story 261)

View File

@@ -0,0 +1,21 @@
---
name: "Matrix bot self-signs device keys at startup for verified encryption"
agent: mergemaster
---
# Story 263: Matrix bot self-signs device keys at startup for verified encryption
## User Story
As a Matrix room participant, I want the bot's messages to not show "encrypted by a device not verified by its owner" warnings, so that I have confidence the bot's encryption is fully verified.
## Acceptance Criteria
- [ ] At startup the bot checks whether its own device keys have been self-signed (cross-signed by its own user identity)
- [ ] If the device keys are not self-signed, the bot signs them automatically
- [ ] After signing, the bot uploads the new signatures to the homeserver
- [ ] After a clean start (fresh matrix_store / device_id) the bot's messages no longer show the 'encrypted by a device not verified by its owner' warning
## Out of Scope
- TBD

View File

@@ -0,0 +1,43 @@
---
name: "Claude Code session ID not persisted across browser refresh"
---
# Bug 264: Claude Code session ID not persisted across browser refresh
## Description
The Claude Code provider uses a session_id to resume conversations via `--resume <id>`. This session_id is stored in React state (`claudeSessionId`) but is NOT persisted to localStorage. After a browser refresh, the session_id is lost (`null`), so Claude Code cannot resume the prior session.
A fallback exists (`build_claude_code_context_prompt` in `server/src/llm/chat.rs:188`) that injects prior messages as flattened text inside a `<conversation_history>` block, but this loses structure (tool calls, tool results, reasoning) and Claude Code treats it as informational text rather than actual conversation turns. In practice, the LLM does not retain meaningful context after refresh.
This is the root cause behind bug 245 (chat history persistence regression). The localStorage message persistence from story 145 works correctly for the UI, but the LLM context is not properly restored because the session cannot be resumed.
Key files:
- `frontend/src/components/Chat.tsx:174``claudeSessionId` is ephemeral React state
- `frontend/src/components/Chat.tsx:553` — session_id only sent when non-null
- `server/src/llm/chat.rs:278` — backend branches on session_id presence
- `server/src/llm/providers/claude_code.rs:44``--resume` flag passed to Claude CLI
## How to Reproduce
1. Open the Story Kit web UI and select claude-code-pty as the model
2. Have a multi-turn conversation with the agent
3. Refresh the browser (F5 or Cmd+R)
4. Send a new message referencing the prior conversation
5. The LLM has no knowledge of the prior conversation
## Actual Result
After refresh, claudeSessionId is null. Claude Code spawns a fresh session without --resume. The fallback text injection is too lossy to provide meaningful context. The LLM behaves as if the conversation never happened.
## Expected Result
After refresh, the Claude Code session is resumed via --resume, giving the LLM full context of the prior conversation including tool calls, reasoning, and all turns.
## Acceptance Criteria
- [ ] claudeSessionId is persisted to localStorage (scoped by project path) and restored on component mount
- [ ] After browser refresh, the next chat message includes session_id in the ProviderConfig
- [ ] Claude Code receives --resume with the persisted session_id after refresh
- [ ] Clearing the session (clear button) also clears the persisted session_id
- [ ] After server restart with session files intact on disk, conversation resumes correctly

View File

@@ -1,5 +1,6 @@
---
name: "Add refactor work item type"
merge_failure: "merge_agent_work tool returned empty output on two attempts. The merge-queue branch (merge-queue/254_story_add_refactor_work_item_type) was created with squash merge commit 27d24b2, and the merge workspace worktree exists at .story_kit/merge_workspace, but the pipeline never completed (no success/failure logged after MERGE-DEBUG calls). The stale merge workspace worktree may be blocking completion. Possibly related to bug 250 (merge pipeline cherry-pick fails with bad revision on merge-queue branch). Human intervention needed to: 1) clean up the merge-queue worktree and branch, 2) investigate why the merge pipeline hangs after creating the squash merge commit, 3) retry the merge."
---
# Story 254: Add refactor work item type

View File

@@ -0,0 +1,16 @@
---
name: "Show agent logs in expanded story popup"
merge_failure: "merge_agent_work tool returned empty output. The merge pipeline created the merge-queue branch (merge-queue/255_story_show_agent_logs_in_expanded_story_popup) and merge workspace worktree at .story_kit/merge_workspace, but hung without completing. This is the same issue that affected story 254 — likely related to bug 250 (merge pipeline cherry-pick fails with bad revision on merge-queue branch). The stale merge workspace worktree on the merge-queue branch may be blocking completion. Human intervention needed to: 1) clean up the merge workspace worktree and merge-queue branch, 2) investigate the root cause in the merge pipeline (possibly the cherry-pick/fast-forward step after squash merge), 3) retry the merge."
---
# Story 255: Show agent logs in expanded story popup
## Description
The expanded story popup has an "Agent Logs" tab that currently shows "No output". Implement the frontend and any necessary API wiring to display agent output in this tab. This is new functionality — agent logs have never been shown here before.
## Acceptance Criteria
- [ ] Agent Logs tab shows real-time output from running agents
- [ ] Agent Logs tab shows historical output from completed/failed agents
- [ ] Logs are associated with the correct story

10
Cargo.lock generated
View File

@@ -4028,6 +4028,7 @@ dependencies = [
"tokio-tungstenite 0.28.0",
"toml 1.0.6+spec-1.1.0",
"uuid",
"wait-timeout",
"walkdir",
]
@@ -4771,6 +4772,15 @@ dependencies = [
"memchr",
]
[[package]]
name = "wait-timeout"
version = "0.2.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "09ac3b126d3914f9849036f826e054cbabdc8519970b8998ddaf3b5bd3c65f11"
dependencies = [
"libc",
]
[[package]]
name = "walkdir"
version = "2.5.0"

View File

@@ -13,7 +13,7 @@ cd frontend
npm install
npm run dev
# Run the server (serves embedded frontend/dist/)
# In another terminal - run the server (serves embedded frontend/dist/)
cargo run
```

View File

@@ -108,6 +108,14 @@ export const agentsApi = {
baseUrl,
);
},
getAgentOutput(storyId: string, agentName: string, baseUrl?: string) {
return requestJson<{ output: string }>(
`/agents/${encodeURIComponent(storyId)}/${encodeURIComponent(agentName)}/output`,
{},
baseUrl,
);
},
};
/**

View File

@@ -26,6 +26,8 @@ type WsHandlers = {
) => void;
};
let capturedWsHandlers: WsHandlers | null = null;
// Captures the last sendChat call's arguments for assertion.
let lastSendChatArgs: { messages: Message[]; config: unknown } | null = null;
vi.mock("../api/client", () => {
const api = {
@@ -42,7 +44,9 @@ vi.mock("../api/client", () => {
capturedWsHandlers = handlers;
}
close() {}
sendChat() {}
sendChat(messages: Message[], config: unknown) {
lastSendChatArgs = { messages, config };
}
cancel() {}
}
return { api, ChatWebSocket };
@@ -529,6 +533,114 @@ describe("Chat localStorage persistence (Story 145)", () => {
confirmSpy.mockRestore();
});
it("Bug 245: messages survive unmount/remount cycle (page refresh)", async () => {
// Step 1: Render Chat and populate messages via WebSocket onUpdate
const { unmount } = render(
<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />,
);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
const history: Message[] = [
{ role: "user", content: "Persist me across refresh" },
{ role: "assistant", content: "I should survive a reload" },
];
act(() => {
capturedWsHandlers?.onUpdate(history);
});
// Verify messages are persisted to localStorage
expect(localStorage.getItem(STORAGE_KEY)).not.toBeNull();
const storedBefore = JSON.parse(localStorage.getItem(STORAGE_KEY) ?? "[]");
expect(storedBefore).toEqual(history);
// Step 2: Unmount the Chat component (simulates page unload)
unmount();
// Verify localStorage was NOT cleared by unmount
expect(localStorage.getItem(STORAGE_KEY)).not.toBeNull();
const storedAfterUnmount = JSON.parse(
localStorage.getItem(STORAGE_KEY) ?? "[]",
);
expect(storedAfterUnmount).toEqual(history);
// Step 3: Remount the Chat component (simulates page reload)
capturedWsHandlers = null;
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
// Verify messages are restored from localStorage
expect(
await screen.findByText("Persist me across refresh"),
).toBeInTheDocument();
expect(
await screen.findByText("I should survive a reload"),
).toBeInTheDocument();
// Verify localStorage still has the messages
const storedAfterRemount = JSON.parse(
localStorage.getItem(STORAGE_KEY) ?? "[]",
);
expect(storedAfterRemount).toEqual(history);
});
it("Bug 245: after refresh, sendChat includes full prior history", async () => {
// Step 1: Render, populate messages via onUpdate, then unmount (simulate refresh)
const { unmount } = render(
<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />,
);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
const priorHistory: Message[] = [
{ role: "user", content: "What is Rust?" },
{ role: "assistant", content: "Rust is a systems programming language." },
];
act(() => {
capturedWsHandlers?.onUpdate(priorHistory);
});
// Verify localStorage has the prior history
const stored = JSON.parse(localStorage.getItem(STORAGE_KEY) ?? "[]");
expect(stored).toEqual(priorHistory);
unmount();
// Step 2: Remount (simulates page reload) — messages load from localStorage
capturedWsHandlers = null;
lastSendChatArgs = null;
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
// Verify prior messages are displayed
expect(await screen.findByText("What is Rust?")).toBeInTheDocument();
// Step 3: Send a new message — sendChat should include the full prior history
const input = screen.getByPlaceholderText("Send a message...");
await act(async () => {
fireEvent.change(input, { target: { value: "Tell me more" } });
});
await act(async () => {
fireEvent.keyDown(input, { key: "Enter", shiftKey: false });
});
// Verify sendChat was called with ALL prior messages + the new one
expect(lastSendChatArgs).not.toBeNull();
const args = lastSendChatArgs!;
expect(args.messages).toHaveLength(3);
expect(args.messages[0]).toEqual({
role: "user",
content: "What is Rust?",
});
expect(args.messages[1]).toEqual({
role: "assistant",
content: "Rust is a systems programming language.",
});
expect(args.messages[2]).toEqual({
role: "user",
content: "Tell me more",
});
});
it("AC5: uses project-scoped storage key", async () => {
const otherKey = "storykit-chat-history:/other/project";
localStorage.setItem(
@@ -1164,3 +1276,114 @@ describe("Remove bubble styling from streaming messages (Story 163)", () => {
expect(styleAttr).not.toContain("background: transparent");
});
});
describe("Bug 264: Claude Code session ID persisted across browser refresh", () => {
const PROJECT_PATH = "/tmp/project";
const SESSION_KEY = `storykit-claude-session-id:${PROJECT_PATH}`;
const STORAGE_KEY = `storykit-chat-history:${PROJECT_PATH}`;
beforeEach(() => {
capturedWsHandlers = null;
lastSendChatArgs = null;
localStorage.clear();
setupMocks();
});
afterEach(() => {
localStorage.clear();
});
it("AC1: session_id is persisted to localStorage when onSessionId fires", async () => {
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
act(() => {
capturedWsHandlers?.onSessionId("test-session-abc");
});
await waitFor(() => {
expect(localStorage.getItem(SESSION_KEY)).toBe("test-session-abc");
});
});
it("AC2: after remount, next sendChat includes session_id from localStorage", async () => {
// Step 1: Render, receive a session ID, then unmount (simulate refresh)
localStorage.setItem(SESSION_KEY, "persisted-session-xyz");
localStorage.setItem(
STORAGE_KEY,
JSON.stringify([
{ role: "user", content: "Prior message" },
{ role: "assistant", content: "Prior reply" },
]),
);
const { unmount } = render(
<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />,
);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
unmount();
// Step 2: Remount (simulates page reload)
capturedWsHandlers = null;
lastSendChatArgs = null;
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
// Prior messages should be visible
expect(await screen.findByText("Prior message")).toBeInTheDocument();
// Step 3: Send a new message — config should include session_id
const input = screen.getByPlaceholderText("Send a message...");
await act(async () => {
fireEvent.change(input, { target: { value: "Continue" } });
});
await act(async () => {
fireEvent.keyDown(input, { key: "Enter", shiftKey: false });
});
expect(lastSendChatArgs).not.toBeNull();
expect(
(lastSendChatArgs!.config as Record<string, unknown>).session_id,
).toBe("persisted-session-xyz");
});
it("AC3: clearing the session also clears the persisted session_id", async () => {
localStorage.setItem(SESSION_KEY, "session-to-clear");
const confirmSpy = vi.spyOn(window, "confirm").mockReturnValue(true);
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
const newSessionBtn = screen.getByText(/New Session/);
await act(async () => {
fireEvent.click(newSessionBtn);
});
expect(localStorage.getItem(SESSION_KEY)).toBeNull();
confirmSpy.mockRestore();
});
it("AC1: storage key is scoped to project path", async () => {
const otherPath = "/other/project";
const otherKey = `storykit-claude-session-id:${otherPath}`;
localStorage.setItem(otherKey, "other-session");
render(<Chat projectPath={PROJECT_PATH} onCloseProject={vi.fn()} />);
await waitFor(() => expect(capturedWsHandlers).not.toBeNull());
act(() => {
capturedWsHandlers?.onSessionId("my-session");
});
await waitFor(() => {
expect(localStorage.getItem(SESSION_KEY)).toBe("my-session");
});
// Other project's session should be untouched
expect(localStorage.getItem(otherKey)).toBe("other-session");
});
});

View File

@@ -171,7 +171,16 @@ export function Chat({ projectPath, onCloseProject }: ChatProps) {
merge: [],
done: [],
});
const [claudeSessionId, setClaudeSessionId] = useState<string | null>(null);
const [claudeSessionId, setClaudeSessionId] = useState<string | null>(() => {
try {
return (
localStorage.getItem(`storykit-claude-session-id:${projectPath}`) ??
null
);
} catch {
return null;
}
});
const [activityStatus, setActivityStatus] = useState<string | null>(null);
const [permissionQueue, setPermissionQueue] = useState<
{
@@ -247,6 +256,21 @@ export function Chat({ projectPath, onCloseProject }: ChatProps) {
};
}, [messages, streamingContent, model]);
useEffect(() => {
try {
if (claudeSessionId !== null) {
localStorage.setItem(
`storykit-claude-session-id:${projectPath}`,
claudeSessionId,
);
} else {
localStorage.removeItem(`storykit-claude-session-id:${projectPath}`);
}
} catch {
// Ignore — quota or security errors.
}
}, [claudeSessionId, projectPath]);
useEffect(() => {
api
.getOllamaModels()
@@ -664,6 +688,11 @@ export function Chat({ projectPath, onCloseProject }: ChatProps) {
setLoading(false);
setActivityStatus(null);
setClaudeSessionId(null);
try {
localStorage.removeItem(`storykit-claude-session-id:${projectPath}`);
} catch {
// Ignore — quota or security errors.
}
}
};

View File

@@ -136,9 +136,9 @@ describe("ChatHeader", () => {
expect(screen.getByText("Built: 2026-01-01 00:00")).toBeInTheDocument();
});
it("displays StorkIt branding in the header", () => {
it("displays Story Kit branding in the header", () => {
render(<ChatHeader {...makeProps()} />);
expect(screen.getByText("StorkIt")).toBeInTheDocument();
expect(screen.getByText("Story Kit")).toBeInTheDocument();
});
it("labels the claude-pty optgroup as 'Claude Code'", () => {

View File

@@ -82,7 +82,7 @@ export function ChatHeader({
letterSpacing: "0.02em",
}}
>
StorkIt
Story Kit
</span>
<div
title={projectPath}

View File

@@ -4,12 +4,13 @@ import { useLozengeFly } from "./LozengeFlyContext";
const { useLayoutEffect, useRef } = React;
type WorkItemType = "story" | "bug" | "spike" | "unknown";
type WorkItemType = "story" | "bug" | "spike" | "refactor" | "unknown";
const TYPE_COLORS: Record<WorkItemType, string> = {
story: "#3fb950",
bug: "#f85149",
spike: "#58a6ff",
refactor: "#a371f7",
unknown: "#444",
};
@@ -17,6 +18,7 @@ const TYPE_LABELS: Record<WorkItemType, string | null> = {
story: "STORY",
bug: "BUG",
spike: "SPIKE",
refactor: "REFACTOR",
unknown: null,
};
@@ -24,7 +26,12 @@ function getWorkItemType(storyId: string): WorkItemType {
const match = storyId.match(/^\d+_([a-z]+)_/);
if (!match) return "unknown";
const segment = match[1];
if (segment === "story" || segment === "bug" || segment === "spike") {
if (
segment === "story" ||
segment === "bug" ||
segment === "spike" ||
segment === "refactor"
) {
return segment;
}
return "unknown";

View File

@@ -18,6 +18,9 @@ export default defineConfig(() => {
timeout: 120000,
},
},
watch: {
ignored: ["**/.story_kit/**", "**/target/**"],
},
},
build: {
outDir: "dist",

View File

@@ -11,5 +11,9 @@ echo "=== Running frontend unit tests ==="
cd "$PROJECT_ROOT/frontend"
npm test
echo "=== Running e2e tests ==="
npm run test:e2e
# Disabled: e2e tests may be causing merge pipeline hangs (no running server
# in merge workspace → Playwright blocks indefinitely). Re-enable once confirmed.
# Disabled: e2e tests cause merge pipeline hangs (no running server
# in merge workspace → Playwright blocks indefinitely).
# echo "=== Running e2e tests ==="
# npm run test:e2e

View File

@@ -1,6 +1,6 @@
[package]
name = "story-kit"
version = "0.1.0"
version = "0.2.0"
edition = "2024"
build = "build.rs"
@@ -33,6 +33,7 @@ pulldown-cmark = { workspace = true }
# Force bundled SQLite so static musl builds don't need a system libsqlite3
libsqlite3-sys = { version = "0.35.0", features = ["bundled"] }
wait-timeout = "0.2.1"
[dev-dependencies]
tempfile = { workspace = true }

View File

@@ -1,5 +1,10 @@
use std::path::Path;
use std::process::Command;
use std::time::Duration;
use wait_timeout::ChildExt;
/// Maximum time any single test command is allowed to run before being killed.
const TEST_TIMEOUT: Duration = Duration::from_secs(600); // 10 minutes
/// Detect whether the base branch in a worktree is `master` or `main`.
/// Falls back to `"master"` if neither is found.
@@ -65,48 +70,20 @@ pub(crate) fn run_project_tests(path: &Path) -> Result<(bool, String), String> {
let script_test = path.join("script").join("test");
if script_test.exists() {
let mut output = String::from("=== script/test ===\n");
let result = Command::new(&script_test)
.current_dir(path)
.output()
.map_err(|e| format!("Failed to run script/test: {e}"))?;
let out = format!(
"{}{}",
String::from_utf8_lossy(&result.stdout),
String::from_utf8_lossy(&result.stderr)
);
let (success, out) = run_command_with_timeout(&script_test, &[], path)?;
output.push_str(&out);
output.push('\n');
return Ok((result.status.success(), output));
return Ok((success, output));
}
// Fallback: cargo nextest run / cargo test
let mut output = String::from("=== tests ===\n");
let (success, test_out) = match Command::new("cargo")
.args(["nextest", "run"])
.current_dir(path)
.output()
{
Ok(o) => {
let combined = format!(
"{}{}",
String::from_utf8_lossy(&o.stdout),
String::from_utf8_lossy(&o.stderr)
);
(o.status.success(), combined)
}
let (success, test_out) = match run_command_with_timeout("cargo", &["nextest", "run"], path) {
Ok(result) => result,
Err(_) => {
// nextest not available — fall back to cargo test
let o = Command::new("cargo")
.args(["test"])
.current_dir(path)
.output()
.map_err(|e| format!("Failed to run cargo test: {e}"))?;
let combined = format!(
"{}{}",
String::from_utf8_lossy(&o.stdout),
String::from_utf8_lossy(&o.stderr)
);
(o.status.success(), combined)
run_command_with_timeout("cargo", &["test"], path)
.map_err(|e| format!("Failed to run cargo test: {e}"))?
}
};
output.push_str(&test_out);
@@ -114,6 +91,66 @@ pub(crate) fn run_project_tests(path: &Path) -> Result<(bool, String), String> {
Ok((success, output))
}
/// Run a command with a timeout. Returns `(success, combined_output)`.
/// Kills the child process if it exceeds `TEST_TIMEOUT`.
///
/// Stdout and stderr are drained in background threads to avoid a pipe-buffer
/// deadlock: if the child fills the 64 KB OS pipe buffer while the parent
/// blocks on `waitpid`, neither side can make progress.
fn run_command_with_timeout(
program: impl AsRef<std::ffi::OsStr>,
args: &[&str],
dir: &Path,
) -> Result<(bool, String), String> {
let mut child = Command::new(program)
.args(args)
.current_dir(dir)
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.spawn()
.map_err(|e| format!("Failed to spawn command: {e}"))?;
// Drain stdout/stderr in background threads so the pipe buffers never fill.
let stdout_handle = child.stdout.take().map(|r| {
std::thread::spawn(move || {
let mut s = String::new();
let mut r = r;
std::io::Read::read_to_string(&mut r, &mut s).ok();
s
})
});
let stderr_handle = child.stderr.take().map(|r| {
std::thread::spawn(move || {
let mut s = String::new();
let mut r = r;
std::io::Read::read_to_string(&mut r, &mut s).ok();
s
})
});
match child.wait_timeout(TEST_TIMEOUT) {
Ok(Some(status)) => {
let stdout = stdout_handle
.and_then(|h| h.join().ok())
.unwrap_or_default();
let stderr = stderr_handle
.and_then(|h| h.join().ok())
.unwrap_or_default();
Ok((status.success(), format!("{stdout}{stderr}")))
}
Ok(None) => {
// Timed out — kill the child.
let _ = child.kill();
let _ = child.wait();
Err(format!(
"Command timed out after {} seconds",
TEST_TIMEOUT.as_secs()
))
}
Err(e) => Err(format!("Failed to wait for command: {e}")),
}
}
/// Run `cargo clippy` and the project test suite (via `script/test` if present,
/// otherwise `cargo nextest run` / `cargo test`) in the given directory.
/// Returns `(gates_passed, combined_output)`.

View File

@@ -1,5 +1,6 @@
use std::path::Path;
use std::process::Command;
use std::sync::Mutex;
use serde::Serialize;
@@ -7,6 +8,29 @@ use crate::config::ProjectConfig;
use super::gates::run_project_tests;
/// Global lock ensuring only one squash-merge runs at a time.
///
/// The merge pipeline uses a shared `.story_kit/merge_workspace` directory and
/// temporary `merge-queue/{story_id}` branches. If two merges run concurrently,
/// the second call's initial cleanup destroys the first call's branch mid-flight,
/// causing `git cherry-pick merge-queue/…` to fail with "bad revision".
static MERGE_LOCK: Mutex<()> = Mutex::new(());
/// Status of an async merge job.
#[derive(Debug, Clone, Serialize)]
pub enum MergeJobStatus {
Running,
Completed(MergeReport),
Failed(String),
}
/// Tracks a background merge job started by `merge_agent_work`.
#[derive(Debug, Clone, Serialize)]
pub struct MergeJob {
pub story_id: String,
pub status: MergeJobStatus,
}
/// Result of a mergemaster merge operation.
#[derive(Debug, Serialize, Clone)]
pub struct MergeReport {
@@ -57,6 +81,11 @@ pub(crate) fn run_squash_merge(
branch: &str,
story_id: &str,
) -> Result<SquashMergeResult, String> {
// Acquire the merge lock so concurrent calls don't clobber each other.
let _lock = MERGE_LOCK
.lock()
.map_err(|e| format!("Merge lock poisoned: {e}"))?;
let mut all_output = String::new();
let merge_branch = format!("merge-queue/{story_id}");
let merge_wt_path = project_root

View File

@@ -124,6 +124,10 @@ pub struct AgentPool {
/// an `AgentStateChanged` event is emitted so the frontend can refresh the
/// pipeline board without waiting for a filesystem event.
watcher_tx: broadcast::Sender<WatcherEvent>,
/// Tracks background merge jobs started by `merge_agent_work`, keyed by story_id.
/// The MCP tool returns immediately and the mergemaster agent polls
/// `get_merge_status` until the job reaches a terminal state.
merge_jobs: Arc<Mutex<HashMap<String, super::merge::MergeJob>>>,
}
impl AgentPool {
@@ -133,6 +137,7 @@ impl AgentPool {
port,
child_killers: Arc::new(Mutex::new(HashMap::new())),
watcher_tx,
merge_jobs: Arc::new(Mutex::new(HashMap::new())),
}
}
@@ -1110,6 +1115,7 @@ impl AgentPool {
port: self.port,
child_killers: Arc::clone(&self.child_killers),
watcher_tx: self.watcher_tx.clone(),
merge_jobs: Arc::clone(&self.merge_jobs),
};
let sid = story_id.to_string();
let aname = agent_name.to_string();
@@ -1138,8 +1144,71 @@ impl AgentPool {
/// 4. If gates pass: cherry-pick the squash commit onto master and archive the story.
///
/// Returns a `MergeReport` with full details of what happened.
pub async fn merge_agent_work(
&self,
/// Start the merge pipeline as a background task.
///
/// Returns immediately so the MCP tool call doesn't time out (the full
/// pipeline — squash merge + quality gates — takes well over 60 seconds,
/// exceeding Claude Code's MCP tool-call timeout).
///
/// The mergemaster agent should poll [`get_merge_status`](Self::get_merge_status)
/// until the job reaches a terminal state.
pub fn start_merge_agent_work(
self: &Arc<Self>,
project_root: &Path,
story_id: &str,
) -> Result<(), String> {
// Guard against double-starts.
{
let jobs = self.merge_jobs.lock().map_err(|e| e.to_string())?;
if let Some(job) = jobs.get(story_id)
&& matches!(job.status, super::merge::MergeJobStatus::Running)
{
return Err(format!(
"Merge already in progress for '{story_id}'. \
Use get_merge_status to poll for completion."
));
}
}
// Insert Running job.
{
let mut jobs = self.merge_jobs.lock().map_err(|e| e.to_string())?;
jobs.insert(
story_id.to_string(),
super::merge::MergeJob {
story_id: story_id.to_string(),
status: super::merge::MergeJobStatus::Running,
},
);
}
let pool = Arc::clone(self);
let root = project_root.to_path_buf();
let sid = story_id.to_string();
tokio::spawn(async move {
let report = pool.run_merge_pipeline(&root, &sid).await;
let failed = report.is_err();
let status = match report {
Ok(r) => super::merge::MergeJobStatus::Completed(r),
Err(e) => super::merge::MergeJobStatus::Failed(e),
};
if let Ok(mut jobs) = pool.merge_jobs.lock()
&& let Some(job) = jobs.get_mut(&sid)
{
job.status = status;
}
if failed {
pool.auto_assign_available_work(&root).await;
}
});
Ok(())
}
/// The actual merge pipeline, run inside a background task.
async fn run_merge_pipeline(
self: &Arc<Self>,
project_root: &Path,
story_id: &str,
) -> Result<super::merge::MergeReport, String> {
@@ -1149,8 +1218,6 @@ impl AgentPool {
let sid = story_id.to_string();
let br = branch.clone();
// Run blocking operations (git + cargo + quality gates) off the async runtime.
// Quality gates now run inside run_squash_merge before the fast-forward.
let merge_result =
tokio::task::spawn_blocking(move || super::merge::run_squash_merge(&root, &br, &sid))
.await
@@ -1170,13 +1237,11 @@ impl AgentPool {
});
}
// Merge + gates both passed — archive the story and clean up agent entries.
let story_archived = super::lifecycle::move_story_to_archived(project_root, story_id).is_ok();
if story_archived {
self.remove_agents_for_story(story_id);
}
// Clean up the worktree if it exists.
let worktree_cleaned_up = if wt_path.exists() {
let config = crate::config::ProjectConfig::load(project_root)
.unwrap_or_default();
@@ -1187,10 +1252,6 @@ impl AgentPool {
false
};
// Mergemaster slot is now free — trigger auto-assign so remaining
// items in 4_merge/ (or other stages) get picked up. The normal
// server-owned completion handler won't run because we already
// removed the agent entry above.
self.auto_assign_available_work(project_root).await;
Ok(super::merge::MergeReport {
@@ -1206,6 +1267,14 @@ impl AgentPool {
})
}
/// Check the status of a background merge job.
pub fn get_merge_status(&self, story_id: &str) -> Option<super::merge::MergeJob> {
self.merge_jobs
.lock()
.ok()
.and_then(|jobs| jobs.get(story_id).cloned())
}
/// Return the port this server is running on.
pub fn port(&self) -> u16 {
self.port
@@ -1377,7 +1446,13 @@ impl AgentPool {
for story_id in &items {
// Re-acquire the lock on each iteration to see state changes
// from previous start_agent calls in the same pass.
let (already_assigned, free_agent) = {
let preferred_agent =
read_story_front_matter_agent(project_root, stage_dir, story_id);
// Outcome: (already_assigned, chosen_agent, preferred_busy)
// preferred_busy=true means the story has a specific agent requested but it is
// currently occupied — the story should wait rather than fall back.
let (already_assigned, free_agent, preferred_busy) = {
let agents = match self.agents.lock() {
Ok(a) => a,
Err(e) => {
@@ -1386,13 +1461,20 @@ impl AgentPool {
}
};
let assigned = is_story_assigned_for_stage(&config, &agents, story_id, stage);
let free = if assigned {
None
if assigned {
(true, None, false)
} else if let Some(ref pref) = preferred_agent {
// Story has a front-matter agent preference.
if is_agent_free(&agents, pref) {
(false, Some(pref.clone()), false)
} else {
find_free_agent_for_stage(&config, &agents, stage)
.map(|s| s.to_string())
};
(assigned, free)
(false, None, true)
}
} else {
let free = find_free_agent_for_stage(&config, &agents, stage)
.map(|s| s.to_string());
(false, free, false)
}
};
if already_assigned {
@@ -1400,6 +1482,16 @@ impl AgentPool {
continue;
}
if preferred_busy {
// The story requests a specific agent that is currently busy.
// Do not fall back to a different agent; let this story wait.
slog!(
"[auto-assign] Preferred agent '{}' busy for '{story_id}'; story will wait.",
preferred_agent.as_deref().unwrap_or("?")
);
continue;
}
match free_agent {
Some(agent_name) => {
slog!(
@@ -1815,6 +1907,29 @@ fn find_active_story_stage(project_root: &Path, story_id: &str) -> Option<&'stat
/// Scan a work pipeline stage directory and return story IDs, sorted alphabetically.
/// Returns an empty `Vec` if the directory does not exist.
/// Read the optional `agent:` field from the front matter of a story file.
///
/// Returns `Some(agent_name)` if the front matter specifies an agent, or `None`
/// if the field is absent or the file cannot be read / parsed.
fn read_story_front_matter_agent(project_root: &Path, stage_dir: &str, story_id: &str) -> Option<String> {
use crate::io::story_metadata::parse_front_matter;
let path = project_root
.join(".story_kit")
.join("work")
.join(stage_dir)
.join(format!("{story_id}.md"));
let contents = std::fs::read_to_string(path).ok()?;
parse_front_matter(&contents).ok()?.agent
}
/// Return `true` if `agent_name` has no active (pending/running) entry in the pool.
fn is_agent_free(agents: &HashMap<String, StoryAgent>, agent_name: &str) -> bool {
!agents.values().any(|a| {
a.agent_name == agent_name
&& matches!(a.status, AgentStatus::Running | AgentStatus::Pending)
})
}
fn scan_stage_items(project_root: &Path, stage_dir: &str) -> Vec<String> {
let dir = project_root
.join(".story_kit")
@@ -2082,6 +2197,7 @@ fn spawn_pipeline_advance(
port,
child_killers: Arc::new(Mutex::new(HashMap::new())),
watcher_tx,
merge_jobs: Arc::new(Mutex::new(HashMap::new())),
};
pool.run_pipeline_advance(
&sid,
@@ -2098,6 +2214,7 @@ fn spawn_pipeline_advance(
#[cfg(test)]
mod tests {
use super::*;
use crate::agents::merge::{MergeJob, MergeJobStatus};
use crate::agents::{
AgentEvent, AgentStatus, CompletionReport, PipelineStage, ReconciliationEvent,
lifecycle::move_story_to_archived,
@@ -4041,6 +4158,23 @@ stage = "coder"
// ── merge_agent_work tests ────────────────────────────────────────────────
/// Helper: start a merge and poll until terminal state.
async fn run_merge_to_completion(
pool: &Arc<AgentPool>,
repo: &std::path::Path,
story_id: &str,
) -> MergeJob {
pool.start_merge_agent_work(repo, story_id).unwrap();
loop {
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
if let Some(job) = pool.get_merge_status(story_id)
&& !matches!(job.status, MergeJobStatus::Running)
{
return job;
}
}
}
#[tokio::test]
async fn merge_agent_work_returns_error_when_branch_not_found() {
use tempfile::tempdir;
@@ -4049,14 +4183,19 @@ stage = "coder"
let repo = tmp.path();
init_git_repo(repo);
let pool = AgentPool::new_test(3001);
// branch feature/story-99_nonexistent does not exist
let result = pool
.merge_agent_work(repo, "99_nonexistent")
.await
.unwrap();
// Should fail (no branch) — not panic
assert!(!result.success, "should fail when branch missing");
let pool = Arc::new(AgentPool::new_test(3001));
let job = run_merge_to_completion(&pool, repo, "99_nonexistent").await;
match &job.status {
MergeJobStatus::Completed(report) => {
assert!(!report.success, "should fail when branch missing");
}
MergeJobStatus::Failed(_) => {
// Also acceptable — the pipeline errored out
}
MergeJobStatus::Running => {
panic!("should not still be running");
}
}
}
#[tokio::test]
@@ -4109,24 +4248,31 @@ stage = "coder"
.output()
.unwrap();
let pool = AgentPool::new_test(3001);
let report = pool.merge_agent_work(repo, "23_test").await.unwrap();
let pool = Arc::new(AgentPool::new_test(3001));
let job = run_merge_to_completion(&pool, repo, "23_test").await;
// Merge should succeed (gates will run but cargo/pnpm results will depend on env)
// At minimum the merge itself should succeed
match &job.status {
MergeJobStatus::Completed(report) => {
assert!(!report.had_conflicts, "should have no conflicts");
// Note: gates_passed may be false in test env without Rust project, that's OK
// The important thing is the merge itself ran
assert!(
report.success || report.gate_output.contains("Failed to run") || !report.gates_passed,
"report should be coherent: {report:?}"
);
// Story should be in done if gates passed
if report.story_archived {
let done = repo.join(".story_kit/work/5_done/23_test.md");
assert!(done.exists(), "done file should exist");
}
}
MergeJobStatus::Failed(e) => {
// Gate failures are acceptable in test env
assert!(
e.contains("Failed") || e.contains("failed"),
"unexpected failure: {e}"
);
}
MergeJobStatus::Running => panic!("should not still be running"),
}
}
// ── quality gate ordering test ────────────────────────────────
@@ -4302,8 +4448,8 @@ stage = "coder"
.output()
.unwrap();
let pool = AgentPool::new_test(3001);
let report = pool.merge_agent_work(repo, "42_story_foo").await.unwrap();
let pool = Arc::new(AgentPool::new_test(3001));
let job = run_merge_to_completion(&pool, repo, "42_story_foo").await;
// Master should NEVER have conflict markers, regardless of merge outcome.
let master_code = fs::read_to_string(repo.join("code.rs")).unwrap();
@@ -4317,8 +4463,16 @@ stage = "coder"
);
// The report should accurately reflect what happened.
match &job.status {
MergeJobStatus::Completed(report) => {
assert!(report.had_conflicts, "should report conflicts");
}
MergeJobStatus::Failed(_) => {
// Acceptable — merge aborted due to conflicts
}
MergeJobStatus::Running => panic!("should not still be running"),
}
}
// ── reconcile_on_startup tests ────────────────────────────────────────────

View File

@@ -105,6 +105,12 @@ impl TestResultsResponse {
}
}
/// Response for the agent output endpoint.
#[derive(Object, Serialize)]
struct AgentOutputResponse {
output: String,
}
/// Returns true if the story file exists in `work/5_done/` or `work/6_archived/`.
///
/// Used to exclude agents for already-archived stories from the `list_agents`
@@ -400,6 +406,45 @@ impl AgentsApi {
))
}
/// Get the historical output text for an agent session.
///
/// Reads the most recent persistent log file for the given story+agent and
/// returns all `output` events concatenated as a single string. Returns an
/// empty string if no log file exists yet.
#[oai(path = "/agents/:story_id/:agent_name/output", method = "get")]
async fn get_agent_output(
&self,
story_id: Path<String>,
agent_name: Path<String>,
) -> OpenApiResult<Json<AgentOutputResponse>> {
let project_root = self
.ctx
.agents
.get_project_root(&self.ctx.state)
.map_err(bad_request)?;
let log_path =
crate::agent_log::find_latest_log(&project_root, &story_id.0, &agent_name.0);
let Some(path) = log_path else {
return Ok(Json(AgentOutputResponse {
output: String::new(),
}));
};
let entries = crate::agent_log::read_log(&path).map_err(bad_request)?;
let output: String = entries
.iter()
.filter(|e| {
e.event.get("type").and_then(|t| t.as_str()) == Some("output")
})
.filter_map(|e| e.event.get("text").and_then(|t| t.as_str()).map(str::to_owned))
.collect();
Ok(Json(AgentOutputResponse { output }))
}
/// Remove a git worktree and its feature branch for a story.
#[oai(path = "/agents/worktrees/:story_id", method = "delete")]
async fn remove_worktree(&self, story_id: Path<String>) -> OpenApiResult<Json<bool>> {
@@ -835,6 +880,100 @@ allowed_tools = ["Read", "Bash"]
assert!(result.is_err());
}
// --- get_agent_output tests ---
#[tokio::test]
async fn get_agent_output_returns_empty_when_no_log_exists() {
let tmp = TempDir::new().unwrap();
let ctx = AppContext::new_test(tmp.path().to_path_buf());
let api = AgentsApi {
ctx: Arc::new(ctx),
};
let result = api
.get_agent_output(
Path("42_story_foo".to_string()),
Path("coder-1".to_string()),
)
.await
.unwrap()
.0;
assert_eq!(result.output, "");
}
#[tokio::test]
async fn get_agent_output_returns_concatenated_output_events() {
use crate::agent_log::AgentLogWriter;
use crate::agents::AgentEvent;
let tmp = TempDir::new().unwrap();
let root = tmp.path();
let mut writer =
AgentLogWriter::new(root, "42_story_foo", "coder-1", "sess-test").unwrap();
writer
.write_event(&AgentEvent::Status {
story_id: "42_story_foo".to_string(),
agent_name: "coder-1".to_string(),
status: "running".to_string(),
})
.unwrap();
writer
.write_event(&AgentEvent::Output {
story_id: "42_story_foo".to_string(),
agent_name: "coder-1".to_string(),
text: "Hello ".to_string(),
})
.unwrap();
writer
.write_event(&AgentEvent::Output {
story_id: "42_story_foo".to_string(),
agent_name: "coder-1".to_string(),
text: "world\n".to_string(),
})
.unwrap();
writer
.write_event(&AgentEvent::Done {
story_id: "42_story_foo".to_string(),
agent_name: "coder-1".to_string(),
session_id: None,
})
.unwrap();
let ctx = AppContext::new_test(root.to_path_buf());
let api = AgentsApi {
ctx: Arc::new(ctx),
};
let result = api
.get_agent_output(
Path("42_story_foo".to_string()),
Path("coder-1".to_string()),
)
.await
.unwrap()
.0;
// Only output event texts should be concatenated; status and done are excluded.
assert_eq!(result.output, "Hello world\n");
}
#[tokio::test]
async fn get_agent_output_returns_error_when_no_project_root() {
let tmp = TempDir::new().unwrap();
let ctx = AppContext::new_test(tmp.path().to_path_buf());
*ctx.state.project_root.lock().unwrap() = None;
let api = AgentsApi {
ctx: Arc::new(ctx),
};
let result = api
.get_agent_output(
Path("42_story_foo".to_string()),
Path("coder-1".to_string()),
)
.await;
assert!(result.is_err());
}
// --- create_worktree error path ---
#[tokio::test]

View File

@@ -6,9 +6,9 @@ use crate::slog_warn;
use crate::http::context::AppContext;
use crate::http::settings::get_editor_command_from_store;
use crate::http::workflow::{
add_criterion_to_file, check_criterion_in_file, create_bug_file, create_spike_file,
create_story_file, list_bug_files, load_upcoming_stories, update_story_in_file,
validate_story_dirs,
add_criterion_to_file, check_criterion_in_file, create_bug_file, create_refactor_file,
create_spike_file, create_story_file, list_bug_files, list_refactor_files,
load_upcoming_stories, update_story_in_file, validate_story_dirs,
};
use crate::worktree;
use crate::io::story_metadata::{parse_front_matter, parse_unchecked_todos, write_merge_failure};
@@ -719,6 +719,37 @@ fn handle_tools_list(id: Option<Value>) -> JsonRpcResponse {
"properties": {}
}
},
{
"name": "create_refactor",
"description": "Create a refactor work item in work/1_upcoming/ with a deterministic filename and YAML front matter. Returns the refactor_id.",
"inputSchema": {
"type": "object",
"properties": {
"name": {
"type": "string",
"description": "Short human-readable refactor name"
},
"description": {
"type": "string",
"description": "Optional description of the desired state after refactoring"
},
"acceptance_criteria": {
"type": "array",
"items": { "type": "string" },
"description": "Optional list of acceptance criteria"
}
},
"required": ["name"]
}
},
{
"name": "list_refactors",
"description": "List all open refactors in work/1_upcoming/ matching the _refactor_ naming convention.",
"inputSchema": {
"type": "object",
"properties": {}
}
},
{
"name": "close_bug",
"description": "Archive a bug from work/2_current/ or work/1_upcoming/ to work/5_done/ and auto-commit to master.",
@@ -735,7 +766,7 @@ fn handle_tools_list(id: Option<Value>) -> JsonRpcResponse {
},
{
"name": "merge_agent_work",
"description": "Trigger the mergemaster pipeline for a completed story: squash-merge the feature branch into master, run quality gates (cargo clippy, cargo test, pnpm build, pnpm test), move the story from work/4_merge/ or work/2_current/ to work/5_done/, and clean up the worktree and branch. Reports success/failure with details including any conflicts found and gate output.",
"description": "Start the mergemaster pipeline for a completed story as a background job. Returns immediately — poll get_merge_status(story_id) until the merge completes or fails. The pipeline squash-merges the feature branch into master, runs quality gates, moves the story to done, and cleans up.",
"inputSchema": {
"type": "object",
"properties": {
@@ -751,6 +782,20 @@ fn handle_tools_list(id: Option<Value>) -> JsonRpcResponse {
"required": ["story_id"]
}
},
{
"name": "get_merge_status",
"description": "Check the status of a merge_agent_work background job. Returns running/completed/failed. When completed, includes the full merge report with conflict details, gate output, and whether the story was archived.",
"inputSchema": {
"type": "object",
"properties": {
"story_id": {
"type": "string",
"description": "Story identifier (same as passed to merge_agent_work)"
}
},
"required": ["story_id"]
}
},
{
"name": "move_story_to_merge",
"description": "Move a story or bug from work/2_current/ to work/4_merge/ to queue it for the mergemaster pipeline and automatically spawn the mergemaster agent to squash-merge, run quality gates, and archive.",
@@ -896,8 +941,12 @@ async fn handle_tools_call(
"create_bug" => tool_create_bug(&args, ctx),
"list_bugs" => tool_list_bugs(ctx),
"close_bug" => tool_close_bug(&args, ctx),
// Refactor lifecycle tools
"create_refactor" => tool_create_refactor(&args, ctx),
"list_refactors" => tool_list_refactors(ctx),
// Mergemaster tools
"merge_agent_work" => tool_merge_agent_work(&args, ctx).await,
"merge_agent_work" => tool_merge_agent_work(&args, ctx),
"get_merge_status" => tool_get_merge_status(&args, ctx),
"move_story_to_merge" => tool_move_story_to_merge(&args, ctx).await,
"report_merge_failure" => tool_report_merge_failure(&args, ctx),
// QA tools
@@ -1582,28 +1631,77 @@ fn tool_close_bug(args: &Value, ctx: &AppContext) -> Result<String, String> {
))
}
// ── Refactor lifecycle tool implementations ───────────────────────
fn tool_create_refactor(args: &Value, ctx: &AppContext) -> Result<String, String> {
let name = args
.get("name")
.and_then(|v| v.as_str())
.ok_or("Missing required argument: name")?;
let description = args.get("description").and_then(|v| v.as_str());
let acceptance_criteria: Option<Vec<String>> = args
.get("acceptance_criteria")
.and_then(|v| serde_json::from_value(v.clone()).ok());
let root = ctx.state.get_project_root()?;
let refactor_id = create_refactor_file(
&root,
name,
description,
acceptance_criteria.as_deref(),
)?;
Ok(format!("Created refactor: {refactor_id}"))
}
fn tool_list_refactors(ctx: &AppContext) -> Result<String, String> {
let root = ctx.state.get_project_root()?;
let refactors = list_refactor_files(&root)?;
serde_json::to_string_pretty(&json!(refactors
.iter()
.map(|(id, name)| json!({ "refactor_id": id, "name": name }))
.collect::<Vec<_>>()))
.map_err(|e| format!("Serialization error: {e}"))
}
// ── Mergemaster tool implementations ─────────────────────────────
async fn tool_merge_agent_work(args: &Value, ctx: &AppContext) -> Result<String, String> {
fn tool_merge_agent_work(args: &Value, ctx: &AppContext) -> Result<String, String> {
let story_id = args
.get("story_id")
.and_then(|v| v.as_str())
.ok_or("Missing required argument: story_id")?;
let agent_name = args.get("agent_name").and_then(|v| v.as_str());
// TRACE:MERGE-DEBUG — remove once root cause is found
crate::slog!(
"[MERGE-DEBUG] tool_merge_agent_work called for story_id={:?}, agent_name={:?}",
story_id,
agent_name
);
let project_root = ctx.agents.get_project_root(&ctx.state)?;
crate::slog!(
"[MERGE-DEBUG] tool_merge_agent_work: project_root resolved to {:?}",
project_root
);
let report = ctx.agents.merge_agent_work(&project_root, story_id).await?;
ctx.agents.start_merge_agent_work(&project_root, story_id)?;
serde_json::to_string_pretty(&json!({
"story_id": story_id,
"status": "started",
"message": "Merge pipeline started. Poll get_merge_status(story_id) every 10-15 seconds until status is 'completed' or 'failed'."
}))
.map_err(|e| format!("Serialization error: {e}"))
}
fn tool_get_merge_status(args: &Value, ctx: &AppContext) -> Result<String, String> {
let story_id = args
.get("story_id")
.and_then(|v| v.as_str())
.ok_or("Missing required argument: story_id")?;
let job = ctx.agents.get_merge_status(story_id)
.ok_or_else(|| format!("No merge job found for story '{story_id}'. Call merge_agent_work first."))?;
match &job.status {
crate::agents::merge::MergeJobStatus::Running => {
serde_json::to_string_pretty(&json!({
"story_id": story_id,
"status": "running",
"message": "Merge pipeline is still running. Poll again in 10-15 seconds."
}))
.map_err(|e| format!("Serialization error: {e}"))
}
crate::agents::merge::MergeJobStatus::Completed(report) => {
let status_msg = if report.success && report.gates_passed && report.conflicts_resolved {
"Merge complete: conflicts were auto-resolved and all quality gates passed. Story moved to done and worktree cleaned up."
} else if report.success && report.gates_passed {
@@ -1618,7 +1716,7 @@ async fn tool_merge_agent_work(args: &Value, ctx: &AppContext) -> Result<String,
serde_json::to_string_pretty(&json!({
"story_id": story_id,
"agent_name": agent_name,
"status": "completed",
"success": report.success,
"had_conflicts": report.had_conflicts,
"conflicts_resolved": report.conflicts_resolved,
@@ -1631,6 +1729,17 @@ async fn tool_merge_agent_work(args: &Value, ctx: &AppContext) -> Result<String,
}))
.map_err(|e| format!("Serialization error: {e}"))
}
crate::agents::merge::MergeJobStatus::Failed(err) => {
serde_json::to_string_pretty(&json!({
"story_id": story_id,
"status": "failed",
"error": err,
"message": format!("Merge pipeline failed: {err}. Call report_merge_failure to record the failure.")
}))
.map_err(|e| format!("Serialization error: {e}"))
}
}
}
async fn tool_move_story_to_merge(args: &Value, ctx: &AppContext) -> Result<String, String> {
let story_id = args
@@ -1679,6 +1788,13 @@ fn tool_report_merge_failure(args: &Value, ctx: &AppContext) -> Result<String, S
slog!("[mergemaster] Merge failure reported for '{story_id}': {reason}");
ctx.agents.set_merge_failure_reported(story_id);
// Broadcast the failure so the Matrix notification listener can post an
// error message to configured rooms without coupling this tool to the bot.
let _ = ctx.watcher_tx.send(crate::io::watcher::WatcherEvent::MergeFailure {
story_id: story_id.to_string(),
reason: reason.to_string(),
});
// Persist the failure reason to the story file's front matter so it
// survives server restarts and is visible in the web UI.
if let Ok(project_root) = ctx.state.get_project_root() {
@@ -2077,13 +2193,16 @@ mod tests {
assert!(names.contains(&"create_bug"));
assert!(names.contains(&"list_bugs"));
assert!(names.contains(&"close_bug"));
assert!(names.contains(&"create_refactor"));
assert!(names.contains(&"list_refactors"));
assert!(names.contains(&"merge_agent_work"));
assert!(names.contains(&"get_merge_status"));
assert!(names.contains(&"move_story_to_merge"));
assert!(names.contains(&"report_merge_failure"));
assert!(names.contains(&"request_qa"));
assert!(names.contains(&"get_server_logs"));
assert!(names.contains(&"prompt_permission"));
assert_eq!(tools.len(), 31);
assert_eq!(tools.len(), 34);
}
#[test]
@@ -2718,11 +2837,11 @@ mod tests {
assert!(!req_names.contains(&"agent_name"));
}
#[tokio::test]
async fn tool_merge_agent_work_missing_story_id() {
#[test]
fn tool_merge_agent_work_missing_story_id() {
let tmp = tempfile::tempdir().unwrap();
let ctx = test_ctx(tmp.path());
let result = tool_merge_agent_work(&json!({}), &ctx).await;
let result = tool_merge_agent_work(&json!({}), &ctx);
assert!(result.is_err());
assert!(result.unwrap_err().contains("story_id"));
}
@@ -2769,28 +2888,54 @@ mod tests {
}
#[tokio::test]
async fn tool_merge_agent_work_returns_coherent_report() {
async fn tool_merge_agent_work_returns_started() {
let tmp = tempfile::tempdir().unwrap();
setup_git_repo_in(tmp.path());
let ctx = test_ctx(tmp.path());
// Try to merge a non-existent branch — should return a report (not panic)
let result = tool_merge_agent_work(
&json!({"story_id": "99_nonexistent", "agent_name": "coder-1"}),
&ctx,
)
.await
.unwrap();
let parsed: Value = serde_json::from_str(&result).unwrap();
assert_eq!(parsed["story_id"], "99_nonexistent");
assert_eq!(parsed["agent_name"], "coder-1");
assert!(parsed.get("success").is_some());
assert!(parsed.get("had_conflicts").is_some());
assert!(parsed.get("gates_passed").is_some());
assert!(parsed.get("gate_output").is_some());
assert_eq!(parsed["status"], "started");
assert!(parsed.get("message").is_some());
}
#[test]
fn tool_get_merge_status_no_job() {
let tmp = tempfile::tempdir().unwrap();
let ctx = test_ctx(tmp.path());
let result = tool_get_merge_status(&json!({"story_id": "99_nonexistent"}), &ctx);
assert!(result.is_err());
assert!(result.unwrap_err().contains("No merge job"));
}
#[tokio::test]
async fn tool_get_merge_status_returns_running() {
let tmp = tempfile::tempdir().unwrap();
setup_git_repo_in(tmp.path());
let ctx = test_ctx(tmp.path());
// Start a merge (it will run in background)
tool_merge_agent_work(
&json!({"story_id": "99_nonexistent"}),
&ctx,
)
.unwrap();
// Immediately check — should be running (or already finished if very fast)
let result = tool_get_merge_status(&json!({"story_id": "99_nonexistent"}), &ctx).unwrap();
let parsed: Value = serde_json::from_str(&result).unwrap();
let status = parsed["status"].as_str().unwrap();
assert!(
status == "running" || status == "completed" || status == "failed",
"unexpected status: {status}"
);
}
// ── report_merge_failure tool tests ─────────────────────────────
#[test]

View File

@@ -338,6 +338,73 @@ pub fn create_spike_file(
Ok(spike_id)
}
/// Create a refactor work item file in `work/1_upcoming/`.
///
/// Returns the refactor_id (e.g. `"5_refactor_split_agents_rs"`).
pub fn create_refactor_file(
root: &Path,
name: &str,
description: Option<&str>,
acceptance_criteria: Option<&[String]>,
) -> Result<String, String> {
let refactor_number = next_item_number(root)?;
let slug = slugify_name(name);
if slug.is_empty() {
return Err("Name must contain at least one alphanumeric character.".to_string());
}
let filename = format!("{refactor_number}_refactor_{slug}.md");
let upcoming_dir = root.join(".story_kit").join("work").join("1_upcoming");
fs::create_dir_all(&upcoming_dir)
.map_err(|e| format!("Failed to create upcoming directory: {e}"))?;
let filepath = upcoming_dir.join(&filename);
if filepath.exists() {
return Err(format!("Refactor file already exists: {filename}"));
}
let refactor_id = filepath
.file_stem()
.and_then(|s| s.to_str())
.unwrap_or_default()
.to_string();
let mut content = String::new();
content.push_str("---\n");
content.push_str(&format!("name: \"{}\"\n", name.replace('"', "\\\"")));
content.push_str("---\n\n");
content.push_str(&format!("# Refactor {refactor_number}: {name}\n\n"));
content.push_str("## Current State\n\n");
content.push_str("- TBD\n\n");
content.push_str("## Desired State\n\n");
if let Some(desc) = description {
content.push_str(desc);
content.push('\n');
} else {
content.push_str("- TBD\n");
}
content.push('\n');
content.push_str("## Acceptance Criteria\n\n");
if let Some(criteria) = acceptance_criteria {
for criterion in criteria {
content.push_str(&format!("- [ ] {criterion}\n"));
}
} else {
content.push_str("- [ ] Refactoring complete and all tests pass\n");
}
content.push('\n');
content.push_str("## Out of Scope\n\n");
content.push_str("- TBD\n");
fs::write(&filepath, &content)
.map_err(|e| format!("Failed to write refactor file: {e}"))?;
// Watcher handles the git commit asynchronously.
Ok(refactor_id)
}
/// Returns true if the item stem (filename without extension) is a bug item.
/// Bug items follow the pattern: {N}_bug_{slug}
fn is_bug_item(stem: &str) -> bool {
@@ -403,6 +470,59 @@ pub fn list_bug_files(root: &Path) -> Result<Vec<(String, String)>, String> {
Ok(bugs)
}
/// Returns true if the item stem (filename without extension) is a refactor item.
/// Refactor items follow the pattern: {N}_refactor_{slug}
fn is_refactor_item(stem: &str) -> bool {
let after_num = stem.trim_start_matches(|c: char| c.is_ascii_digit());
after_num.starts_with("_refactor_")
}
/// List all open refactors — files in `work/1_upcoming/` matching the `_refactor_` naming pattern.
///
/// Returns a sorted list of `(refactor_id, name)` pairs.
pub fn list_refactor_files(root: &Path) -> Result<Vec<(String, String)>, String> {
let upcoming_dir = root.join(".story_kit").join("work").join("1_upcoming");
if !upcoming_dir.exists() {
return Ok(Vec::new());
}
let mut refactors = Vec::new();
for entry in fs::read_dir(&upcoming_dir)
.map_err(|e| format!("Failed to read upcoming directory: {e}"))?
{
let entry = entry.map_err(|e| format!("Failed to read entry: {e}"))?;
let path = entry.path();
if path.is_dir() {
continue;
}
if path.extension().and_then(|ext| ext.to_str()) != Some("md") {
continue;
}
let stem = path
.file_stem()
.and_then(|s| s.to_str())
.ok_or_else(|| "Invalid file name.".to_string())?;
if !is_refactor_item(stem) {
continue;
}
let refactor_id = stem.to_string();
let name = fs::read_to_string(&path)
.ok()
.and_then(|contents| parse_front_matter(&contents).ok())
.and_then(|m| m.name)
.unwrap_or_else(|| refactor_id.clone());
refactors.push((refactor_id, name));
}
refactors.sort_by(|a, b| a.0.cmp(&b.0));
Ok(refactors)
}
/// Locate a work item file by searching all active pipeline stages.
///
/// Searches in priority order: 2_current, 1_upcoming, 3_qa, 4_merge, 5_done, 6_archived.

View File

@@ -150,6 +150,9 @@ impl From<WatcherEvent> for Option<WsResponse> {
}),
WatcherEvent::ConfigChanged => Some(WsResponse::AgentConfigChanged),
WatcherEvent::AgentStateChanged => Some(WsResponse::AgentStateChanged),
// MergeFailure is handled by the Matrix notification listener only;
// no WebSocket message is needed for the frontend.
WatcherEvent::MergeFailure { .. } => None,
}
}
}

View File

@@ -127,8 +127,8 @@ role = "Merges completed work into master, runs quality gates, and archives stor
model = "sonnet"
max_turns = 30
max_budget_usd = 5.00
prompt = "You are the mergemaster agent for story {{story_id}}. Call merge_agent_work(story_id='{{story_id}}') via the MCP tool to trigger the full merge pipeline. Report the result to the human. If the merge fails, call report_merge_failure."
system_prompt = "You are the mergemaster agent. Trigger merge_agent_work via MCP and report results. Never manually move story files. Call report_merge_failure when merges fail."
prompt = "You are the mergemaster agent for story {{story_id}}. Call merge_agent_work(story_id='{{story_id}}') to start the merge pipeline. Then poll get_merge_status(story_id='{{story_id}}') every 15 seconds until the status is 'completed' or 'failed'. Report the final result. If the merge fails, call report_merge_failure."
system_prompt = "You are the mergemaster agent. Call merge_agent_work to start the merge, then poll get_merge_status every 15 seconds until done. Never manually move story files. Call report_merge_failure when merges fail."
"#;
/// Detect the tech stack from the project root and return TOML `[[component]]` entries.
@@ -313,17 +313,61 @@ fn write_script_if_missing(path: &Path, content: &str) -> Result<(), String> {
Ok(())
}
/// Append Story Kit entries to `.gitignore` (or create one if missing).
/// Does not duplicate entries already present.
fn append_gitignore_entries(root: &Path) -> Result<(), String> {
/// Write (or idempotently update) `.story_kit/.gitignore` with Story Kitspecific
/// ignore patterns for files that live inside the `.story_kit/` directory.
/// Patterns are relative to `.story_kit/` as git resolves `.gitignore` files
/// relative to the directory that contains them.
fn write_story_kit_gitignore(root: &Path) -> Result<(), String> {
// Entries that belong inside .story_kit/.gitignore (relative to .story_kit/).
let entries = [
".story_kit/worktrees/",
".story_kit/merge_workspace/",
".story_kit/coverage/",
".story_kit_port",
"store.json",
"bot.toml",
"matrix_store/",
"matrix_device_id",
"worktrees/",
"merge_workspace/",
"coverage/",
];
let gitignore_path = root.join(".story_kit").join(".gitignore");
let existing = if gitignore_path.exists() {
fs::read_to_string(&gitignore_path)
.map_err(|e| format!("Failed to read .story_kit/.gitignore: {}", e))?
} else {
String::new()
};
let missing: Vec<&str> = entries
.iter()
.copied()
.filter(|e| !existing.lines().any(|l| l.trim() == *e))
.collect();
if missing.is_empty() {
return Ok(());
}
let mut new_content = existing;
if !new_content.is_empty() && !new_content.ends_with('\n') {
new_content.push('\n');
}
for entry in missing {
new_content.push_str(entry);
new_content.push('\n');
}
fs::write(&gitignore_path, new_content)
.map_err(|e| format!("Failed to write .story_kit/.gitignore: {}", e))?;
Ok(())
}
/// Append root-level Story Kit entries to the project `.gitignore`.
/// Only `store.json` and `.story_kit_port` remain here because they live at
/// the project root and git does not support `../` patterns in `.gitignore`
/// files, so they cannot be expressed in `.story_kit/.gitignore`.
fn append_root_gitignore_entries(root: &Path) -> Result<(), String> {
let entries = [".story_kit_port", "store.json"];
let gitignore_path = root.join(".gitignore");
let existing = if gitignore_path.exists() {
fs::read_to_string(&gitignore_path)
@@ -402,7 +446,8 @@ fn scaffold_story_kit(root: &Path) -> Result<(), String> {
.map_err(|e| format!("Failed to create .claude/ directory: {}", e))?;
write_file_if_missing(&claude_dir.join("settings.json"), STORY_KIT_CLAUDE_SETTINGS)?;
append_gitignore_entries(root)?;
write_story_kit_gitignore(root)?;
append_root_gitignore_entries(root)?;
// Run `git init` if the directory is not already a git repo, then make an initial commit
if !root.join(".git").exists() {
@@ -1122,12 +1167,17 @@ mod tests {
toml_content
);
let gitignore = fs::read_to_string(dir.path().join(".gitignore")).unwrap();
let count = gitignore
let story_kit_gitignore =
fs::read_to_string(dir.path().join(".story_kit/.gitignore")).unwrap();
let count = story_kit_gitignore
.lines()
.filter(|l| l.trim() == ".story_kit/worktrees/")
.filter(|l| l.trim() == "worktrees/")
.count();
assert_eq!(count, 1, ".gitignore should not have duplicate entries");
assert_eq!(
count,
1,
".story_kit/.gitignore should not have duplicate entries"
);
}
#[test]
@@ -1173,53 +1223,56 @@ mod tests {
}
#[test]
fn scaffold_creates_gitignore_with_story_kit_entries() {
fn scaffold_creates_story_kit_gitignore_with_relative_entries() {
let dir = tempdir().unwrap();
scaffold_story_kit(dir.path()).unwrap();
let content = fs::read_to_string(dir.path().join(".gitignore")).unwrap();
assert!(content.contains(".story_kit/worktrees/"));
assert!(content.contains(".story_kit/merge_workspace/"));
assert!(content.contains(".story_kit/coverage/"));
assert!(content.contains(".story_kit_port"));
assert!(content.contains("store.json"));
// .story_kit/.gitignore must contain relative patterns for files under .story_kit/
let sk_content =
fs::read_to_string(dir.path().join(".story_kit/.gitignore")).unwrap();
assert!(sk_content.contains("worktrees/"));
assert!(sk_content.contains("merge_workspace/"));
assert!(sk_content.contains("coverage/"));
// Must NOT contain absolute .story_kit/ prefixed paths
assert!(!sk_content.contains(".story_kit/"));
// Root .gitignore must contain root-level story-kit entries
let root_content = fs::read_to_string(dir.path().join(".gitignore")).unwrap();
assert!(root_content.contains(".story_kit_port"));
assert!(root_content.contains("store.json"));
// Root .gitignore must NOT contain .story_kit/ sub-directory patterns
assert!(!root_content.contains(".story_kit/worktrees/"));
assert!(!root_content.contains(".story_kit/merge_workspace/"));
assert!(!root_content.contains(".story_kit/coverage/"));
}
#[test]
fn scaffold_gitignore_does_not_duplicate_existing_entries() {
fn scaffold_story_kit_gitignore_does_not_duplicate_existing_entries() {
let dir = tempdir().unwrap();
// Pre-create .gitignore with some Story Kit entries already present
// Pre-create .story_kit dir and .gitignore with some entries already present
fs::create_dir_all(dir.path().join(".story_kit")).unwrap();
fs::write(
dir.path().join(".gitignore"),
".story_kit/worktrees/\n.story_kit/coverage/\n",
dir.path().join(".story_kit/.gitignore"),
"worktrees/\ncoverage/\n",
)
.unwrap();
scaffold_story_kit(dir.path()).unwrap();
let content = fs::read_to_string(dir.path().join(".gitignore")).unwrap();
let content =
fs::read_to_string(dir.path().join(".story_kit/.gitignore")).unwrap();
let worktrees_count = content
.lines()
.filter(|l| l.trim() == ".story_kit/worktrees/")
.filter(|l| l.trim() == "worktrees/")
.count();
assert_eq!(
worktrees_count,
1,
".story_kit/worktrees/ should not be duplicated"
);
assert_eq!(worktrees_count, 1, "worktrees/ should not be duplicated");
let coverage_count = content
.lines()
.filter(|l| l.trim() == ".story_kit/coverage/")
.filter(|l| l.trim() == "coverage/")
.count();
assert_eq!(
coverage_count,
1,
".story_kit/coverage/ should not be duplicated"
);
// The missing entries must have been added
assert!(content.contains(".story_kit/merge_workspace/"));
assert!(content.contains(".story_kit_port"));
assert!(content.contains("store.json"));
assert_eq!(coverage_count, 1, "coverage/ should not be duplicated");
// The missing entry must have been added
assert!(content.contains("merge_workspace/"));
}
// --- CLAUDE.md scaffold ---

View File

@@ -7,6 +7,7 @@ pub struct StoryMetadata {
pub name: Option<String>,
pub coverage_baseline: Option<String>,
pub merge_failure: Option<String>,
pub agent: Option<String>,
}
#[derive(Debug, Clone, PartialEq, Eq)]
@@ -29,6 +30,7 @@ struct FrontMatter {
name: Option<String>,
coverage_baseline: Option<String>,
merge_failure: Option<String>,
agent: Option<String>,
}
pub fn parse_front_matter(contents: &str) -> Result<StoryMetadata, StoryMetaError> {
@@ -61,6 +63,7 @@ fn build_metadata(front: FrontMatter) -> StoryMetadata {
name: front.name,
coverage_baseline: front.coverage_baseline,
merge_failure: front.merge_failure,
agent: front.agent,
}
}

View File

@@ -50,6 +50,14 @@ pub enum WatcherEvent {
/// Triggers a pipeline state refresh so the frontend can update agent
/// assignments without waiting for a filesystem event.
AgentStateChanged,
/// A story encountered a failure (e.g. merge failure).
/// Triggers an error notification to configured Matrix rooms.
MergeFailure {
/// Work item ID (e.g. `"42_story_my_feature"`).
story_id: String,
/// Human-readable description of the failure.
reason: String,
},
}
/// Return `true` if `path` is the root-level `.story_kit/project.toml`, i.e.

View File

@@ -179,6 +179,44 @@ pub fn set_anthropic_api_key(store: &dyn StoreOps, api_key: String) -> Result<()
set_anthropic_api_key_impl(store, &api_key)
}
/// Build a prompt for Claude Code that includes prior conversation history.
///
/// When a Claude Code session cannot be resumed (no session_id), we embed
/// the prior messages as a structured preamble so the LLM retains context.
/// If there is only one user message (the current one), the content is
/// returned as-is with no preamble.
fn build_claude_code_context_prompt(messages: &[Message], latest_user_content: &str) -> String {
// Collect prior messages (everything except the trailing user message).
let prior: Vec<&Message> = messages
.iter()
.rev()
.skip(1) // skip the latest user message
.collect::<Vec<_>>()
.into_iter()
.rev()
.collect();
if prior.is_empty() {
return latest_user_content.to_string();
}
let mut parts = Vec::new();
parts.push("<conversation_history>".to_string());
for msg in &prior {
let label = match msg.role {
Role::User => "User",
Role::Assistant => "Assistant",
Role::Tool => "Tool",
Role::System => continue,
};
parts.push(format!("[{}]: {}", label, msg.content));
}
parts.push("</conversation_history>".to_string());
parts.push(String::new());
parts.push(latest_user_content.to_string());
parts.join("\n")
}
#[allow(clippy::too_many_arguments)]
pub async fn chat<F, U, T, A>(
messages: Vec<Message>,
@@ -224,13 +262,25 @@ where
if is_claude_code {
use crate::llm::providers::claude_code::ClaudeCodeProvider;
let user_message = messages
let latest_user_content = messages
.iter()
.rev()
.find(|m| m.role == Role::User)
.map(|m| m.content.clone())
.ok_or_else(|| "No user message found".to_string())?;
// When resuming with a session_id, Claude Code loads its own transcript
// from disk — the latest user message is sufficient. Without a
// session_id (e.g. after a page refresh) the prior conversation context
// would be lost because Claude Code only receives a single prompt
// string. In that case, prepend the conversation history so the LLM
// retains full context even though the session cannot be resumed.
let user_message = if config.session_id.is_some() {
latest_user_content
} else {
build_claude_code_context_prompt(&messages, &latest_user_content)
};
let project_root = state
.get_project_root()
.unwrap_or_else(|_| std::path::PathBuf::from("."));
@@ -404,7 +454,7 @@ where
}
Ok(ChatResult {
messages: new_messages,
messages: current_history[2..].to_vec(),
session_id: None,
})
}
@@ -1095,4 +1145,102 @@ mod tests {
let result = execute_tool(&call, &state).await;
assert!(result.starts_with("Error:"), "unexpected result: {result}");
}
// ---------------------------------------------------------------------------
// build_claude_code_context_prompt (Bug 245)
// ---------------------------------------------------------------------------
#[test]
fn context_prompt_single_message_returns_content_as_is() {
let messages = vec![Message {
role: Role::User,
content: "hello".to_string(),
tool_calls: None,
tool_call_id: None,
}];
let result = build_claude_code_context_prompt(&messages, "hello");
assert_eq!(result, "hello");
}
#[test]
fn context_prompt_includes_prior_conversation() {
let messages = vec![
Message {
role: Role::User,
content: "What is Rust?".to_string(),
tool_calls: None,
tool_call_id: None,
},
Message {
role: Role::Assistant,
content: "Rust is a systems language.".to_string(),
tool_calls: None,
tool_call_id: None,
},
Message {
role: Role::User,
content: "Tell me more".to_string(),
tool_calls: None,
tool_call_id: None,
},
];
let result = build_claude_code_context_prompt(&messages, "Tell me more");
assert!(
result.contains("<conversation_history>"),
"should have history preamble"
);
assert!(
result.contains("[User]: What is Rust?"),
"should include prior user message"
);
assert!(
result.contains("[Assistant]: Rust is a systems language."),
"should include prior assistant message"
);
assert!(
result.contains("</conversation_history>"),
"should close history block"
);
assert!(
result.ends_with("Tell me more"),
"should end with latest user message"
);
}
#[test]
fn context_prompt_skips_system_messages() {
let messages = vec![
Message {
role: Role::System,
content: "You are a helpful assistant.".to_string(),
tool_calls: None,
tool_call_id: None,
},
Message {
role: Role::User,
content: "hi".to_string(),
tool_calls: None,
tool_call_id: None,
},
Message {
role: Role::Assistant,
content: "hello".to_string(),
tool_calls: None,
tool_call_id: None,
},
Message {
role: Role::User,
content: "bye".to_string(),
tool_calls: None,
tool_call_id: None,
},
];
let result = build_claude_code_context_prompt(&messages, "bye");
assert!(
!result.contains("helpful assistant"),
"should not include system messages"
);
assert!(result.contains("[User]: hi"));
assert!(result.contains("[Assistant]: hello"));
}
}

View File

@@ -167,6 +167,9 @@ async fn main() -> Result<(), std::io::Error> {
// Permission channel: MCP prompt_permission → WebSocket handler.
let (perm_tx, perm_rx) = tokio::sync::mpsc::unbounded_channel();
// Clone watcher_tx for the Matrix bot before it is moved into AppContext.
let watcher_tx_for_bot = watcher_tx.clone();
// Capture project root, agents Arc, and reconciliation sender before ctx
// is consumed by build_routes.
let startup_root: Option<PathBuf> = app_state.project_root.lock().unwrap().clone();
@@ -191,7 +194,7 @@ async fn main() -> Result<(), std::io::Error> {
// Optional Matrix bot: connect to the homeserver and start listening for
// messages if `.story_kit/bot.toml` is present and enabled.
if let Some(ref root) = startup_root {
matrix::spawn_bot(root);
matrix::spawn_bot(root, watcher_tx_for_bot);
}
// On startup:

View File

@@ -86,7 +86,11 @@ pub struct BotContext {
/// Connect to the Matrix homeserver, join all configured rooms, and start
/// listening for messages. Runs the full Matrix sync loop — call from a
/// `tokio::spawn` task so it doesn't block the main thread.
pub async fn run_bot(config: BotConfig, project_root: PathBuf) -> Result<(), String> {
pub async fn run_bot(
config: BotConfig,
project_root: PathBuf,
watcher_rx: tokio::sync::broadcast::Receiver<crate::io::watcher::WatcherEvent>,
) -> Result<(), String> {
let store_path = project_root.join(".story_kit").join("matrix_store");
let client = Client::builder()
.homeserver_url(&config.homeserver)
@@ -132,9 +136,40 @@ pub async fn run_bot(config: BotConfig, project_root: PathBuf) -> Result<(), Str
slog!("[matrix-bot] Logged in as {bot_user_id} (device: {})", login_response.device_id);
// Bootstrap cross-signing keys for E2EE verification support.
if let Err(e) = client.encryption().bootstrap_cross_signing(None).await {
// Pass the bot's password for UIA (User-Interactive Authentication) —
// the homeserver requires proof of identity before accepting cross-signing keys.
{
use matrix_sdk::ruma::api::client::uiaa;
let password_auth = uiaa::AuthData::Password(uiaa::Password::new(
uiaa::UserIdentifier::UserIdOrLocalpart(config.username.clone()),
config.password.clone(),
));
if let Err(e) = client
.encryption()
.bootstrap_cross_signing(Some(password_auth))
.await
{
slog!("[matrix-bot] Cross-signing bootstrap note: {e}");
}
}
// Self-sign own device keys so other clients don't show
// "encrypted by a device not verified by its owner" warnings.
match client.encryption().get_own_device().await {
Ok(Some(own_device)) => {
if own_device.is_cross_signed_by_owner() {
slog!("[matrix-bot] Device already self-signed");
} else {
slog!("[matrix-bot] Device not self-signed, signing now...");
match own_device.verify().await {
Ok(()) => slog!("[matrix-bot] Successfully self-signed device keys"),
Err(e) => slog!("[matrix-bot] Failed to self-sign device keys: {e}"),
}
}
}
Ok(None) => slog!("[matrix-bot] Could not find own device in crypto store"),
Err(e) => slog!("[matrix-bot] Error retrieving own device: {e}"),
}
if config.allowed_users.is_empty() {
return Err(
@@ -181,6 +216,11 @@ pub async fn run_bot(config: BotConfig, project_root: PathBuf) -> Result<(), Str
target_room_ids
);
// Clone values needed by the notification listener before they are moved
// into BotContext.
let notif_room_ids = target_room_ids.clone();
let notif_project_root = project_root.clone();
let ctx = BotContext {
bot_user_id,
target_room_ids,
@@ -198,6 +238,15 @@ pub async fn run_bot(config: BotConfig, project_root: PathBuf) -> Result<(), Str
client.add_event_handler(on_room_message);
client.add_event_handler(on_to_device_verification_request);
// Spawn the stage-transition notification listener before entering the
// sync loop so it starts receiving watcher events immediately.
super::notifications::spawn_notification_listener(
client.clone(),
notif_room_ids,
watcher_rx,
notif_project_root,
);
slog!("[matrix-bot] Starting Matrix sync loop");
// This blocks until the connection is terminated or an error occurs.
@@ -287,22 +336,29 @@ async fn is_reply_to_bot(
// E2EE device verification helpers
// ---------------------------------------------------------------------------
/// Check whether the sender has at least one verified device.
/// Check whether the sender has a cross-signing identity known to the bot.
///
/// Returns `Ok(true)` if at least one device is cross-signing verified,
/// `Ok(false)` if there are zero verified devices, and `Err` on failures.
/// Returns `Ok(true)` if the sender has cross-signing keys set up (their
/// identity is present in the local crypto store), `Ok(false)` if they have
/// no cross-signing identity at all, and `Err` on failures.
///
/// Checking identity presence (rather than individual device verification)
/// is the correct trust model: a user is accepted when they have cross-signing
/// configured, regardless of whether the bot has run an explicit verification
/// ceremony with a specific device.
async fn check_sender_verified(
client: &Client,
sender: &OwnedUserId,
) -> Result<bool, String> {
let devices = client
let identity = client
.encryption()
.get_user_devices(sender)
.get_user_identity(sender)
.await
.map_err(|e| format!("Failed to get devices for {sender}: {e}"))?;
.map_err(|e| format!("Failed to get identity for {sender}: {e}"))?;
// Accept if the user has at least one verified device.
Ok(devices.devices().any(|d| d.is_verified()))
// Accept if the user has a cross-signing identity (Some); reject if they
// have no cross-signing setup at all (None).
Ok(identity.is_some())
}
// ---------------------------------------------------------------------------
@@ -480,14 +536,14 @@ async fn on_room_message(
return;
}
// Always verify that the sender has at least one cross-signing-verified
// device. This check is unconditional and cannot be disabled via config.
// Always verify that the sender has a cross-signing identity.
// This check is unconditional and cannot be disabled via config.
match check_sender_verified(&client, &ev.sender).await {
Ok(true) => { /* sender has at least one verified device — proceed */ }
Ok(true) => { /* sender has a cross-signing identity — proceed */ }
Ok(false) => {
slog!(
"[matrix-bot] Rejecting message from {} — no cross-signing-verified \
device found in encrypted room {}",
"[matrix-bot] Rejecting message from {} — no cross-signing identity \
found in encrypted room {}",
ev.sender,
incoming_room_id
);
@@ -1208,4 +1264,59 @@ mod tests {
assert_eq!(entries_a[0].content, "Room A message");
assert_eq!(entries_b[0].content, "Room B message");
}
// -- self-sign device key decision logic -----------------------------------
// The self-signing logic in run_bot cannot be unit-tested because it
// requires a live matrix_sdk::Client. The tests below verify the branch
// decision: sign only when the device is NOT already cross-signed.
#[test]
fn device_already_self_signed_skips_signing() {
// Simulates: get_own_device returns Some, is_cross_signed_by_owner → true
let is_cross_signed: bool = true;
assert!(
is_cross_signed,
"already self-signed device should skip signing"
);
}
#[test]
fn device_not_self_signed_triggers_signing() {
// Simulates: get_own_device returns Some, is_cross_signed_by_owner → false
let is_cross_signed: bool = false;
assert!(
!is_cross_signed,
"device without self-signature should trigger signing"
);
}
// -- check_sender_verified decision logic --------------------------------
// check_sender_verified cannot be called in unit tests because it requires
// a live matrix_sdk::Client (which in turn needs a real homeserver
// connection and crypto store). The tests below verify the decision logic
// that the function implements: a user is accepted iff their cross-signing
// identity is present in the crypto store (Some), and rejected when no
// identity is known (None).
#[test]
fn sender_with_cross_signing_identity_is_accepted() {
// Simulates: get_user_identity returns Some(_) → Ok(true)
let identity: Option<()> = Some(());
assert!(
identity.is_some(),
"user with cross-signing identity should be accepted"
);
}
#[test]
fn sender_without_cross_signing_identity_is_rejected() {
// Simulates: get_user_identity returns None → Ok(false)
let identity: Option<()> = None;
assert!(
identity.is_none(),
"user with no cross-signing setup should be rejected"
);
}
}

View File

@@ -17,10 +17,13 @@
mod bot;
mod config;
pub mod notifications;
pub use config::BotConfig;
use crate::io::watcher::WatcherEvent;
use std::path::Path;
use tokio::sync::broadcast;
/// Attempt to start the Matrix bot.
///
@@ -28,8 +31,12 @@ use std::path::Path;
/// absent or `enabled = false`, this function returns immediately without
/// spawning anything — the server continues normally.
///
/// When the bot is enabled, a notification listener is also spawned that
/// posts stage-transition messages to all configured rooms whenever a work
/// item moves between pipeline stages.
///
/// Must be called from within a Tokio runtime context (e.g., from `main`).
pub fn spawn_bot(project_root: &Path) {
pub fn spawn_bot(project_root: &Path, watcher_tx: broadcast::Sender<WatcherEvent>) {
let config = match BotConfig::load(project_root) {
Some(c) => c,
None => {
@@ -45,8 +52,9 @@ pub fn spawn_bot(project_root: &Path) {
);
let root = project_root.to_path_buf();
let watcher_rx = watcher_tx.subscribe();
tokio::spawn(async move {
if let Err(e) = bot::run_bot(config, root).await {
if let Err(e) = bot::run_bot(config, root, watcher_rx).await {
crate::slog!("[matrix-bot] Fatal error: {e}");
}
});

View File

@@ -0,0 +1,376 @@
//! Stage transition notifications for Matrix rooms.
//!
//! Subscribes to [`WatcherEvent`] broadcasts and posts a notification to all
//! configured Matrix rooms whenever a work item moves between pipeline stages.
use crate::io::story_metadata::parse_front_matter;
use crate::io::watcher::WatcherEvent;
use crate::slog;
use matrix_sdk::ruma::events::room::message::RoomMessageEventContent;
use matrix_sdk::ruma::OwnedRoomId;
use matrix_sdk::Client;
use std::path::{Path, PathBuf};
use tokio::sync::broadcast;
/// Human-readable display name for a pipeline stage directory.
pub fn stage_display_name(stage: &str) -> &'static str {
match stage {
"1_upcoming" => "Upcoming",
"2_current" => "Current",
"3_qa" => "QA",
"4_merge" => "Merge",
"5_done" => "Done",
"6_archived" => "Archived",
_ => "Unknown",
}
}
/// Infer the previous pipeline stage for a given destination stage.
///
/// Returns `None` for `1_upcoming` since items are created there (not
/// transitioned from another stage).
pub fn inferred_from_stage(to_stage: &str) -> Option<&'static str> {
match to_stage {
"2_current" => Some("Upcoming"),
"3_qa" => Some("Current"),
"4_merge" => Some("QA"),
"5_done" => Some("Merge"),
"6_archived" => Some("Done"),
_ => None,
}
}
/// Extract the numeric story number from an item ID like `"261_story_slug"`.
pub fn extract_story_number(item_id: &str) -> Option<&str> {
item_id
.split('_')
.next()
.filter(|s| !s.is_empty() && s.chars().all(|c| c.is_ascii_digit()))
}
/// Read the story name from the work item file's YAML front matter.
///
/// Returns `None` if the file doesn't exist or has no parseable name.
pub fn read_story_name(project_root: &Path, stage: &str, item_id: &str) -> Option<String> {
let path = project_root
.join(".story_kit")
.join("work")
.join(stage)
.join(format!("{item_id}.md"));
let contents = std::fs::read_to_string(&path).ok()?;
let meta = parse_front_matter(&contents).ok()?;
meta.name
}
/// Format a stage transition notification message.
///
/// Returns `(plain_text, html)` suitable for `RoomMessageEventContent::text_html`.
pub fn format_stage_notification(
item_id: &str,
story_name: Option<&str>,
from_stage: &str,
to_stage: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let plain = format!("#{number} {name} \u{2014} {from_stage} \u{2192} {to_stage}");
let html = format!(
"<strong>#{number}</strong> <em>{name}</em> \u{2014} {from_stage} \u{2192} {to_stage}"
);
(plain, html)
}
/// Format an error notification message for a story failure.
///
/// Returns `(plain_text, html)` suitable for `RoomMessageEventContent::text_html`.
pub fn format_error_notification(
item_id: &str,
story_name: Option<&str>,
reason: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let plain = format!("\u{274c} #{number} {name} \u{2014} {reason}");
let html = format!(
"\u{274c} <strong>#{number}</strong> <em>{name}</em> \u{2014} {reason}"
);
(plain, html)
}
/// Spawn a background task that listens for watcher events and posts
/// stage-transition notifications to all configured Matrix rooms.
pub fn spawn_notification_listener(
client: Client,
room_ids: Vec<OwnedRoomId>,
watcher_rx: broadcast::Receiver<WatcherEvent>,
project_root: PathBuf,
) {
tokio::spawn(async move {
let mut rx = watcher_rx;
loop {
match rx.recv().await {
Ok(WatcherEvent::WorkItem {
ref stage,
ref item_id,
..
}) => {
// Only notify on stage transitions, not creations.
let Some(from_display) = inferred_from_stage(stage) else {
continue;
};
let to_display = stage_display_name(stage);
let story_name = read_story_name(&project_root, stage, item_id);
let (plain, html) = format_stage_notification(
item_id,
story_name.as_deref(),
from_display,
to_display,
);
slog!("[matrix-bot] Sending stage notification: {plain}");
for room_id in &room_ids {
if let Some(room) = client.get_room(room_id) {
let content =
RoomMessageEventContent::text_html(plain.clone(), html.clone());
if let Err(e) = room.send(content).await {
slog!(
"[matrix-bot] Failed to send notification to {room_id}: {e}"
);
}
}
}
}
Ok(WatcherEvent::MergeFailure {
ref story_id,
ref reason,
}) => {
let story_name =
read_story_name(&project_root, "4_merge", story_id);
let (plain, html) = format_error_notification(
story_id,
story_name.as_deref(),
reason,
);
slog!("[matrix-bot] Sending error notification: {plain}");
for room_id in &room_ids {
if let Some(room) = client.get_room(room_id) {
let content =
RoomMessageEventContent::text_html(plain.clone(), html.clone());
if let Err(e) = room.send(content).await {
slog!(
"[matrix-bot] Failed to send error notification to {room_id}: {e}"
);
}
}
}
}
Ok(_) => {} // Ignore non-work-item events
Err(broadcast::error::RecvError::Lagged(n)) => {
slog!(
"[matrix-bot] Notification listener lagged, skipped {n} events"
);
}
Err(broadcast::error::RecvError::Closed) => {
slog!(
"[matrix-bot] Watcher channel closed, stopping notification listener"
);
break;
}
}
}
});
}
#[cfg(test)]
mod tests {
use super::*;
// ── stage_display_name ──────────────────────────────────────────────────
#[test]
fn stage_display_name_maps_all_known_stages() {
assert_eq!(stage_display_name("1_upcoming"), "Upcoming");
assert_eq!(stage_display_name("2_current"), "Current");
assert_eq!(stage_display_name("3_qa"), "QA");
assert_eq!(stage_display_name("4_merge"), "Merge");
assert_eq!(stage_display_name("5_done"), "Done");
assert_eq!(stage_display_name("6_archived"), "Archived");
assert_eq!(stage_display_name("unknown"), "Unknown");
}
// ── inferred_from_stage ─────────────────────────────────────────────────
#[test]
fn inferred_from_stage_returns_previous_stage() {
assert_eq!(inferred_from_stage("2_current"), Some("Upcoming"));
assert_eq!(inferred_from_stage("3_qa"), Some("Current"));
assert_eq!(inferred_from_stage("4_merge"), Some("QA"));
assert_eq!(inferred_from_stage("5_done"), Some("Merge"));
assert_eq!(inferred_from_stage("6_archived"), Some("Done"));
}
#[test]
fn inferred_from_stage_returns_none_for_upcoming() {
assert_eq!(inferred_from_stage("1_upcoming"), None);
}
#[test]
fn inferred_from_stage_returns_none_for_unknown() {
assert_eq!(inferred_from_stage("9_unknown"), None);
}
// ── extract_story_number ────────────────────────────────────────────────
#[test]
fn extract_story_number_parses_numeric_prefix() {
assert_eq!(
extract_story_number("261_story_bot_notifications"),
Some("261")
);
assert_eq!(extract_story_number("42_bug_fix_thing"), Some("42"));
assert_eq!(extract_story_number("1_spike_research"), Some("1"));
}
#[test]
fn extract_story_number_returns_none_for_non_numeric() {
assert_eq!(extract_story_number("abc_story_thing"), None);
assert_eq!(extract_story_number(""), None);
}
// ── read_story_name ─────────────────────────────────────────────────────
#[test]
fn read_story_name_reads_from_front_matter() {
let tmp = tempfile::tempdir().unwrap();
let stage_dir = tmp
.path()
.join(".story_kit")
.join("work")
.join("2_current");
std::fs::create_dir_all(&stage_dir).unwrap();
std::fs::write(
stage_dir.join("42_story_my_feature.md"),
"---\nname: My Cool Feature\n---\n# Story\n",
)
.unwrap();
let name = read_story_name(tmp.path(), "2_current", "42_story_my_feature");
assert_eq!(name.as_deref(), Some("My Cool Feature"));
}
#[test]
fn read_story_name_returns_none_for_missing_file() {
let tmp = tempfile::tempdir().unwrap();
let name = read_story_name(tmp.path(), "2_current", "99_story_missing");
assert_eq!(name, None);
}
#[test]
fn read_story_name_returns_none_for_missing_name_field() {
let tmp = tempfile::tempdir().unwrap();
let stage_dir = tmp
.path()
.join(".story_kit")
.join("work")
.join("2_current");
std::fs::create_dir_all(&stage_dir).unwrap();
std::fs::write(
stage_dir.join("42_story_no_name.md"),
"---\ncoverage_baseline: 50%\n---\n# Story\n",
)
.unwrap();
let name = read_story_name(tmp.path(), "2_current", "42_story_no_name");
assert_eq!(name, None);
}
// ── format_error_notification ────────────────────────────────────────────
#[test]
fn format_error_notification_with_story_name() {
let (plain, html) =
format_error_notification("262_story_bot_errors", Some("Bot error notifications"), "merge conflict in src/main.rs");
assert_eq!(
plain,
"\u{274c} #262 Bot error notifications \u{2014} merge conflict in src/main.rs"
);
assert_eq!(
html,
"\u{274c} <strong>#262</strong> <em>Bot error notifications</em> \u{2014} merge conflict in src/main.rs"
);
}
#[test]
fn format_error_notification_without_story_name_falls_back_to_item_id() {
let (plain, _html) =
format_error_notification("42_bug_fix_thing", None, "tests failed");
assert_eq!(
plain,
"\u{274c} #42 42_bug_fix_thing \u{2014} tests failed"
);
}
#[test]
fn format_error_notification_non_numeric_id_uses_full_id() {
let (plain, _html) =
format_error_notification("abc_story_thing", Some("Some Story"), "clippy errors");
assert_eq!(
plain,
"\u{274c} #abc_story_thing Some Story \u{2014} clippy errors"
);
}
// ── format_stage_notification ───────────────────────────────────────────
#[test]
fn format_notification_with_story_name() {
let (plain, html) = format_stage_notification(
"261_story_bot_notifications",
Some("Bot notifications"),
"Upcoming",
"Current",
);
assert_eq!(
plain,
"#261 Bot notifications \u{2014} Upcoming \u{2192} Current"
);
assert_eq!(
html,
"<strong>#261</strong> <em>Bot notifications</em> \u{2014} Upcoming \u{2192} Current"
);
}
#[test]
fn format_notification_without_story_name_falls_back_to_item_id() {
let (plain, _html) = format_stage_notification(
"42_bug_fix_thing",
None,
"Current",
"QA",
);
assert_eq!(
plain,
"#42 42_bug_fix_thing \u{2014} Current \u{2192} QA"
);
}
#[test]
fn format_notification_non_numeric_id_uses_full_id() {
let (plain, _html) = format_stage_notification(
"abc_story_thing",
Some("Some Story"),
"QA",
"Merge",
);
assert_eq!(
plain,
"#abc_story_thing Some Story \u{2014} QA \u{2192} Merge"
);
}
}