From d5a93fe726ee40ca7a35600731b234aef5fa09b1 Mon Sep 17 00:00:00 2001 From: Dave Date: Wed, 18 Mar 2026 12:00:08 +0000 Subject: [PATCH] story-kit: create 283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge --- ...ot_ambient_mode_toggle_via_chat_command.md | 23 -------------- ..._flag_before_advancing_from_qa_to_merge.md | 30 +++++++++++++++++++ 2 files changed, 30 insertions(+), 23 deletions(-) delete mode 100644 .story_kit/work/1_upcoming/282_story_matrix_bot_ambient_mode_toggle_via_chat_command.md create mode 100644 .story_kit/work/1_upcoming/283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge.md diff --git a/.story_kit/work/1_upcoming/282_story_matrix_bot_ambient_mode_toggle_via_chat_command.md b/.story_kit/work/1_upcoming/282_story_matrix_bot_ambient_mode_toggle_via_chat_command.md deleted file mode 100644 index 8f211b2..0000000 --- a/.story_kit/work/1_upcoming/282_story_matrix_bot_ambient_mode_toggle_via_chat_command.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: "Matrix bot ambient mode toggle via chat command" ---- - -# Story 282: Matrix bot ambient mode toggle via chat command - -## User Story - -As a user chatting with Timmy in a Matrix room, I want to toggle between "addressed mode" (bot only responds when mentioned by name) and "ambient mode" (bot responds to all messages) via a chat command, so that I don't have to @-mention the bot on every message when I'm the only one around. - -## Acceptance Criteria - -- [ ] Matrix bot defaults to addressed mode — only forwards messages containing the bot's name to Claude -- [ ] Chat command "timmy ambient on" switches to ambient mode — bot forwards all room messages to Claude -- [ ] Chat command "timmy ambient off" switches back to addressed mode -- [ ] Mode persists until explicitly toggled (not across bot restarts) -- [ ] Bot confirms the mode switch with a short response in chat -- [ ] When other users join or are active, user can flip back to addressed mode to avoid noise -- [ ] Ambient mode applies per-room (not globally across all rooms) - -## Out of Scope - -- TBD diff --git a/.story_kit/work/1_upcoming/283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge.md b/.story_kit/work/1_upcoming/283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge.md new file mode 100644 index 0000000..e62be91 --- /dev/null +++ b/.story_kit/work/1_upcoming/283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge.md @@ -0,0 +1,30 @@ +--- +name: "Pipeline does not check manual_qa flag before advancing from QA to merge" +--- + +# Bug 283: Pipeline does not check manual_qa flag before advancing from QA to merge + +## Description + +Story 247 added the manual_qa front matter field and the MCP tooling to set it, but the pipeline in pool.rs never actually checks the flag. After QA passes gates and coverage, stories move straight to merge regardless of manual_qa setting. + +## How to Reproduce + +1. Create a story with manual_qa: true in front matter +2. Let it go through the coder and QA stages +3. Observe that it moves directly to merge without waiting for human approval + +## Actual Result + +Stories always advance from QA to merge automatically, ignoring the manual_qa flag. + +## Expected Result + +Stories with manual_qa: true should pause after QA passes and wait for human approval before moving to merge. Stories with manual_qa: false (the default) should advance automatically as they do now. + +## Acceptance Criteria + +- [ ] Pipeline checks manual_qa front matter field after QA gates pass +- [ ] manual_qa defaults to false — stories advance automatically unless explicitly opted in +- [ ] Stories with manual_qa: true wait in 3_qa for human approval via accept_story or the UI +- [ ] Stories with manual_qa: false proceed directly from QA to merge as before