From be56792c6e13f42d68a4600fa9bbb676fc3ccaa1 Mon Sep 17 00:00:00 2001 From: Dave Date: Wed, 18 Mar 2026 14:41:46 +0000 Subject: [PATCH] story-kit: create 289_bug_rebuild_and_restart_mcp_tool_does_not_rebuild --- ...d_and_restart_mcp_tool_does_not_rebuild.md | 27 +++++++++++++++++ ...bient_mode_state_lost_on_server_restart.md | 29 ------------------- 2 files changed, 27 insertions(+), 29 deletions(-) create mode 100644 .story_kit/work/1_backlog/289_bug_rebuild_and_restart_mcp_tool_does_not_rebuild.md delete mode 100644 .story_kit/work/1_upcoming/288_bug_ambient_mode_state_lost_on_server_restart.md diff --git a/.story_kit/work/1_backlog/289_bug_rebuild_and_restart_mcp_tool_does_not_rebuild.md b/.story_kit/work/1_backlog/289_bug_rebuild_and_restart_mcp_tool_does_not_rebuild.md new file mode 100644 index 0000000..daac6ff --- /dev/null +++ b/.story_kit/work/1_backlog/289_bug_rebuild_and_restart_mcp_tool_does_not_rebuild.md @@ -0,0 +1,27 @@ +--- +name: "rebuild_and_restart MCP tool does not rebuild" +--- + +# Bug 289: rebuild_and_restart MCP tool does not rebuild + +## Description + +The rebuild_and_restart MCP tool re-execs the server binary but does not run cargo build first. It restarts with the old binary, so code changes are not picked up. + +## How to Reproduce + +1. Make a code change to the server +2. Call rebuild_and_restart via MCP +3. Observe the server restarts but the code change is not reflected + +## Actual Result + +Server re-execs with the old binary. Code changes are not compiled. + +## Expected Result + +Server runs cargo build --release (or cargo build) before re-execing, so the new binary includes the latest code changes. + +## Acceptance Criteria + +- [ ] Bug is fixed and verified diff --git a/.story_kit/work/1_upcoming/288_bug_ambient_mode_state_lost_on_server_restart.md b/.story_kit/work/1_upcoming/288_bug_ambient_mode_state_lost_on_server_restart.md deleted file mode 100644 index a6d67e8..0000000 --- a/.story_kit/work/1_upcoming/288_bug_ambient_mode_state_lost_on_server_restart.md +++ /dev/null @@ -1,29 +0,0 @@ ---- -name: "Ambient mode state lost on server restart" ---- - -# Bug 288: Ambient mode state lost on server restart - -## Description - -Story 282 implemented ambient mode toggle but only in-memory. The acceptance criterion requiring persistence in bot.toml was not implemented. Every server restart (including rebuild_and_restart) clears ambient mode for all rooms. - -## How to Reproduce - -1. Type "timmy ambient on" — get confirmation -2. Restart server (or rebuild_and_restart) -3. Send unaddressed message — bot ignores it, ambient mode is gone - -## Actual Result - -Ambient mode state is lost on server restart. - -## Expected Result - -Ambient mode per-room state is persisted in bot.toml and restored on startup. - -## Acceptance Criteria - -- [ ] Ambient mode per-room state is saved to bot.toml when toggled -- [ ] Ambient mode state is restored from bot.toml on server startup -- [ ] bot.toml.example includes the ambient_rooms setting with a comment