dave/storkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

story-kit: merge 156_bug_onboarding_welcome_screen_triggers_on_already_configured_projects

Browse Source
This commit is contained in:
Dave
2026-02-24 16:13:39 +00:00
parent 125b77a592
commit b621727f48
2 changed files with 42 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
server/src/io/onboarding.rs
View File

@@ -1,12 +1,10 @@
use std::path::Path;
/// Unique marker found in the scaffold template for `00_CONTEXT.md`.
/// If the project's context file contains this phrase, it is still the
/// default scaffold content and needs to be replaced.
const TEMPLATE_MARKER_CONTEXT: &str = "Agentic AI Code Assistant";
/// Unique marker found in the scaffold template for `STACK.md`.
const TEMPLATE_MARKER_STACK: &str = "Agentic Code Assistant";
/// Sentinel comment injected as the first line of scaffold templates.
/// Only untouched templates contain this marker — real project content
/// will never include it, so it avoids false positives when the project
/// itself is an "Agentic AI Code Assistant".
const TEMPLATE_SENTINEL: &str = "<!-- story-kit:scaffold-template -->";
/// Marker found in the default `script/test` scaffold output.
const TEMPLATE_MARKER_SCRIPT: &str = "No tests configured";
@@ -40,11 +38,11 @@ pub fn check_onboarding_status(project_root: &Path) -> OnboardingStatus {
OnboardingStatus {
needs_context: is_template_or_missing(
&story_kit.join("specs").join("00_CONTEXT.md"),
TEMPLATE_MARKER_CONTEXT,
TEMPLATE_SENTINEL,
),
needs_stack: is_template_or_missing(
&story_kit.join("specs").join("tech").join("STACK.md"),
TEMPLATE_MARKER_STACK,
TEMPLATE_SENTINEL,
),
needs_test_script: is_template_or_missing(
&project_root.join("script").join("test"),
@@ -102,19 +100,19 @@ mod tests {
}
#[test]
fn needs_onboarding_true_when_specs_contain_scaffold_markers() {
fn needs_onboarding_true_when_specs_contain_scaffold_sentinel() {
let dir = TempDir::new().unwrap();
let root = setup_project(&dir);
// Write scaffold template content
// Write content that includes the scaffold sentinel
fs::write(
root.join(".story_kit/specs/00_CONTEXT.md"),
"# Project Context\nTo build a standalone Agentic AI Code Assistant...",
"<!-- story-kit:scaffold-template -->\n# Project Context\nPlaceholder...",
)
.unwrap();
fs::write(
root.join(".story_kit/specs/tech/STACK.md"),
"# Tech Stack\nThis is an Agentic Code Assistant binary...",
"<!-- story-kit:scaffold-template -->\n# Tech Stack\nPlaceholder...",
)
.unwrap();
@@ -124,6 +122,30 @@ mod tests {
assert!(status.needs_onboarding());
}
#[test]
fn needs_onboarding_false_when_content_mentions_agentic_but_no_sentinel() {
let dir = TempDir::new().unwrap();
let root = setup_project(&dir);
// Real project content that happens to mention "Agentic AI Code Assistant"
// but does NOT contain the scaffold sentinel — should NOT trigger onboarding.
fs::write(
root.join(".story_kit/specs/00_CONTEXT.md"),
"# Project Context\nTo build a standalone Agentic AI Code Assistant application.",
)
.unwrap();
fs::write(
root.join(".story_kit/specs/tech/STACK.md"),
"# Tech Stack\nThis is an Agentic Code Assistant binary.",
)
.unwrap();
let status = check_onboarding_status(&root);
assert!(!status.needs_context);
assert!(!status.needs_stack);
assert!(!status.needs_onboarding());
}
#[test]
fn needs_onboarding_false_when_specs_have_custom_content() {
let dir = TempDir::new().unwrap();
@@ -239,13 +261,13 @@ mod tests {
let dir = TempDir::new().unwrap();
let root = setup_project(&dir);
// Context is still template
// Context still has sentinel
fs::write(
root.join(".story_kit/specs/00_CONTEXT.md"),
"Agentic AI Code Assistant placeholder",
"<!-- story-kit:scaffold-template -->\n# Project Context\nPlaceholder...",
)
.unwrap();
// Stack is customised
// Stack is customised (no sentinel)
fs::write(
root.join(".story_kit/specs/tech/STACK.md"),
"# My Stack\nRuby on Rails + PostgreSQL",