story-kit: accept 257_story_rename_storkit_to_story_kit_in_header
This commit is contained in:
@@ -0,0 +1,15 @@
|
||||
---
|
||||
name: "Rename StorkIt to Story Kit in the header"
|
||||
---
|
||||
|
||||
# Story 257: Rename "StorkIt" to "Story Kit" in the header
|
||||
|
||||
## Description
|
||||
|
||||
The ChatHeader component displays "StorkIt" as the app title. It should say "Story Kit" instead.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] The header in `ChatHeader.tsx` displays "Story Kit" instead of "StorkIt"
|
||||
- [ ] The test in `ChatHeader.test.tsx` is updated to match
|
||||
- [ ] All existing tests pass
|
||||
@@ -0,0 +1,26 @@
|
||||
---
|
||||
name: "Auto-assign not called after merge failure"
|
||||
---
|
||||
|
||||
# Bug 258: Auto-assign not called after merge failure
|
||||
|
||||
## Description
|
||||
|
||||
When the background merge pipeline fails (e.g. quality gate timeout), `auto_assign_available_work` is never called. The story stays in `4_merge/` with no agent assigned, requiring manual intervention.
|
||||
|
||||
### Root cause
|
||||
|
||||
In `pool.rs`, `start_merge_agent_work` spawns a tokio task that calls `run_merge_pipeline`. On failure, the task updates the job status to `Failed` but does NOT call `auto_assign_available_work`. The only call to `auto_assign` in the merge pipeline is inside `run_merge_pipeline` on the success path (line ~1251).
|
||||
|
||||
The `spawn_pipeline_advance` completion handler does call `auto_assign` after the mergemaster agent exits, but only on the success path (post-merge tests pass → move to done → auto_assign). On failure, it returns early without triggering auto-assign.
|
||||
|
||||
There is no periodic sweep — auto-assign is purely reactive (watcher events, agent completions, startup).
|
||||
|
||||
### Impact
|
||||
|
||||
After a merge failure, the story is permanently stuck in `4_merge/` with no agent. The only way to unstick it is to restart the server or manually trigger a watcher event.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] After a merge pipeline failure, `auto_assign_available_work` is called so the mergemaster can retry
|
||||
- [ ] Stories in `4_merge/` do not get permanently stuck after transient merge failures
|
||||
Reference in New Issue
Block a user