From 6c03c4f9dc99a9d87d4739d2f7b6f5c6d73211b8 Mon Sep 17 00:00:00 2001 From: Dave Date: Thu, 19 Mar 2026 21:48:27 +0000 Subject: [PATCH] story-kit: done 319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules --- ...uto_assign_and_agent_management_modules.md | 29 ----------------- ...cp_rs_into_domain_specific_tool_modules.md | 32 ------------------- ..._into_story_bug_and_test_result_modules.md | 0 3 files changed, 61 deletions(-) delete mode 100644 .story_kit/work/1_backlog/317_refactor_split_pool_rs_into_pipeline_auto_assign_and_agent_management_modules.md delete mode 100644 .story_kit/work/1_backlog/318_refactor_split_mcp_rs_into_domain_specific_tool_modules.md rename .story_kit/work/{1_backlog => 5_done}/319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules.md (100%) diff --git a/.story_kit/work/1_backlog/317_refactor_split_pool_rs_into_pipeline_auto_assign_and_agent_management_modules.md b/.story_kit/work/1_backlog/317_refactor_split_pool_rs_into_pipeline_auto_assign_and_agent_management_modules.md deleted file mode 100644 index 79d93f6..0000000 --- a/.story_kit/work/1_backlog/317_refactor_split_pool_rs_into_pipeline_auto_assign_and_agent_management_modules.md +++ /dev/null @@ -1,29 +0,0 @@ ---- -name: "Split pool.rs into pipeline, auto-assign, and agent management modules" ---- - -# Refactor 317: Split pool.rs into pipeline, auto-assign, and agent management modules - -## Current State - -- TBD - -## Desired State - -pool.rs is 5,852 lines and handles agent pool management, pipeline advancement, auto-assign logic, completion handling, and has massive test suites all in one file. Split into focused modules: -- pool.rs — core agent pool (start, stop, list, inject) -- pipeline.rs — run_pipeline_advance and stage transition logic -- auto_assign.rs — auto_assign_available_work and assignment logic -- Tests split into corresponding test modules - -## Acceptance Criteria - -- [ ] pool.rs reduced to core agent management (start, stop, list) -- [ ] Pipeline advancement logic extracted to agents/pipeline.rs -- [ ] Auto-assign logic extracted to agents/auto_assign.rs -- [ ] All existing tests pass without modification to test logic -- [ ] No public API changes — callers still access everything through AgentPool - -## Out of Scope - -- TBD diff --git a/.story_kit/work/1_backlog/318_refactor_split_mcp_rs_into_domain_specific_tool_modules.md b/.story_kit/work/1_backlog/318_refactor_split_mcp_rs_into_domain_specific_tool_modules.md deleted file mode 100644 index aab576f..0000000 --- a/.story_kit/work/1_backlog/318_refactor_split_mcp_rs_into_domain_specific_tool_modules.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -name: "Split mcp.rs into domain-specific tool modules" ---- - -# Refactor 318: Split mcp.rs into domain-specific tool modules - -## Current State - -- TBD - -## Desired State - -mcp.rs is 4,925 lines containing all MCP tool definitions and handlers in a single file. Split by domain: -- mcp/mod.rs — JSON-RPC dispatch, tools list registration -- mcp/story_tools.rs — create_story, update_story, check_criterion, add_criterion, accept_story, move_story -- mcp/agent_tools.rs — start_agent, stop_agent, list_agents, get_agent_output, wait_for_agent -- mcp/merge_tools.rs — merge_agent_work, get_merge_status, move_story_to_merge, report_merge_failure -- mcp/qa_tools.rs — request_qa, approve_qa, reject_qa, launch_qa_app -- mcp/diagnostics.rs — get_server_logs, get_pipeline_status, get_token_usage, rebuild_and_restart -- Tests split into corresponding test modules - -## Acceptance Criteria - -- [ ] mcp.rs split into domain-specific modules under http/mcp/ -- [ ] JSON-RPC dispatch remains in mod.rs, delegates to domain handlers -- [ ] All tool handler signatures unchanged -- [ ] All existing tests pass -- [ ] No public API changes - -## Out of Scope - -- TBD diff --git a/.story_kit/work/1_backlog/319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules.md b/.story_kit/work/5_done/319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules.md similarity index 100% rename from .story_kit/work/1_backlog/319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules.md rename to .story_kit/work/5_done/319_refactor_split_workflow_rs_into_story_bug_and_test_result_modules.md