From 514258469136520adda1a098ecb5b4f12b8b8718 Mon Sep 17 00:00:00 2001 From: Dave Date: Mon, 23 Feb 2026 14:39:11 +0000 Subject: [PATCH] story-kit: start 70_story_server_owned_agent_completion_remove_report_completion_dependency --- ...etion_remove_report_completion_dependency.md | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.story_kit/work/2_current/70_story_server_owned_agent_completion_remove_report_completion_dependency.md b/.story_kit/work/2_current/70_story_server_owned_agent_completion_remove_report_completion_dependency.md index 7f554d0..62b8fa2 100644 --- a/.story_kit/work/2_current/70_story_server_owned_agent_completion_remove_report_completion_dependency.md +++ b/.story_kit/work/2_current/70_story_server_owned_agent_completion_remove_report_completion_dependency.md @@ -1,18 +1,27 @@ --- name: "Server-owned agent completion: remove report_completion dependency" -test_plan: pending +test_plan: approved --- # Story 70: Server-owned agent completion: remove report_completion dependency ## User Story -As a ..., I want ..., so that ... +As a developer using story-kit, I want the server to automatically run acceptance +gates and advance the pipeline when an agent process exits, so that the pipeline +does not stall when an agent forgets or fails to call `report_completion`. ## Acceptance Criteria -- [ ] TODO +- [ ] When an agent process exits normally, the server automatically runs acceptance gates (uncommitted changes check + cargo clippy + tests) +- [ ] When acceptance gates pass on natural process exit, the agent status is set to `Completed` and the pipeline advances +- [ ] When acceptance gates fail on natural process exit, the agent status is set to `Failed` and the pipeline handles the failure appropriately +- [ ] `report_completion` is removed from the MCP tools list (agents no longer see or call it) +- [ ] The default agent prompt no longer instructs agents to call `report_completion` +- [ ] If a completion was already recorded before the process exits (legacy path), the server does not run gates a second time ## Out of Scope -- TBD +- Removing the concept of a `CompletionReport` struct (still used internally) +- Changing the pipeline advancement logic itself +- Frontend changes