From 3b66b89c903c775f04eba6a0b86508ff7f9f91d6 Mon Sep 17 00:00:00 2001 From: Dave Date: Tue, 17 Mar 2026 13:07:03 +0000 Subject: [PATCH] story-kit: remove 256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification --- ...ity_before_checking_device_verification.md | 35 ------------------- 1 file changed, 35 deletions(-) delete mode 100644 .story_kit/work/4_merge/256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification.md diff --git a/.story_kit/work/4_merge/256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification.md b/.story_kit/work/4_merge/256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification.md deleted file mode 100644 index 36e5ac7..0000000 --- a/.story_kit/work/4_merge/256_story_bot_must_verify_other_users_cross_signing_identity_before_checking_device_verification.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -name: "Bot must verify other users' cross-signing identity before checking device verification" -agent: coder-opus -merge_failure: "Rename/rename conflict on the story file: master has it in work/4_merge/ while the feature branch has it in work/2_current/. The auto-resolver cannot handle rename/rename conflicts (it expects the file at work/1_upcoming/ which no longer exists). A human needs to resolve the story file location conflict before re-triggering the merge." ---- - -# Story 256: Bot must verify other users' cross-signing identity before checking device verification - -## User Story - -As a Matrix user messaging the bot, I want the bot to correctly recognize my cross-signing-verified devices, so that my messages are not rejected when I have a valid verified identity. - -## Acceptance Criteria - -- [ ] The bot's `check_sender_verified` function (or equivalent) verifies the sender's identity trust status, not just individual device verification -- [ ] When @yossarian:crashlabs.io (who has valid cross-signing keys) sends a message in an encrypted room, the bot accepts it instead of rejecting with 'no cross-signing-verified device found' -- [ ] The bot still rejects messages from users who genuinely have no cross-signing setup -- [ ] Existing tests (if any) continue to pass after the change - -## Out of Scope - -- TBD - -## Test Results - - - -### Unit Tests (2 passed, 0 failed) - -- ✅ sender_with_cross_signing_identity_is_accepted — Verifies get_user_identity Some(_) → accepted -- ✅ sender_without_cross_signing_identity_is_rejected — Verifies get_user_identity None → rejected - -### Integration Tests (0 passed, 0 failed) - -*No integration tests recorded.*