story-kit: start 70_story_server_owned_agent_completion_remove_report_completion_dependency
This commit is contained in:
@@ -0,0 +1,27 @@
|
||||
---
|
||||
name: Server-owned agent completion: remove report_completion dependency
|
||||
test_plan: approved
|
||||
---
|
||||
|
||||
# Story 70: Server-owned agent completion: remove report_completion dependency
|
||||
|
||||
## User Story
|
||||
|
||||
As a developer using story-kit, I want the server to automatically run acceptance
|
||||
gates and advance the pipeline when an agent process exits, so that the pipeline
|
||||
does not stall when an agent forgets or fails to call `report_completion`.
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] When an agent process exits normally, the server automatically runs acceptance gates (uncommitted changes check + cargo clippy + tests)
|
||||
- [ ] When acceptance gates pass on natural process exit, the agent status is set to `Completed` and the pipeline advances
|
||||
- [ ] When acceptance gates fail on natural process exit, the agent status is set to `Failed` and the pipeline handles the failure appropriately
|
||||
- [ ] `report_completion` is removed from the MCP tools list (agents no longer see or call it)
|
||||
- [ ] The default agent prompt no longer instructs agents to call `report_completion`
|
||||
- [ ] If a completion was already recorded before the process exits (legacy path), the server does not run gates a second time
|
||||
|
||||
## Out of Scope
|
||||
|
||||
- Removing the concept of a `CompletionReport` struct (still used internally)
|
||||
- Changing the pipeline advancement logic itself
|
||||
- Frontend changes
|
||||
@@ -0,0 +1,42 @@
|
||||
---
|
||||
name: "Work item creation does not quote YAML special characters or include front matter"
|
||||
test_plan: pending
|
||||
---
|
||||
|
||||
# Bug 72: Work item creation does not quote YAML special characters or include front matter
|
||||
|
||||
## Description
|
||||
|
||||
Two related issues in server-side work item creation:
|
||||
|
||||
1. **create_story** writes the `name` value into YAML front matter without quoting. If the name contains YAML-special characters like colons, the resulting front matter is invalid YAML and fails to parse.
|
||||
|
||||
2. **create_bug** does not write YAML front matter at all (no `---` block with `name` and `test_plan`). The UI/parser expects front matter on all work items in the pipeline, so bug files show parse errors.
|
||||
|
||||
## How to Reproduce
|
||||
|
||||
### Issue 1 (create_story)
|
||||
1. Call create_story with a name containing a colon, e.g. "Server-owned agent completion: remove report_completion dependency"
|
||||
2. Open the generated .md file
|
||||
3. Observe the front matter parser rejects it: "mapping values are not allowed in this context"
|
||||
|
||||
### Issue 2 (create_bug)
|
||||
1. Call create_bug with any name
|
||||
2. Open the generated .md file
|
||||
3. Observe there is no YAML front matter block — just a markdown heading
|
||||
|
||||
## Actual Result
|
||||
|
||||
- create_story: Invalid front matter when name contains colons
|
||||
- create_bug: No front matter at all
|
||||
|
||||
## Expected Result
|
||||
|
||||
- All work item creation methods should write valid YAML front matter with quoted `name` values
|
||||
- create_bug should include `---` front matter block with `name` and `test_plan` fields, consistent with create_story
|
||||
|
||||
## Acceptance Criteria
|
||||
|
||||
- [ ] create_story quotes name values containing YAML-special characters
|
||||
- [ ] create_bug writes YAML front matter with name and test_plan fields
|
||||
- [ ] Existing tests updated to cover special character handling
|
||||
Reference in New Issue
Block a user