dave/storkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

story-kit: done 283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge

Browse Source
This commit is contained in:
Dave
2026-03-18 12:34:46 +00:00
parent b09a2cbdf9
commit 281531624d
1 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
.story_kit/work/5_done/283_bug_pipeline_does_not_check_manual_qa_flag_before_advancing_from_qa_to_merge.md Normal file
View File

@@ -0,0 +1,30 @@
---
name: "Pipeline does not check manual_qa flag before advancing from QA to merge"
---
# Bug 283: Pipeline does not check manual_qa flag before advancing from QA to merge
## Description
Story 247 added the manual_qa front matter field and the MCP tooling to set it, but the pipeline in pool.rs never actually checks the flag. After QA passes gates and coverage, stories move straight to merge regardless of manual_qa setting.
## How to Reproduce
1. Create a story with manual_qa: true in front matter
2. Let it go through the coder and QA stages
3. Observe that it moves directly to merge without waiting for human approval
## Actual Result
Stories always advance from QA to merge automatically, ignoring the manual_qa flag.
## Expected Result
Stories with manual_qa: true should pause after QA passes and wait for human approval before moving to merge. Stories with manual_qa: false (the default) should advance automatically as they do now.
## Acceptance Criteria
- [ ] Pipeline checks manual_qa front matter field after QA gates pass
- [ ] manual_qa defaults to false — stories advance automatically unless explicitly opted in
- [ ] Stories with manual_qa: true wait in 3_qa for human approval via accept_story or the UI
- [ ] Stories with manual_qa: false proceed directly from QA to merge as before