TimmyandClaude Opus 4.7
69d91d7707
Final 929 sweep: every YAML-shaped helper is gone. No production code
parses or writes YAML front matter anywhere.
Surface removed:
- db/yaml_legacy.rs (FrontMatter/StoryMetadata structs, parse_front_matter,
set_front_matter_field, yaml_residue marker) — file deleted.
- ItemMeta::from_yaml — deleted; callers pass typed ItemMeta::named(...) or
ItemMeta::default() and use typed CRDT setters (set_depends_on,
set_blocked, set_retry_count, set_agent, set_qa_mode, set_review_hold,
set_item_type, set_epic, set_mergemaster_attempted) for the rest.
- write_coverage_baseline_to_story_file + read_coverage_percent_from_json —
the coverage_baseline YAML field was write-only (nothing read it back);
removed along with its caller in agent_tools/lifecycle.rs.
- update_story_in_file's generic `front_matter` HashMap parameter —
tool_update_story now intercepts every known field name and routes it
to a typed CRDT setter; unknown keys are rejected with an explicit error
pointing at the typed setters. The function only takes user_story /
description sections now.
- All 117 ItemMeta::from_yaml callsites migrated. Where tests previously
passed a YAML-shaped content blob and relied on the helper to extract
name/depends_on/blocked/agent/qa, they now pass:
write_item_with_content(id, stage, content, ItemMeta::named("Foo"))
crate::crdt_state::set_depends_on(id, &[...]) // when needed
crate::crdt_state::set_blocked(id, true) // when needed
crate::crdt_state::set_agent(id, Some("...")) // when needed
- write_story_content + write_story_file (test helper) now take an
explicit `name: Option<&str>` instead of parsing it from content.
- db::ops::move_item_stage stopped re-parsing YAML on every stage
transition; metadata is read straight from the CRDT view when mirroring
the row into SQLite.
New CRDT setters added for symmetry:
- crdt_state::set_name (mirrors set_agent — explicit name updates).
cargo fmt --check, clippy --all-targets -- -D warnings, and the
2830-test suite all pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
36 lines
1.2 KiB
Rust
36 lines
1.2 KiB
Rust
//! Shared test utilities for chat handler tests.
|
|
//!
|
|
//! Import with `use crate::chat::test_helpers::write_story_file;`
|
|
|
|
use std::path::Path;
|
|
|
|
/// Write a work-item into the content store and CRDT for testing.
|
|
///
|
|
/// Also creates the filesystem directory structure and file so that tests
|
|
/// which still verify filesystem state (e.g. assign tests that check the
|
|
/// physical file) continue to work.
|
|
///
|
|
/// Story 929: callers pass the typed `name` explicitly — `content` is now
|
|
/// just the markdown body and is no longer parsed for metadata. Other
|
|
/// typed fields (depends_on, agent, qa_mode, blocked, …) should be set
|
|
/// via the CRDT typed setters after this call.
|
|
pub(crate) fn write_story_file(
|
|
root: &Path,
|
|
stage: &str,
|
|
filename: &str,
|
|
content: &str,
|
|
name: Option<&str>,
|
|
) {
|
|
let dir = root.join(".huskies/work").join(stage);
|
|
std::fs::create_dir_all(&dir).unwrap();
|
|
std::fs::write(dir.join(filename), content).unwrap();
|
|
|
|
let story_id = filename.trim_end_matches(".md");
|
|
crate::db::ensure_content_store();
|
|
let meta = crate::db::ItemMeta {
|
|
name: name.map(str::to_string),
|
|
..Default::default()
|
|
};
|
|
crate::db::write_item_with_content(story_id, stage, content, meta);
|
|
}
|