Commit Graph

5 Commits

Author SHA1 Message Date
dave 4ed1fb5110 huskies: merge 854 2026-04-29 09:29:32 +00:00
dave dd35a8a530 huskies: merge 799 2026-04-28 21:01:55 +00:00
dave 4a0f57478c huskies: merge 671_refactor_migrate_pipeline_state_consumers_from_string_comparisons_to_typed_pipelinestage_enum 2026-04-27 16:39:39 +00:00
dave b340aa97b0 fix: clean up clippy warnings + cargo fmt across post-refactor surface
The 13-file refactor pass (commits db00a5d4 through eca15b4e) introduced
~89 clippy errors and 38 cargo fmt issues — every agent in every worktree
hit them on script/test, burning their turn budget on cleanup before doing
real story work. This is the silent kill behind 644, 652, 655, 664, 667
all hitting watchdog limits this round.

Changes:
- cargo fmt --all across 37 files (formatting normalisation only)
- #![allow(unused_imports, dead_code)] on 24 split modules where the
  python-script splitter imported liberally to be safe; tighter cleanup
  per-import will happen as agents touch each module
- Removed truly-dead re-exports (cleanup_merge_workspace, slog_warn from
  http/mcp/mod.rs, CliArgs/print_help from main.rs)
- Prefixed _auth_msg in crdt_sync/server.rs (handshake helper return is
  bound but not consumed)
- Converted dangling /// doc block in crdt_sync/mod.rs to //! so it
  attaches to the module
- Removed empty lines after doc comments in 4 spots (clippy lint)

All 2636 tests pass; clippy --all-targets -- -D warnings clean.
2026-04-27 01:32:08 +00:00
dave 5aedf94512 refactor: split pipeline_state.rs into 4 sub-modules with co-located tests
The 1411-line pipeline_state.rs is split into:

- mod.rs: types, transition(), execution_transition(), labels + transition tests (885 lines)
- events.rs: TransitionFired, EventBus, TransitionSubscriber + event-bus tests (114 lines)
- projection.rs: ProjectionError, TryFrom<&PipelineItemView>, read_typed + projection tests (379 lines)
- subscribers.rs: 5 concrete TransitionSubscriber stubs (95 lines)

Tests stay co-located.

No behaviour change. All 42 pipeline_state tests pass; full suite green.
2026-04-26 21:30:55 +00:00