crashlabs/huskies
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

huskies: merge 619_story_service_common_consolidation_sweep

Browse Source
This commit is contained in:
dave
2026-04-24 21:32:39 +00:00
parent c16d9e471d
commit e1bfbf4232
5 changed files with 86 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/service/notifications/format.rs
+6 -36
View File
@@ -4,6 +4,8 @@
//! or borrowed string data. They return `(plain_text, html)` pairs suitable
//! for `ChatTransport::send_message`.
use crate::service::common::item_id::extract_item_number;
/// Human-readable display name for a pipeline stage directory.
pub fn stage_display_name(stage: &str) -> &'static str {
match stage {
@@ -17,14 +19,6 @@ pub fn stage_display_name(stage: &str) -> &'static str {
}
}
/// Extract the numeric story number from an item ID like `"261_story_slug"`.
pub fn extract_story_number(item_id: &str) -> Option<&str> {
item_id
.split('_')
.next()
.filter(|s| !s.is_empty() && s.chars().all(|c| c.is_ascii_digit()))
}
/// Format a stage transition notification message.
///
/// Returns `(plain_text, html)` suitable for `ChatTransport::send_message`.
@@ -34,7 +28,7 @@ pub fn format_stage_notification(
from_stage: &str,
to_stage: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let number = extract_item_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let prefix = if to_stage == "Done" { "\u{1f389} " } else { "" };
@@ -53,7 +47,7 @@ pub fn format_error_notification(
story_name: Option<&str>,
reason: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let number = extract_item_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let plain = format!("\u{274c} #{number} {name} \u{2014} {reason}");
@@ -69,7 +63,7 @@ pub fn format_blocked_notification(
story_name: Option<&str>,
reason: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let number = extract_item_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let plain = format!("\u{1f6ab} #{number} {name} \u{2014} BLOCKED: {reason}");
@@ -86,7 +80,7 @@ pub fn format_rate_limit_notification(
story_name: Option<&str>,
agent_name: &str,
) -> (String, String) {
let number = extract_story_number(item_id).unwrap_or(item_id);
let number = extract_item_number(item_id).unwrap_or(item_id);
let name = story_name.unwrap_or(item_id);
let plain =
@@ -121,30 +115,6 @@ mod tests {
assert_eq!(stage_display_name(""), "Unknown");
}
// ── extract_story_number ──────────────────────────────────────────────────
#[test]
fn extract_story_number_parses_numeric_prefix() {
assert_eq!(
extract_story_number("261_story_bot_notifications"),
Some("261")
);
assert_eq!(extract_story_number("42_bug_fix_thing"), Some("42"));
assert_eq!(extract_story_number("1_spike_research"), Some("1"));
}
#[test]
fn extract_story_number_returns_none_for_non_numeric() {
assert_eq!(extract_story_number("abc_story_thing"), None);
assert_eq!(extract_story_number(""), None);
}
#[test]
fn extract_story_number_returns_none_for_empty_first_segment() {
// Leading underscore: first segment is ""
assert_eq!(extract_story_number("_story_thing"), None);
}
// ── format_stage_notification ─────────────────────────────────────────────
#[test]