storkit: merge 444_refactor_extract_shared_test_helpers_test_ctx_write_story_file_make_api

server/src/http/model.rs

@@ -50,22 +50,23 @@ impl ModelApi {
     }
 }
 
+#[cfg(test)]
+impl From<std::sync::Arc<AppContext>> for ModelApi {
+    fn from(ctx: std::sync::Arc<AppContext>) -> Self {
+        Self { ctx }
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::http::context::AppContext;
+    use crate::http::test_helpers::make_api;
     use tempfile::TempDir;
 
-    fn make_api(dir: &TempDir) -> ModelApi {
-        ModelApi {
-            ctx: Arc::new(AppContext::new_test(dir.path().to_path_buf())),
-        }
-    }
-
     #[tokio::test]
     async fn get_model_preference_returns_none_when_unset() {
         let dir = TempDir::new().unwrap();
-        let api = make_api(&dir);
+        let api = make_api::<ModelApi>(&dir);
         let result = api.get_model_preference().await.unwrap();
         assert!(result.0.is_none());
     }
@@ -73,7 +74,7 @@ mod tests {
     #[tokio::test]
     async fn set_model_preference_returns_true() {
         let dir = TempDir::new().unwrap();
-        let api = make_api(&dir);
+        let api = make_api::<ModelApi>(&dir);
         let payload = Json(ModelPayload {
             model: "claude-3-sonnet".to_string(),
         });
@@ -84,7 +85,7 @@ mod tests {
     #[tokio::test]
     async fn get_model_preference_returns_value_after_set() {
         let dir = TempDir::new().unwrap();
-        let api = make_api(&dir);
+        let api = make_api::<ModelApi>(&dir);
 
         let payload = Json(ModelPayload {
             model: "claude-3-sonnet".to_string(),
@@ -98,7 +99,7 @@ mod tests {
     #[tokio::test]
     async fn set_model_preference_overwrites_previous_value() {
         let dir = TempDir::new().unwrap();
-        let api = make_api(&dir);
+        let api = make_api::<ModelApi>(&dir);
 
         api.set_model_preference(Json(ModelPayload {
             model: "model-a".to_string(),
@@ -119,7 +120,7 @@ mod tests {
     #[tokio::test]
     async fn get_ollama_models_returns_empty_list_for_unreachable_url() {
         let dir = TempDir::new().unwrap();
-        let api = make_api(&dir);
+        let api = make_api::<ModelApi>(&dir);
         // Port 1 is reserved and should immediately refuse the connection.
         let base_url = Query(Some("http://127.0.0.1:1".to_string()));
         let result = api.get_ollama_models(base_url).await;