crashlabs/huskies
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: add ETXTBSY retry to run_coverage_gate

Browse Source 
Use fsync in coverage gate tests to ensure the kernel releases the
write handle before executing the script. Prevents flaky ETXTBSY
errors on fast test runs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
dave
2026-04-12 12:37:05 +00:00
parent f140238cc3
commit c80931c15c
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/agents/gates.rs
+12 -10
View File
@@ -299,6 +299,7 @@ mod tests {
#[test] #[test]
fn coverage_gate_passes_when_script_exits_zero() { fn coverage_gate_passes_when_script_exits_zero() {
use std::fs; use std::fs;
use std::io::Write;
use std::os::unix::fs::PermissionsExt; use std::os::unix::fs::PermissionsExt;
let tmp = tempfile::tempdir().unwrap(); let tmp = tempfile::tempdir().unwrap();
@@ -306,11 +307,11 @@ mod tests {
let script_dir = path.join("script"); let script_dir = path.join("script");
fs::create_dir_all(&script_dir).unwrap(); fs::create_dir_all(&script_dir).unwrap();
let script = script_dir.join("test_coverage"); let script = script_dir.join("test_coverage");
fs::write( {
&script, let mut f = fs::File::create(&script).unwrap();
"#!/usr/bin/env bash\necho 'Rust line coverage: 85%'\necho 'PASS: Coverage 85% meets threshold 0%'\nexit 0\n", f.write_all(b"#!/usr/bin/env bash\necho 'Rust line coverage: 85%'\necho 'PASS: Coverage 85% meets threshold 0%'\nexit 0\n").unwrap();
) f.sync_all().unwrap();
.unwrap(); }
let mut perms = fs::metadata(&script).unwrap().permissions(); let mut perms = fs::metadata(&script).unwrap().permissions();
perms.set_mode(0o755); perms.set_mode(0o755);
fs::set_permissions(&script, perms).unwrap(); fs::set_permissions(&script, perms).unwrap();
@@ -327,6 +328,7 @@ mod tests {
#[test] #[test]
fn coverage_gate_fails_when_script_exits_nonzero() { fn coverage_gate_fails_when_script_exits_nonzero() {
use std::fs; use std::fs;
use std::io::Write;
use std::os::unix::fs::PermissionsExt; use std::os::unix::fs::PermissionsExt;
let tmp = tempfile::tempdir().unwrap(); let tmp = tempfile::tempdir().unwrap();
@@ -334,11 +336,11 @@ mod tests {
let script_dir = path.join("script"); let script_dir = path.join("script");
fs::create_dir_all(&script_dir).unwrap(); fs::create_dir_all(&script_dir).unwrap();
let script = script_dir.join("test_coverage"); let script = script_dir.join("test_coverage");
fs::write( {
&script, let mut f = fs::File::create(&script).unwrap();
"#!/usr/bin/env bash\necho 'FAIL: Coverage 40% is below threshold 80%'\nexit 1\n", f.write_all(b"#!/usr/bin/env bash\necho 'FAIL: Coverage 40% is below threshold 80%'\nexit 1\n").unwrap();
) f.sync_all().unwrap();
.unwrap(); }
let mut perms = fs::metadata(&script).unwrap().permissions(); let mut perms = fs::metadata(&script).unwrap().permissions();
perms.set_mode(0o755); perms.set_mode(0o755);
fs::set_permissions(&script, perms).unwrap(); fs::set_permissions(&script, perms).unwrap();