huskies: merge 945

server/src/agents/pool/pipeline/advance/helpers.rs

@@ -66,10 +66,21 @@ pub(super) fn resolve_qa_mode_from_store(
         .unwrap_or(default)
 }
 
-/// Mark a story as held for human review (story 932: CRDT register).
+/// Mark a story as held for human review (story 945: `Stage::ReviewHold`).
+///
+/// The caller has just moved the story to QA via `move_story_to_qa`, so the
+/// story is in `Stage::Qa`.  We transition to `Stage::ReviewHold { resume_to:
+/// Qa, reason }` so the auto-assigner skips it while preserving the resume
+/// target.
 pub(super) fn write_review_hold_to_store(story_id: &str) {
-    if !crate::crdt_state::set_review_hold(story_id, true) {
-        slog_error!("[pipeline] Cannot set review_hold for '{story_id}': no CRDT entry");
+    if let Err(e) = crate::pipeline_state::apply_transition_str(
+        story_id,
+        crate::pipeline_state::PipelineEvent::ReviewHold {
+            reason: "Held for human review".to_string(),
+        },
+        None,
+    ) {
+        slog_error!("[pipeline] Cannot set review_hold for '{story_id}': {e}");
     }
 }