From 92aa1ebccf303af67a98d877d038a0e798c84a96 Mon Sep 17 00:00:00 2001 From: dave Date: Thu, 26 Mar 2026 20:02:47 +0000 Subject: [PATCH] storkit: done 402_bug_whatsapp_and_slack_missing_rebuild_command_handler --- ...and_slack_missing_start_command_handler.md | 30 ------------------- ...irectory_picker_unreadable_in_dark_mode.md | 30 ------------------- ...d_slack_missing_rebuild_command_handler.md | 27 +++++++++++++++++ 3 files changed, 27 insertions(+), 60 deletions(-) delete mode 100644 .storkit/work/1_backlog/401_bug_whatsapp_and_slack_missing_start_command_handler.md delete mode 100644 .storkit/work/5_done/397_bug_selection_screen_directory_picker_unreadable_in_dark_mode.md create mode 100644 .storkit/work/5_done/402_bug_whatsapp_and_slack_missing_rebuild_command_handler.md diff --git a/.storkit/work/1_backlog/401_bug_whatsapp_and_slack_missing_start_command_handler.md b/.storkit/work/1_backlog/401_bug_whatsapp_and_slack_missing_start_command_handler.md deleted file mode 100644 index 983e6579..00000000 --- a/.storkit/work/1_backlog/401_bug_whatsapp_and_slack_missing_start_command_handler.md +++ /dev/null @@ -1,30 +0,0 @@ ---- -name: "WhatsApp and Slack missing start command handler" ---- - -# Bug 401: WhatsApp and Slack missing start command handler - -## Description - -The start command has a fallback handler in chat/commands/mod.rs that returns None. Only Matrix has pre-dispatch handling for this command. On WhatsApp and Slack, the command falls through to the LLM path. - -## Implementation Note - -The fix must be in the shared command dispatch layer (chat/commands/mod.rs), NOT by adding transport-specific handlers. Study how commands like "rebuild" and "status" already work through the shared dispatch — the start handler should return a concrete result from try_handle_command so all transports get it for free. We do not want separate mechanisms per transport per command. - -## How to Reproduce - -1. Configure bot with transport = "whatsapp" or "slack"\n2. Send "start " to the bot\n3. Check server logs - -## Actual Result - -Command falls through to LLM instead of starting an agent. - -## Expected Result - -The bot starts an agent for the specified story and replies with confirmation. - -## Acceptance Criteria - -- [ ] WhatsApp transport handles start command: starts agent and replies with confirmation -- [ ] Slack transport handles start command: starts agent and replies with confirmation diff --git a/.storkit/work/5_done/397_bug_selection_screen_directory_picker_unreadable_in_dark_mode.md b/.storkit/work/5_done/397_bug_selection_screen_directory_picker_unreadable_in_dark_mode.md deleted file mode 100644 index d66608a2..00000000 --- a/.storkit/work/5_done/397_bug_selection_screen_directory_picker_unreadable_in_dark_mode.md +++ /dev/null @@ -1,30 +0,0 @@ ---- -name: "Selection screen directory picker unreadable in dark mode" ---- - -# Bug 397: Selection screen directory picker unreadable in dark mode - -## Description - -The ProjectPathInput component in the selection screen uses hardcoded light-theme inline styles (white backgrounds, dark borders, dark text highlights) that don't adapt to dark mode. When the browser/OS uses dark mode, the global CSS sets text color to #f6f6f6 (white) but the dropdown keeps background: #fff — resulting in white text on a white background, making the directory picker completely unreadable. - -## How to Reproduce - -1. Run storkit under Docker (or locally) with a browser set to dark mode (prefers-color-scheme: dark). -2. Open http://localhost:3001 in the browser. -3. Click into the project path input and start typing a path to trigger the autocomplete dropdown. - -## Actual Result - -The suggestion dropdown has white background with white/light text inherited from the dark-mode global styles. Match highlights use color: #222 which is barely visible. The close button and header bar also use light-only colors. The entire directory picker is effectively unreadable. - -## Expected Result - -The directory picker dropdown should be readable in both light and dark mode. Colors for background, text, borders, and highlights should adapt to the active color scheme. - -## Acceptance Criteria - -- [ ] ProjectPathInput dropdown is readable in dark mode (prefers-color-scheme: dark) -- [ ] ProjectPathInput dropdown remains readable in light mode -- [ ] Suggestion highlight text is visible against the dropdown background in both themes -- [ ] No hardcoded light-only colors remain in ProjectPathInput inline styles diff --git a/.storkit/work/5_done/402_bug_whatsapp_and_slack_missing_rebuild_command_handler.md b/.storkit/work/5_done/402_bug_whatsapp_and_slack_missing_rebuild_command_handler.md new file mode 100644 index 00000000..1681da79 --- /dev/null +++ b/.storkit/work/5_done/402_bug_whatsapp_and_slack_missing_rebuild_command_handler.md @@ -0,0 +1,27 @@ +--- +name: "WhatsApp and Slack missing rebuild command handler" +blocked: true +--- + +# Bug 402: WhatsApp and Slack missing rebuild command handler + +## Description + +The rebuild command has a fallback handler in chat/commands/mod.rs that returns None. Only Matrix has pre-dispatch handling for this command. On WhatsApp and Slack, the command falls through to the LLM path. + +## How to Reproduce + +1. Configure bot with transport = "whatsapp" or "slack"\n2. Send "rebuild" to the bot\n3. Check server logs + +## Actual Result + +Command falls through to LLM instead of triggering a server rebuild. + +## Expected Result + +The bot triggers a server rebuild and replies with confirmation. + +## Acceptance Criteria + +- [ ] WhatsApp transport handles rebuild command: triggers rebuild and replies with confirmation +- [ ] Slack transport handles rebuild command: triggers rebuild and replies with confirmation