From 8bc0bd592ee62c7140b91f53f49b253e70bf9e48 Mon Sep 17 00:00:00 2001 From: dave Date: Fri, 27 Mar 2026 15:56:03 +0000 Subject: [PATCH] storkit: done 415_refactor_split_agents_pool_mod_rs_into_submodules --- ...refactor_split_io_fs_rs_into_submodules.md | 28 ------------------ ...plit_agents_pool_mod_rs_into_submodules.md | 29 +++++++++++++++++++ 2 files changed, 29 insertions(+), 28 deletions(-) delete mode 100644 .storkit/work/1_backlog/416_refactor_split_io_fs_rs_into_submodules.md create mode 100644 .storkit/work/5_done/415_refactor_split_agents_pool_mod_rs_into_submodules.md diff --git a/.storkit/work/1_backlog/416_refactor_split_io_fs_rs_into_submodules.md b/.storkit/work/1_backlog/416_refactor_split_io_fs_rs_into_submodules.md deleted file mode 100644 index 678bf1d3..00000000 --- a/.storkit/work/1_backlog/416_refactor_split_io_fs_rs_into_submodules.md +++ /dev/null @@ -1,28 +0,0 @@ ---- -name: "Split io/fs.rs into submodules" ---- - -# Refactor 416: Split io/fs.rs into submodules - -## Current State - -- TBD - -## Desired State - -Refactor the monolithic server/src/io/fs.rs (2007 lines) into focused submodules within an fs/ directory. - -## Acceptance Criteria - -- [ ] scaffold.rs contains scaffold_story_kit, write_file_if_missing, write_script_if_missing, write_story_kit_gitignore, append_root_gitignore_entries, detect_components_toml, detect_script_test, generate_project_toml and their unit tests -- [ ] project.rs contains open_project, close_project, get_current_project, get_known_projects, forget_known_project, ensure_project_root_with_story_kit, validate_project_path and their unit tests -- [ ] files.rs contains read_file, write_file, list_directory, list_project_files, FileEntry, create_directory_absolute and their unit tests -- [ ] paths.rs contains resolve_cli_path, resolve_path, resolve_path_impl, find_story_kit_root, get_home_directory and their unit tests -- [ ] preferences.rs contains get_model_preference, set_model_preference and their unit tests -- [ ] mod.rs re-exports all public types and functions -- [ ] Unit tests live in their respective module files -- [ ] No public API changes — all existing imports continue to work - -## Out of Scope - -- TBD diff --git a/.storkit/work/5_done/415_refactor_split_agents_pool_mod_rs_into_submodules.md b/.storkit/work/5_done/415_refactor_split_agents_pool_mod_rs_into_submodules.md new file mode 100644 index 00000000..72955a4d --- /dev/null +++ b/.storkit/work/5_done/415_refactor_split_agents_pool_mod_rs_into_submodules.md @@ -0,0 +1,29 @@ +--- +name: "Split agents/pool/mod.rs into submodules" +--- + +# Refactor 415: Split agents/pool/mod.rs into submodules + +## Current State + +- TBD + +## Desired State + +Refactor the monolithic server/src/agents/pool/mod.rs (2407 lines) into focused submodules within the pool/ directory. + +## Acceptance Criteria + +- [ ] types.rs contains StoryAgent, PendingGuard, AgentInfo, composite_key, and related helper structs +- [ ] lifecycle.rs contains start_agent, stop_agent, wait_for_agent and their unit tests +- [ ] worktree.rs contains create_worktree, get_project_root, find_active_story_stage and their unit tests +- [ ] query.rs contains list_agents, available_agents_for_stage, get_log_info, subscribe, drain_events and their unit tests +- [ ] process.rs contains kill_all_children, kill_child_for_key, ChildKiller registry methods and their unit tests +- [ ] test_helpers.rs contains inject_test_agent and its variants (4 methods) +- [ ] mod.rs contains AgentPool struct, new(), and re-exports all public types +- [ ] Unit tests live in their respective module files, not in a separate tests module +- [ ] No public API changes — all existing imports continue to work + +## Out of Scope + +- TBD