refactor: split http/mcp/story_tools.rs into 5 sub-modules by item type

The 1864-line story_tools.rs is split into: - story.rs: story creation/lifecycle/management (903 lines incl. tests) - criteria.rs: acceptance-criteria tools (534 lines) - bug.rs: bug item tools (318 lines) - spike.rs: spike item tools (120 lines) - refactor.rs: refactor item tools (60 lines) - mod.rs: re-exports (25 lines) Tests stay co-located with the code they exercise; setup_git_repo_in and setup_story_for_update test helpers are duplicated into the modules that need them rather than centralised, since they are tiny and test-only. No behaviour change. All 60 story_tools tests pass; full suite green (2635 tests with --test-threads=1).
2026-04-26 21:11:09 +00:00
parent 0dff2d5c47
commit 851324740c
7 changed files with 2040 additions and 1864 deletions
@@ -0,0 +1,120 @@
+//! Spike item MCP tools.
+
+use crate::agents::{
+    close_bug_to_archive, feature_branch_has_unmerged_changes, move_story_to_done,
+};
+use crate::http::context::AppContext;
+use crate::http::workflow::{
+    add_criterion_to_file, check_criterion_in_file, create_bug_file, create_refactor_file,
+    create_spike_file, create_story_file, edit_criterion_in_file, list_bug_files,
+    list_refactor_files, load_pipeline_state, load_upcoming_stories, remove_criterion_from_file,
+    update_story_in_file, validate_story_dirs,
+};
+use crate::io::story_metadata::{
+    check_archived_deps, check_archived_deps_from_list, parse_front_matter, parse_unchecked_todos,
+};
+use crate::service::story::parse_test_cases;
+use crate::slog_warn;
+#[allow(unused_imports)]
+use crate::workflow::{TestCaseResult, TestStatus, evaluate_acceptance_with_coverage};
+use serde_json::{Value, json};
+use std::collections::HashMap;
+use std::fs;
+
+
+pub(crate) fn tool_create_spike(args: &Value, ctx: &AppContext) -> Result<String, String> {
+    let name = args
+        .get("name")
+        .and_then(|v| v.as_str())
+        .ok_or("Missing required argument: name")?;
+    let description = args.get("description").and_then(|v| v.as_str());
+
+    let root = ctx.state.get_project_root()?;
+    let spike_id = create_spike_file(&root, name, description)?;
+
+    Ok(format!("Created spike: {spike_id}"))
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::http::test_helpers::test_ctx;
+    use super::super::super::tools_list::handle_tools_list;
+    use serde_json::Value;
+
+    #[test]
+    fn create_spike_in_tools_list() {
+        use super::super::super::tools_list::handle_tools_list;
+        let resp = handle_tools_list(Some(json!(1)));
+        let tools = resp.result.unwrap()["tools"].as_array().unwrap().clone();
+        let tool = tools.iter().find(|t| t["name"] == "create_spike");
+        assert!(tool.is_some(), "create_spike missing from tools list");
+        let t = tool.unwrap();
+        assert!(t["description"].is_string());
+        let required = t["inputSchema"]["required"].as_array().unwrap();
+        let req_names: Vec<&str> = required.iter().map(|v| v.as_str().unwrap()).collect();
+        assert!(req_names.contains(&"name"));
+        // description is optional
+        assert!(!req_names.contains(&"description"));
+    }
+
+    #[test]
+    fn tool_create_spike_missing_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let result = tool_create_spike(&json!({}), &ctx);
+        assert!(result.is_err());
+        assert!(result.unwrap_err().contains("name"));
+    }
+
+    #[test]
+    fn tool_create_spike_rejects_empty_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let result = tool_create_spike(&json!({"name": "!!!"}), &ctx);
+        assert!(result.is_err());
+        assert!(result.unwrap_err().contains("alphanumeric"));
+    }
+
+    #[test]
+    fn tool_create_spike_creates_file() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+
+        let result = tool_create_spike(
+            &json!({"name": "Compare Encoders", "description": "Which encoder is fastest?"}),
+            &ctx,
+        )
+        .unwrap();
+
+        assert!(
+            result.contains("_spike_compare_encoders"),
+            "result should contain spike ID: {result}"
+        );
+        // Extract the actual spike ID from the result message (format: "Created spike: <id>").
+        let spike_id = result.trim_start_matches("Created spike: ").trim();
+        // Spike content should exist in the CRDT content store.
+        let contents = crate::db::read_content(spike_id).expect("expected spike content in CRDT");
+        assert!(contents.starts_with("---\nname: \"Compare Encoders\"\n---"));
+        assert!(contents.contains("Which encoder is fastest?"));
+    }
+
+    #[test]
+    fn tool_create_spike_creates_file_without_description() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+
+        let result = tool_create_spike(&json!({"name": "My Spike"}), &ctx).unwrap();
+        assert!(
+            result.contains("_spike_my_spike"),
+            "result should contain spike ID: {result}"
+        );
+        // Extract the actual spike ID from the result message (format: "Created spike: <id>").
+        let spike_id = result.trim_start_matches("Created spike: ").trim();
+
+        // Spike content should exist in the CRDT content store.
+        let contents = crate::db::read_content(spike_id).expect("expected spike content in CRDT");
+        assert!(contents.starts_with("---\nname: \"My Spike\"\n---"));
+        assert!(contents.contains("## Question\n\n- TBD\n"));
+    }
+}