crashlabs/huskies
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

storkit: accept 440_refactor_consolidate_is_permission_approval_into_chat_util

Browse Source
This commit is contained in:
dave
2026-03-28 23:44:25 +00:00
parent d471d29c72
commit 6e0d12d145
1 changed files with 0 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.storkit/work/5_done/440_refactor_consolidate_is_permission_approval_into_chat_util.md
-24
View File
@@ -1,24 +0,0 @@
---
name: "Consolidate is_permission_approval into chat::util"
---
# Refactor 440: Consolidate is_permission_approval into chat::util
## Current State
- TBD
## Desired State
Three copies of `is_permission_approval` exist across Slack (`chat/transport/slack/commands.rs`), WhatsApp (`chat/transport/whatsapp/commands.rs`), and Matrix (`chat/transport/matrix/bot/messages.rs`). The Slack and WhatsApp versions are identical; the Matrix version is a superset that also strips @mentions. Consolidate into a single `pub` function in `chat::util` using the Matrix superset behavior, then delete the 3 private copies.
## Acceptance Criteria
- [ ] Single pub fn is_permission_approval exists in chat::util
- [ ] All 3 private copies are removed
- [ ] Matrix @mention-stripping behavior is preserved in the shared version
- [ ] All call sites use the shared version
## Out of Scope
- TBD