crashlabs/huskies
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 27 Wiki Activity

feat(929): delete db/yaml_legacy.rs entirely — CRDT is the sole source of truth

Browse Source 
Final 929 sweep: every YAML-shaped helper is gone. No production code
parses or writes YAML front matter anywhere.

Surface removed:
- db/yaml_legacy.rs (FrontMatter/StoryMetadata structs, parse_front_matter,
  set_front_matter_field, yaml_residue marker) — file deleted.
- ItemMeta::from_yaml — deleted; callers pass typed ItemMeta::named(...) or
  ItemMeta::default() and use typed CRDT setters (set_depends_on,
  set_blocked, set_retry_count, set_agent, set_qa_mode, set_review_hold,
  set_item_type, set_epic, set_mergemaster_attempted) for the rest.
- write_coverage_baseline_to_story_file + read_coverage_percent_from_json —
  the coverage_baseline YAML field was write-only (nothing read it back);
  removed along with its caller in agent_tools/lifecycle.rs.
- update_story_in_file's generic `front_matter` HashMap parameter —
  tool_update_story now intercepts every known field name and routes it
  to a typed CRDT setter; unknown keys are rejected with an explicit error
  pointing at the typed setters. The function only takes user_story /
  description sections now.
- All 117 ItemMeta::from_yaml callsites migrated. Where tests previously
  passed a YAML-shaped content blob and relied on the helper to extract
  name/depends_on/blocked/agent/qa, they now pass:
    write_item_with_content(id, stage, content, ItemMeta::named("Foo"))
    crate::crdt_state::set_depends_on(id, &[...])    // when needed
    crate::crdt_state::set_blocked(id, true)         // when needed
    crate::crdt_state::set_agent(id, Some("..."))    // when needed
- write_story_content + write_story_file (test helper) now take an
  explicit `name: Option<&str>` instead of parsing it from content.
- db::ops::move_item_stage stopped re-parsing YAML on every stage
  transition; metadata is read straight from the CRDT view when mirroring
  the row into SQLite.

New CRDT setters added for symmetry:
- crdt_state::set_name (mirrors set_agent — explicit name updates).

cargo fmt --check, clippy --all-targets -- -D warnings, and the
2830-test suite all pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Timmy
2026-05-12 20:55:25 +01:00
parent 6c62e0fa31
commit 69d91d7707
58 changed files with 433 additions and 1344 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/http/workflow/story_ops/create.rs
+17 -39
View File
@@ -66,7 +66,7 @@ pub fn create_story_file(
content.push_str("- TBD\n");
// Write to database content store and CRDT.
write_story_content(root, &story_id, "1_backlog", &content);
write_story_content(root, &story_id, "1_backlog", &content, Some(name));
// Sync depends_on to the typed CRDT register.
crate::crdt_state::set_depends_on(&story_id, depends_on.unwrap_or(&[]));
@@ -83,7 +83,6 @@ pub fn create_story_file(
#[cfg(test)]
mod tests {
use super::*;
use crate::db::yaml_legacy::parse_front_matter;
use std::fs;
#[allow(dead_code)]
@@ -146,7 +145,7 @@ mod tests {
"36_story_existing",
"1_backlog",
"---\nname: Existing\n---\n",
crate::db::ItemMeta::from_yaml("---\nname: Existing\n---\n"),
crate::db::ItemMeta::named("Existing"),
);
let number = super::super::super::next_item_number(tmp.path()).unwrap();
@@ -184,29 +183,24 @@ mod tests {
}
#[test]
fn create_story_with_colon_in_name_produces_valid_yaml() {
fn create_story_with_colon_in_name_persists_to_crdt() {
crate::crdt_state::init_for_test();
let tmp = tempfile::tempdir().unwrap();
let name = "Server-owned agent completion: remove report_completion dependency";
let result = create_story_file(tmp.path(), name, None, None, None, None, false);
assert!(result.is_ok(), "create_story_file failed: {result:?}");
let story_id = result.unwrap();
// Read from content store or filesystem.
let content = crate::db::read_content(&story_id)
.or_else(|| {
let backlog = tmp.path().join(".huskies/work/1_backlog");
fs::read_to_string(backlog.join(format!("{story_id}.md"))).ok()
})
.expect("story content should exist");
let meta = parse_front_matter(&content).expect("front matter should be valid YAML");
assert_eq!(meta.name.as_deref(), Some(name));
let view =
crate::crdt_state::read_item(&story_id).expect("CRDT entry should exist after create");
assert_eq!(view.name(), Some(name));
}
// ── check_criterion_in_file tests ─────────────────────────────────────────
#[test]
fn create_story_with_depends_on_writes_front_matter_array() {
fn create_story_with_depends_on_persists_to_crdt() {
crate::crdt_state::init_for_test();
let tmp = tempfile::tempdir().unwrap();
let story_id = create_story_file(
tmp.path(),
@@ -219,24 +213,9 @@ mod tests {
)
.unwrap();
let contents = crate::db::read_content(&story_id)
.or_else(|| {
let backlog = tmp.path().join(".huskies/work/1_backlog");
fs::read_to_string(backlog.join(format!("{story_id}.md"))).ok()
})
.expect("story content should exist");
assert!(
contents.contains("depends_on: [489]"),
"missing front matter: {contents}"
);
assert!(
!contents.contains("- [ ] depends_on"),
"must not appear as checkbox: {contents}"
);
let meta = parse_front_matter(&contents).expect("front matter should parse");
assert_eq!(meta.depends_on, Some(vec![489]));
let view =
crate::crdt_state::read_item(&story_id).expect("CRDT entry should exist after create");
assert_eq!(view.depends_on(), &[489]);
}
// ── Story 730: numeric-only story IDs ─────────────────────────────────────
@@ -258,19 +237,18 @@ mod tests {
}
#[test]
fn create_story_file_writes_type_field_in_front_matter() {
fn create_story_file_sets_item_type_register() {
crate::crdt_state::init_for_test();
crate::db::ensure_content_store();
let tmp = tempfile::tempdir().unwrap();
let story_id =
create_story_file(tmp.path(), "Type Test Story", None, None, None, None, false)
.unwrap();
let content = crate::db::read_content(&story_id).expect("content must exist");
let meta = crate::db::yaml_legacy::parse_front_matter(&content)
.expect("front matter should be valid");
let view = crate::crdt_state::read_item(&story_id).expect("CRDT entry must exist");
assert_eq!(
meta.item_type.as_deref(),
view.item_type(),
Some("story"),
"front matter must contain type: story"
"CRDT register must be set to story"
);
}
server/src/http/workflow/story_ops/criterion.rs
+6 -12
View File
@@ -52,7 +52,7 @@ pub fn check_criterion_in_file(
// Write back to content store.
let stage = story_stage(story_id).unwrap_or_else(|| "2_current".to_string());
write_story_content(project_root, story_id, &stage, &new_str);
write_story_content(project_root, story_id, &stage, &new_str, None);
Ok(())
}
@@ -99,7 +99,7 @@ pub fn remove_criterion_from_file(
}
let stage = story_stage(story_id).unwrap_or_else(|| "2_current".to_string());
write_story_content(project_root, story_id, &stage, &new_str);
write_story_content(project_root, story_id, &stage, &new_str, None);
Ok(())
}
@@ -158,7 +158,7 @@ pub fn edit_criterion_in_file(
}
let stage = story_stage(story_id).unwrap_or_else(|| "2_current".to_string());
write_story_content(project_root, story_id, &stage, &new_str);
write_story_content(project_root, story_id, &stage, &new_str, None);
Ok(())
}
@@ -219,7 +219,7 @@ pub fn add_criterion_to_file(
// Write back to content store.
let stage = story_stage(story_id).unwrap_or_else(|| "2_current".to_string());
write_story_content(project_root, story_id, &stage, &new_str);
write_story_content(project_root, story_id, &stage, &new_str, None);
Ok(())
}
@@ -234,10 +234,7 @@ pub fn add_criterion_to_file(
/// - String → quoted unless it looks like a bool, integer, or inline sequence
#[cfg(test)]
mod tests {
use super::super::update_story_in_file;
use super::*;
use serde_json::Value;
use std::collections::HashMap;
use std::fs;
#[allow(dead_code)]
@@ -437,11 +434,8 @@ mod tests {
## Recommendation\n\n- TBD\n";
setup_story_in_fs(tmp.path(), "100_spike_my_spike", spike_content);
// Convert spike to story by updating the type field.
let mut fields = HashMap::new();
fields.insert("type".to_string(), Value::String("story".to_string()));
update_story_in_file(tmp.path(), "100_spike_my_spike", None, None, Some(&fields))
.expect("converting spike type to story should succeed");
// Convert spike to story by updating the typed item_type CRDT register.
crate::crdt_state::set_item_type("100_spike_my_spike", Some("story"));
// Add three acceptance criteria.
add_criterion_to_file(tmp.path(), "100_spike_my_spike", "First criterion")
server/src/http/workflow/story_ops/update.rs
+30 -454
View File
@@ -1,7 +1,11 @@
//! update_story_in_file: replaces sections / writes front matter on existing stories.
//! update_story_in_file: replace `## User Story` / `## Description` sections
//! in an existing story's content body.
//!
//! Story 929: the legacy `front_matter` HashMap parameter is gone — every
//! known typed field is intercepted in `tool_update_story` and routed to a
//! typed CRDT setter (set_name, set_agent, set_qa_mode, set_depends_on, …).
//! Any caller still trying to write to YAML front matter is a bug.
use serde_json::Value;
use std::collections::HashMap;
use std::path::Path;
#[allow(unused_imports)]
@@ -10,48 +14,6 @@ use super::super::{
slugify_name, story_stage, write_story_content,
};
use crate::db::yaml_legacy::set_front_matter_field;
fn json_value_to_yaml_scalar(value: &Value) -> String {
match value {
Value::Bool(b) => b.to_string(),
Value::Number(n) => n.to_string(),
Value::Array(arr) => {
let items: Vec<String> = arr.iter().map(|v| v.to_string()).collect();
format!("[{}]", items.join(", "))
}
Value::String(s) => yaml_encode_str(s),
// Null and Object are not meaningful as YAML scalars; store as quoted strings.
other => format!(
"\"{}\"",
other
.to_string()
.replace('"', "\\\"")
.replace('\n', " ")
.replace('\r', "")
),
}
}
/// Encode a plain string as a YAML scalar.
///
/// Booleans (`true`/`false`), integers, and inline sequences (`[...]`) are
/// written unquoted. Everything else is quoted to avoid ambiguity.
fn yaml_encode_str(s: &str) -> String {
match s {
"true" | "false" => s.to_string(),
s if s.parse::<i64>().is_ok() => s.to_string(),
s if s.parse::<f64>().is_ok() => s.to_string(),
// YAML inline sequences like [490] or [490, 491] — write unquoted so
// serde_yaml can deserialise them as Vec<u32>.
s if s.starts_with('[') && s.ends_with(']') => s.to_string(),
s => format!(
"\"{}\"",
s.replace('"', "\\\"").replace('\n', " ").replace('\r', "")
),
}
}
/// Update the user story text and/or description in a story.
///
/// At least one of `user_story` or `description` must be provided.
@@ -61,32 +23,13 @@ pub fn update_story_in_file(
story_id: &str,
user_story: Option<&str>,
description: Option<&str>,
front_matter: Option<&HashMap<String, Value>>,
) -> Result<(), String> {
let has_front_matter_updates = front_matter.map(|m| !m.is_empty()).unwrap_or(false);
if user_story.is_none() && description.is_none() && !has_front_matter_updates {
return Err(
"At least one of 'user_story', 'description', or 'front_matter' must be provided."
.to_string(),
);
if user_story.is_none() && description.is_none() {
return Err("At least one of 'user_story' or 'description' must be provided.".to_string());
}
let mut contents = read_story_content(project_root, story_id)?;
if let Some(fields) = front_matter {
if fields.contains_key("acceptance_criteria") {
return Err(
"'acceptance_criteria' is a reserved field managed via the story body \
(use add_criterion / remove_criterion / edit_criterion instead)."
.to_string(),
);
}
for (key, value) in fields {
let yaml_value = json_value_to_yaml_scalar(value);
contents = set_front_matter_field(&contents, key, &yaml_value);
}
}
if let Some(us) = user_story {
contents = match replace_section_content(&contents, "User Story", us) {
Ok(updated) => updated,
@@ -106,7 +49,7 @@ pub fn update_story_in_file(
// Write back to content store.
let stage = story_stage(story_id).unwrap_or_else(|| "2_current".to_string());
write_story_content(project_root, story_id, &stage, &contents);
write_story_content(project_root, story_id, &stage, &contents, None);
Ok(())
}
@@ -114,98 +57,27 @@ pub fn update_story_in_file(
#[cfg(test)]
mod tests {
use super::*;
use crate::db::yaml_legacy::parse_front_matter;
use std::fs;
#[allow(dead_code)]
fn setup_git_repo(root: &std::path::Path) {
std::process::Command::new("git")
.args(["init"])
.current_dir(root)
.output()
.unwrap();
std::process::Command::new("git")
.args(["config", "user.email", "test@test.com"])
.current_dir(root)
.output()
.unwrap();
std::process::Command::new("git")
.args(["config", "user.name", "Test"])
.current_dir(root)
.output()
.unwrap();
std::process::Command::new("git")
.args(["commit", "--allow-empty", "-m", "init"])
.current_dir(root)
.output()
.unwrap();
}
#[allow(dead_code)]
fn story_with_criteria(n: usize) -> String {
let mut s = "---\nname: Test Story\n---\n\n## Acceptance Criteria\n\n".to_string();
for i in 0..n {
s.push_str(&format!("- [ ] Criterion {i}\n"));
}
s
}
/// Helper to set up a story in the filesystem and content store for tests
/// that use check/add criterion.
#[allow(dead_code)]
/// Helper: write a story to both the in-memory content store and the
/// `.huskies/work/2_current/` directory so `read_story_content` picks it up
/// regardless of which read path is used.
fn setup_story_in_fs(root: &std::path::Path, story_id: &str, content: &str) {
let current = root.join(".huskies/work/2_current");
fs::create_dir_all(&current).unwrap();
fs::write(current.join(format!("{story_id}.md")), content).unwrap();
// Also write to the global content store so read_story_content picks up this
// content even when a previous test has left a stale entry for the same ID.
crate::db::ensure_content_store();
crate::db::write_content(story_id, content);
}
// --- create_story integration tests ---
#[test]
fn update_story_acceptance_criteria_in_front_matter_returns_error() {
// Bug 625: passing acceptance_criteria via front_matter must return an
// explicit error rather than silently dropping the value.
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"101_test",
"---\nname: T\n---\n\n## Acceptance Criteria\n\n- [ ] Existing\n",
);
let mut fields = HashMap::new();
fields.insert(
"acceptance_criteria".to_string(),
serde_json::json!(["crit 1", "crit 2"]),
);
let result = update_story_in_file(tmp.path(), "101_test", None, None, Some(&fields));
assert!(result.is_err(), "should fail with reserved-field error");
let err = result.unwrap_err();
assert!(
err.contains("acceptance_criteria"),
"error should name the reserved field: {err}"
);
}
// ── remove_criterion_from_file tests ──────────────────────────────────────
#[test]
fn update_story_replaces_user_story_section() {
let tmp = tempfile::tempdir().unwrap();
let content = "---\nname: T\n---\n\n## User Story\n\nOld text\n\n## Acceptance Criteria\n\n- [ ] AC\n";
let content =
"# Story\n\n## User Story\n\nOld text\n\n## Acceptance Criteria\n\n- [ ] AC\n";
setup_story_in_fs(tmp.path(), "20_test", content);
update_story_in_file(
tmp.path(),
"20_test",
Some("New user story text"),
None,
None,
)
.unwrap();
update_story_in_file(tmp.path(), "20_test", Some("New user story text"), None).unwrap();
let result = read_story_content(tmp.path(), "20_test").unwrap();
assert!(
@@ -222,10 +94,11 @@ mod tests {
#[test]
fn update_story_replaces_description_section() {
let tmp = tempfile::tempdir().unwrap();
let content = "---\nname: T\n---\n\n## Description\n\nOld description\n\n## Acceptance Criteria\n\n- [ ] AC\n";
let content =
"# Story\n\n## Description\n\nOld description\n\n## Acceptance Criteria\n\n- [ ] AC\n";
setup_story_in_fs(tmp.path(), "21_test", content);
update_story_in_file(tmp.path(), "21_test", None, Some("New description"), None).unwrap();
update_story_in_file(tmp.path(), "21_test", None, Some("New description")).unwrap();
let result = read_story_content(tmp.path(), "21_test").unwrap();
assert!(
@@ -241,9 +114,9 @@ mod tests {
#[test]
fn update_story_no_args_returns_error() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "22_test", "---\nname: T\n---\n");
setup_story_in_fs(tmp.path(), "22_test", "# Story\n");
let result = update_story_in_file(tmp.path(), "22_test", None, None, None);
let result = update_story_in_file(tmp.path(), "22_test", None, None);
assert!(result.is_err());
assert!(result.unwrap_err().contains("At least one"));
}
@@ -251,12 +124,10 @@ mod tests {
#[test]
fn update_story_creates_user_story_section_if_missing() {
let tmp = tempfile::tempdir().unwrap();
// Story with no ## User Story section but has ## Acceptance Criteria.
let content = "---\nname: T\n---\n\n## Acceptance Criteria\n\n- [ ] AC\n";
let content = "# Story\n\n## Acceptance Criteria\n\n- [ ] AC\n";
setup_story_in_fs(tmp.path(), "23_test", content);
let result =
update_story_in_file(tmp.path(), "23_test", Some("New user story"), None, None);
let result = update_story_in_file(tmp.path(), "23_test", Some("New user story"), None);
assert!(
result.is_ok(),
"should succeed when section is missing: {result:?}"
@@ -268,7 +139,6 @@ mod tests {
"section should be created"
);
assert!(updated.contains("New user story"), "text should be present");
// Section should appear before Acceptance Criteria.
let pos_us = updated.find("## User Story").unwrap();
let pos_ac = updated.find("## Acceptance Criteria").unwrap();
assert!(
@@ -280,17 +150,12 @@ mod tests {
#[test]
fn update_story_creates_description_section_if_missing() {
let tmp = tempfile::tempdir().unwrap();
// Story with no ## Description section but has ## Acceptance Criteria.
let content = "---\nname: T\n---\n\n## User Story\n\nAs a user...\n\n## Acceptance Criteria\n\n- [ ] AC\n";
let content =
"# Story\n\n## User Story\n\nAs a user...\n\n## Acceptance Criteria\n\n- [ ] AC\n";
setup_story_in_fs(tmp.path(), "32_test", content);
let result = update_story_in_file(
tmp.path(),
"32_test",
None,
Some("New description text"),
None,
);
let result =
update_story_in_file(tmp.path(), "32_test", None, Some("New description text"));
assert!(
result.is_ok(),
"should succeed when section is missing: {result:?}"
@@ -305,7 +170,6 @@ mod tests {
updated.contains("New description text"),
"text should be present"
);
// Section should appear before Acceptance Criteria.
let pos_desc = updated.find("## Description").unwrap();
let pos_ac = updated.find("## Acceptance Criteria").unwrap();
assert!(
@@ -317,17 +181,11 @@ mod tests {
#[test]
fn update_story_creates_description_section_no_ac_section() {
let tmp = tempfile::tempdir().unwrap();
// Story with no ## Description and no ## Acceptance Criteria.
let content = "---\nname: T\n---\n\nSome content here.\n";
let content = "# Story\n\nSome content here.\n";
setup_story_in_fs(tmp.path(), "33_test", content);
let result = update_story_in_file(
tmp.path(),
"33_test",
None,
Some("Appended description"),
None,
);
let result =
update_story_in_file(tmp.path(), "33_test", None, Some("Appended description"));
assert!(
result.is_ok(),
"should succeed even with no Acceptance Criteria: {result:?}"
@@ -343,286 +201,4 @@ mod tests {
"text should be present"
);
}
#[test]
fn update_story_sets_agent_front_matter_field() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"24_test",
"---\nname: T\n---\n\n## User Story\n\nSome story\n",
);
let mut fields = HashMap::new();
fields.insert("agent".to_string(), Value::String("dev".to_string()));
update_story_in_file(tmp.path(), "24_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "24_test").unwrap();
assert!(
result.contains("agent: \"dev\""),
"agent field should be set"
);
assert!(result.contains("name: T"), "name field preserved");
}
#[test]
fn update_story_sets_arbitrary_front_matter_fields() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"25_test",
"---\nname: T\n---\n\n## User Story\n\nSome story\n",
);
let mut fields = HashMap::new();
fields.insert("qa".to_string(), Value::String("human".to_string()));
fields.insert("priority".to_string(), Value::String("high".to_string()));
update_story_in_file(tmp.path(), "25_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "25_test").unwrap();
assert!(result.contains("qa: \"human\""), "qa field should be set");
assert!(
result.contains("priority: \"high\""),
"priority field should be set"
);
assert!(result.contains("name: T"), "name field preserved");
}
#[test]
fn update_story_front_matter_only_no_section_required() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"26_test",
"---\nname: T\n---\n\nNo sections here.\n",
);
let mut fields = HashMap::new();
fields.insert("agent".to_string(), Value::String("dev".to_string()));
let result = update_story_in_file(tmp.path(), "26_test", None, None, Some(&fields));
assert!(
result.is_ok(),
"front-matter-only update should not require body sections"
);
let contents = read_story_content(tmp.path(), "26_test").unwrap();
assert!(contents.contains("agent: \"dev\""));
}
#[test]
fn update_story_bool_front_matter_written_unquoted() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "27_test", "---\nname: T\n---\n\nNo sections.\n");
// String "false" still works (backwards compatibility).
let mut fields = HashMap::new();
fields.insert("blocked".to_string(), Value::String("false".to_string()));
update_story_in_file(tmp.path(), "27_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "27_test").unwrap();
assert!(
result.contains("blocked: false"),
"bool should be unquoted: {result}"
);
assert!(
!result.contains("blocked: \"false\""),
"bool must not be quoted: {result}"
);
}
#[test]
fn update_story_integer_front_matter_written_unquoted() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "28_test", "---\nname: T\n---\n\nNo sections.\n");
// String "0" still works (backwards compatibility).
let mut fields = HashMap::new();
fields.insert("retry_count".to_string(), Value::String("0".to_string()));
update_story_in_file(tmp.path(), "28_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "28_test").unwrap();
assert!(
result.contains("retry_count: 0"),
"integer should be unquoted: {result}"
);
assert!(
!result.contains("retry_count: \"0\""),
"integer must not be quoted: {result}"
);
}
#[test]
fn update_story_bool_front_matter_parseable_after_write() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"29_test",
"---\nname: My Story\n---\n\nNo sections.\n",
);
let mut fields = HashMap::new();
fields.insert("blocked".to_string(), Value::String("false".to_string()));
update_story_in_file(tmp.path(), "29_test", None, None, Some(&fields)).unwrap();
let contents = read_story_content(tmp.path(), "29_test").unwrap();
let meta = parse_front_matter(&contents).expect("front matter should parse");
assert_eq!(
meta.name.as_deref(),
Some("My Story"),
"name preserved after writing bool field"
);
}
// ── Bug 493 regression tests ──────────────────────────────────────────────
#[test]
fn update_story_depends_on_stored_as_yaml_array_not_quoted_string() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "30_test", "---\nname: T\n---\n\nNo sections.\n");
// String "[490]" still works (backwards compatibility).
let mut fields = HashMap::new();
fields.insert("depends_on".to_string(), Value::String("[490]".to_string()));
update_story_in_file(tmp.path(), "30_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "30_test").unwrap();
assert!(
result.contains("depends_on: [490]"),
"should be unquoted array: {result}"
);
assert!(
!result.contains("depends_on: \"[490]\""),
"must not be quoted: {result}"
);
let meta = parse_front_matter(&result).expect("front matter should parse");
assert_eq!(meta.depends_on, Some(vec![490]));
}
#[test]
fn update_story_native_bool_written_unquoted() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "31_test", "---\nname: T\n---\n\nNo sections.\n");
let mut fields = HashMap::new();
fields.insert("blocked".to_string(), Value::Bool(false));
update_story_in_file(tmp.path(), "31_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "31_test").unwrap();
assert!(
result.contains("blocked: false"),
"native bool false should be unquoted: {result}"
);
assert!(
!result.contains("blocked: \"false\""),
"must not be quoted: {result}"
);
}
#[test]
fn update_story_native_bool_true_written_unquoted() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "32_test", "---\nname: T\n---\n\nNo sections.\n");
let mut fields = HashMap::new();
fields.insert("blocked".to_string(), Value::Bool(true));
update_story_in_file(tmp.path(), "32_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "32_test").unwrap();
assert!(
result.contains("blocked: true"),
"native bool true should be unquoted: {result}"
);
assert!(
!result.contains("blocked: \"true\""),
"must not be quoted: {result}"
);
}
#[test]
fn update_story_native_integer_written_unquoted() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"33b_test",
"---\nname: T\n---\n\nNo sections.\n",
);
let mut fields = HashMap::new();
fields.insert("retry_count".to_string(), serde_json::json!(3));
update_story_in_file(tmp.path(), "33b_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "33b_test").unwrap();
assert!(
result.contains("retry_count: 3"),
"native integer should be unquoted: {result}"
);
assert!(
!result.contains("retry_count: \"3\""),
"must not be quoted: {result}"
);
}
#[test]
fn update_story_native_array_written_as_yaml_sequence() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "34_test", "---\nname: T\n---\n\nNo sections.\n");
let mut fields = HashMap::new();
fields.insert("depends_on".to_string(), serde_json::json!([490, 491]));
update_story_in_file(tmp.path(), "34_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "34_test").unwrap();
assert!(
result.contains("depends_on: [490, 491]"),
"native array should be YAML sequence: {result}"
);
assert!(
!result.contains("depends_on: \"["),
"must not be quoted: {result}"
);
let meta = parse_front_matter(&result).expect("front matter should parse");
assert_eq!(meta.depends_on, Some(vec![490, 491]));
}
#[test]
fn update_story_native_bool_parseable_after_write() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(
tmp.path(),
"35_test",
"---\nname: My Story\n---\n\nNo sections.\n",
);
let mut fields = HashMap::new();
fields.insert("blocked".to_string(), Value::Bool(false));
update_story_in_file(tmp.path(), "35_test", None, None, Some(&fields)).unwrap();
let contents = read_story_content(tmp.path(), "35_test").unwrap();
let meta = parse_front_matter(&contents).expect("front matter should parse");
assert_eq!(
meta.name.as_deref(),
Some("My Story"),
"name preserved after writing native bool"
);
}
#[test]
fn update_story_depends_on_multi_element_array() {
let tmp = tempfile::tempdir().unwrap();
setup_story_in_fs(tmp.path(), "31_test", "---\nname: T\n---\n\nNo sections.\n");
// String "[490, 491]" still works (backwards compatibility).
let mut fields = HashMap::new();
fields.insert(
"depends_on".to_string(),
Value::String("[490, 491]".to_string()),
);
update_story_in_file(tmp.path(), "31_test", None, None, Some(&fields)).unwrap();
let result = read_story_content(tmp.path(), "31_test").unwrap();
let meta = parse_front_matter(&result).expect("front matter should parse");
assert_eq!(meta.depends_on, Some(vec![490, 491]));
}
}