huskies: merge 1014

This commit is contained in:
dave
2026-05-13 23:18:59 +00:00
parent 8754c790b9
commit 69b207872a
5 changed files with 263 additions and 14 deletions
+201
View File
@@ -1006,4 +1006,205 @@ fn hotfix_requested_rejected_from_non_done_stages() {
}
}
// ── Audit log subscriber (story 1014) ──────────────────────────────────────
#[test]
fn audit_entry_backlog_to_coding_exact_format() {
let at = chrono::DateTime::parse_from_rfc3339("2026-01-01T00:00:00Z")
.unwrap()
.with_timezone(&chrono::Utc);
let fired = TransitionFired {
story_id: StoryId("1014_my_story".into()),
before: Stage::Backlog,
after: Stage::Coding { claim: None },
event: PipelineEvent::DepsMet,
at,
};
assert_eq!(
format_audit_entry(&fired),
"audit ts=2026-01-01T00:00:00Z id=1014_my_story from=Backlog to=Coding event=DepsMet"
);
}
#[test]
fn audit_entry_is_single_line_with_all_fields() {
let fired = TransitionFired {
story_id: StoryId("42_test".into()),
before: Stage::Qa,
after: Stage::Merge {
feature_branch: fb("feature/story-42"),
commits_ahead: nz(3),
claim: None,
},
event: PipelineEvent::GatesPassed {
feature_branch: fb("feature/story-42"),
commits_ahead: nz(3),
},
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(!line.contains('\n'), "audit entry must be a single line");
assert!(line.starts_with("audit "), "must start with 'audit '");
assert!(line.contains("id=42_test"), "must contain id field");
assert!(line.contains("from=Qa"), "must contain from field");
assert!(line.contains("to=Merge"), "must contain to field");
assert!(
line.contains("event=GatesPassed"),
"must contain event field"
);
// Stable field ordering: ts before id before from before to before event.
let ts_pos = line.find("ts=").unwrap();
let id_pos = line.find("id=").unwrap();
let from_pos = line.find("from=").unwrap();
let to_pos = line.find("to=").unwrap();
let ev_pos = line.find("event=").unwrap();
assert!(
ts_pos < id_pos && id_pos < from_pos && from_pos < to_pos && to_pos < ev_pos,
"fields must appear in order ts, id, from, to, event"
);
}
#[test]
fn audit_entry_merge_to_done() {
let fired = TransitionFired {
story_id: StoryId("100_s".into()),
before: Stage::Merge {
feature_branch: fb("f"),
commits_ahead: nz(1),
claim: None,
},
after: Stage::Done {
merged_at: chrono::Utc::now(),
merge_commit: sha("abc"),
},
event: PipelineEvent::MergeSucceeded {
merge_commit: sha("abc"),
},
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Merge"), "from=Merge");
assert!(line.contains("to=Done"), "to=Done");
assert!(
line.contains("event=MergeSucceeded"),
"event=MergeSucceeded"
);
}
#[test]
fn audit_entry_done_to_archived() {
let fired = TransitionFired {
story_id: StoryId("200_s".into()),
before: Stage::Done {
merged_at: chrono::Utc::now(),
merge_commit: sha("x"),
},
after: Stage::Archived {
archived_at: chrono::Utc::now(),
reason: ArchiveReason::Completed,
},
event: PipelineEvent::Accepted,
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Done"), "from=Done");
assert!(line.contains("to=Archived"), "to=Archived");
assert!(line.contains("event=Accepted"), "event=Accepted");
}
#[test]
fn audit_entry_coding_to_blocked() {
let fired = TransitionFired {
story_id: StoryId("300_s".into()),
before: Stage::Coding { claim: None },
after: Stage::Blocked {
reason: "waiting".into(),
},
event: PipelineEvent::Block {
reason: "waiting".into(),
},
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Coding"), "from=Coding");
assert!(line.contains("to=Blocked"), "to=Blocked");
assert!(line.contains("event=Block"), "event=Block");
}
#[test]
fn audit_entry_blocked_to_coding() {
let fired = TransitionFired {
story_id: StoryId("400_s".into()),
before: Stage::Blocked {
reason: "test".into(),
},
after: Stage::Coding { claim: None },
event: PipelineEvent::Unblock,
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Blocked"), "from=Blocked");
assert!(line.contains("to=Coding"), "to=Coding");
assert!(line.contains("event=Unblock"), "event=Unblock");
}
#[test]
fn audit_entry_merge_to_merge_failure() {
let fired = TransitionFired {
story_id: StoryId("500_s".into()),
before: Stage::Merge {
feature_branch: fb("f"),
commits_ahead: nz(1),
claim: None,
},
after: Stage::MergeFailure {
kind: MergeFailureKind::Other("conflicts".into()),
feature_branch: fb("f"),
commits_ahead: nz(1),
},
event: PipelineEvent::MergeFailed {
kind: MergeFailureKind::Other("conflicts".into()),
},
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Merge"), "from=Merge");
assert!(line.contains("to=MergeFailure"), "to=MergeFailure");
assert!(line.contains("event=MergeFailed"), "event=MergeFailed");
}
#[test]
fn audit_entry_coding_to_frozen() {
let fired = TransitionFired {
story_id: StoryId("600_s".into()),
before: Stage::Coding { claim: None },
after: Stage::Frozen {
resume_to: Box::new(Stage::Coding { claim: None }),
},
event: PipelineEvent::Freeze,
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Coding"), "from=Coding");
assert!(line.contains("to=Frozen"), "to=Frozen");
assert!(line.contains("event=Freeze"), "event=Freeze");
}
#[test]
fn audit_entry_coding_to_abandoned() {
let fired = TransitionFired {
story_id: StoryId("700_s".into()),
before: Stage::Coding { claim: None },
after: Stage::Abandoned {
ts: chrono::Utc::now(),
},
event: PipelineEvent::Abandon,
at: chrono::Utc::now(),
};
let line = format_audit_entry(&fired);
assert!(line.contains("from=Coding"), "from=Coding");
assert!(line.contains("to=Abandoned"), "to=Abandoned");
assert!(line.contains("event=Abandon"), "event=Abandon");
}
// ── ProjectionError Display ─────────────────────────────────────────