From 65e3643655a4ba776e8e91f3939476bd267656a3 Mon Sep 17 00:00:00 2001 From: dave Date: Wed, 25 Mar 2026 15:31:30 +0000 Subject: [PATCH] storkit: done 395_refactor_fix_npm_deprecated_module_warnings --- ...s_for_start_rebuild_reset_rmtree_assign.md | 31 ------------------- ...ctor_fix_npm_deprecated_module_warnings.md | 24 ++++++++++++++ 2 files changed, 24 insertions(+), 31 deletions(-) delete mode 100644 .storkit/work/1_backlog/390_bug_whatsapp_missing_async_command_handlers_for_start_rebuild_reset_rmtree_assign.md create mode 100644 .storkit/work/5_done/395_refactor_fix_npm_deprecated_module_warnings.md diff --git a/.storkit/work/1_backlog/390_bug_whatsapp_missing_async_command_handlers_for_start_rebuild_reset_rmtree_assign.md b/.storkit/work/1_backlog/390_bug_whatsapp_missing_async_command_handlers_for_start_rebuild_reset_rmtree_assign.md deleted file mode 100644 index 77a21b5b..00000000 --- a/.storkit/work/1_backlog/390_bug_whatsapp_missing_async_command_handlers_for_start_rebuild_reset_rmtree_assign.md +++ /dev/null @@ -1,31 +0,0 @@ ---- -name: "WhatsApp missing async command handlers for start, rebuild, reset, rmtree, assign" ---- - -# Bug 390: WhatsApp missing async command handlers for start, rebuild, reset, rmtree, assign - -## Description - -Five bot commands listed in help don't work in WhatsApp. Matrix's on_room_message pre-dispatches these via extract_*_command() functions before calling try_handle_command(), but WhatsApp's handle_incoming_message only pre-dispatches htop and delete. The missing commands have fallback handlers that return None, so they silently fall through to the LLM instead of executing. - -## How to Reproduce - -1. Send "rebuild" (or "start 386", "reset", "rmtree 386", "assign 386 opus") to the WhatsApp bot\n2. Observe the message is forwarded to the LLM instead of executing the command - -## Actual Result - -The 5 commands (start, rebuild, reset, rmtree, assign) fall through to the LLM and generate a conversational response instead of executing the bot command. - -## Expected Result - -All commands listed in help should work in WhatsApp, matching Matrix behavior. start should spawn an agent, rebuild should rebuild the server, reset should clear the session, rmtree should remove a worktree, assign should pre-assign a model. - -## Acceptance Criteria - -- [ ] start command works in WhatsApp (extract_start_command dispatch) -- [ ] rebuild command works in WhatsApp (extract_rebuild_command dispatch) -- [ ] reset command works in WhatsApp (extract_reset_command dispatch) -- [ ] rmtree command works in WhatsApp (extract_rmtree_command dispatch) -- [ ] assign command works in WhatsApp (extract_assign_command dispatch) -- [ ] Same 5 commands also work in Slack transport if similarly missing -- [ ] RETRY: Previous attempt was marked done without any code changes — the mergemaster moved the story to done but no async command handlers were actually added to whatsapp.rs. The fix must add extract_start_command, extract_rebuild_command, extract_reset_command, extract_rmtree_command, and extract_assign_command dispatch blocks to handle_incoming_message in whatsapp.rs, following the existing pattern used for htop and delete. Also check and fix Slack if similarly missing. diff --git a/.storkit/work/5_done/395_refactor_fix_npm_deprecated_module_warnings.md b/.storkit/work/5_done/395_refactor_fix_npm_deprecated_module_warnings.md new file mode 100644 index 00000000..717feb4b --- /dev/null +++ b/.storkit/work/5_done/395_refactor_fix_npm_deprecated_module_warnings.md @@ -0,0 +1,24 @@ +--- +name: "Fix npm deprecated module warnings" +--- + +# Refactor 395: Fix npm deprecated module warnings + +## Current State + +- TBD + +## Desired State + +Address npm warnings about deprecated modules in the frontend dependencies. Update or replace deprecated packages to eliminate warnings during npm install. + +## Acceptance Criteria + +- [ ] npm install runs with zero deprecation warnings +- [ ] All existing frontend tests (npm test) still pass +- [ ] npm run build succeeds without errors +- [ ] No functional regressions in the frontend + +## Out of Scope + +- TBD