huskies: merge 958

2026-05-13 11:47:27 +00:00
parent 8b53e20ca9
commit 28338a8e8d
7 changed files with 103 additions and 31 deletions
@@ -814,4 +814,76 @@ mod tests {
             found {active_coder_count} active entries"
        );
    }
+
+    // ── Story 958: MergeFailure transition fires auto-assign via watcher bridge ─
+
+    /// Regression: before story 958, the auto-assign subscriber filtered events
+    /// with `is_active()`, which returned false for `MergeFailure`.  This meant
+    /// a CRDT `MergeFailure` transition never triggered auto-assign, and
+    /// mergemaster was never auto-spawned on content conflicts.
+    ///
+    /// After story 958, the subscriber fires on EVERY WorkItem event.  This
+    /// test verifies the end-to-end path: a WorkItem event with stage
+    /// `merge_failure` arriving on the watcher channel causes
+    /// `auto_assign_available_work` to run, which then auto-spawns mergemaster.
+    #[tokio::test]
+    async fn merge_failure_watcher_event_triggers_mergemaster_spawn() {
+        use std::sync::Arc;
+
+        let tmp = tempfile::tempdir().unwrap();
+        let root = tmp.path().to_path_buf();
+        let sk = root.join(".huskies");
+        std::fs::create_dir_all(&sk).unwrap();
+        std::fs::write(
+            sk.join("project.toml"),
+            "[[agent]]\nname = \"mergemaster\"\nstage = \"mergemaster\"\n",
+        )
+        .unwrap();
+        crate::crdt_state::init_for_test();
+        crate::db::ensure_content_store();
+        crate::db::write_item_with_content(
+            "958_regression_conflict",
+            "4_merge_failure",
+            "CONFLICT (content): server/src/lib.rs",
+            crate::db::ItemMeta::named("Regression"),
+        );
+        crate::db::write_content(
+            crate::db::ContentKey::GateOutput("958_regression_conflict"),
+            "CONFLICT (content): server/src/lib.rs",
+        );
+
+        let (watcher_tx, _) = broadcast::channel::<crate::io::watcher::WatcherEvent>(16);
+        let pool = Arc::new(AgentPool::new(3102, watcher_tx.clone()));
+
+        crate::startup::tick_loop::spawn_event_bridges(
+            watcher_tx.clone(),
+            Some(root.clone()),
+            Arc::clone(&pool),
+        );
+
+        // Simulate the CRDT bridge forwarding a merge_failure stage transition.
+        let _ = watcher_tx.send(crate::io::watcher::WatcherEvent::WorkItem {
+            stage: "merge_failure".to_string(),
+            item_id: "958_regression_conflict".to_string(),
+            action: "update".to_string(),
+            commit_msg: "huskies: update 958_regression_conflict".to_string(),
+            from_stage: Some("merge".to_string()),
+        });
+
+        // Allow the subscriber task to run auto_assign_available_work.
+        tokio::task::yield_now().await;
+        tokio::time::sleep(std::time::Duration::from_millis(200)).await;
+
+        let agents = pool.agents.lock().unwrap();
+        let mergemaster_spawned = agents.iter().any(|(key, a)| {
+            key.contains("958_regression_conflict")
+                && a.agent_name == "mergemaster"
+                && matches!(a.status, AgentStatus::Pending | AgentStatus::Running)
+        });
+        assert!(
+            mergemaster_spawned,
+            "mergemaster must be auto-spawned when a merge_failure event fires \
+             through the watcher bridge (story 958 regression)"
+        );
+    }
 }