huskies: merge 629_refactor_migrate_commanddispatch_and_commandcontext_to_services_bundle

server/src/chat/commands/overview.rs

@@ -13,17 +13,17 @@ pub(super) fn handle_overview(ctx: &CommandContext) -> Option<String> {
     if num_str.is_empty() {
         return Some(format!(
             "Usage: `{} overview <number>`\n\nShows the implementation summary for a story.",
-            ctx.bot_name
+            ctx.services.bot_name
         ));
     }
     if !num_str.chars().all(|c| c.is_ascii_digit()) {
         return Some(format!(
             "Invalid story number: `{num_str}`. Usage: `{} overview <number>`",
-            ctx.bot_name
+            ctx.services.bot_name
         ));
     }
 
-    let commit_hash = match find_story_merge_commit(ctx.project_root, num_str) {
+    let commit_hash = match find_story_merge_commit(ctx.effective_root(), num_str) {
         Some(h) => h,
         None => {
             return Some(format!(
@@ -33,9 +33,9 @@ pub(super) fn handle_overview(ctx: &CommandContext) -> Option<String> {
         }
     };
 
-    let stat_output = get_commit_stat(ctx.project_root, &commit_hash);
-    let symbols = extract_diff_symbols(ctx.project_root, &commit_hash);
-    let story_name = find_story_name(ctx.project_root, num_str);
+    let stat_output = get_commit_stat(ctx.effective_root(), &commit_hash);
+    let symbols = extract_diff_symbols(ctx.effective_root(), &commit_hash);
+    let story_name = find_story_name(ctx.effective_root(), num_str);
 
     let short_hash = &commit_hash[..commit_hash.len().min(8)];
     let mut out = match story_name {
@@ -195,22 +195,16 @@ fn parse_symbol_definition(code: &str) -> Option<String> {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::agents::AgentPool;
-    use std::collections::HashSet;
-    use std::sync::{Arc, Mutex};
 
     use super::super::{CommandDispatch, try_handle_command};
 
     fn overview_cmd_with_root(root: &std::path::Path, args: &str) -> Option<String> {
-        let agents = Arc::new(AgentPool::new_test(3000));
-        let ambient_rooms = Arc::new(Mutex::new(HashSet::new()));
+        let services = crate::services::Services::new_test(root.to_path_buf(), "Timmy".to_string());
         let room_id = "!test:example.com".to_string();
         let dispatch = CommandDispatch {
-            bot_name: "Timmy",
+            services: &services,
+            project_root: &services.project_root,
             bot_user_id: "@timmy:homeserver.local",
-            project_root: root,
-            agents: &agents,
-            ambient_rooms: &ambient_rooms,
             room_id: &room_id,
         };
         try_handle_command(&dispatch, &format!("@timmy overview {args}"))