crashlabs/huskies
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: use Stdio::inherit for run_tests to prevent pipe deadlock

Browse Source 
spawn() with piped stdout/stderr deadlocks when the test binary
produces more output than the OS pipe buffer (64KB). Switch to
Stdio::inherit so test output flows to server logs and we can
see what's happening.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
dave
2026-04-12 00:45:47 +00:00
parent b43e7cf752
commit 0b58b0486c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/http/mcp/shell_tools.rs
+2 -2
View File
@@ -411,8 +411,8 @@ pub(super) async fn tool_run_tests(args: &Value, ctx: &AppContext) -> Result<Str
let child = std::process::Command::new("bash") let child = std::process::Command::new("bash")
.arg(&script_path) .arg(&script_path)
.current_dir(&working_dir) .current_dir(&working_dir)
.stdout(std::process::Stdio::piped()) .stdout(std::process::Stdio::inherit())
.stderr(std::process::Stdio::piped()) .stderr(std::process::Stdio::inherit())
.spawn() .spawn()
.map_err(|e| format!("Failed to spawn test script: {e}"))?; .map_err(|e| format!("Failed to spawn test script: {e}"))?;