huskies: merge 942

server/src/http/mcp/story_tools/bug.rs

@@ -71,7 +71,7 @@ pub(crate) fn tool_create_bug(args: &Value, ctx: &AppContext) -> Result<String,
         steps_to_reproduce,
         actual_result,
         expected_result,
-        Some(&acceptance_criteria),
+        &acceptance_criteria,
         depends_on.as_deref(),
     )?;
 
@@ -218,6 +218,28 @@ mod tests {
         assert!(result.unwrap_err().contains("name"));
     }
 
+    #[test]
+    fn tool_create_bug_rejects_whitespace_only_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let err = tool_create_bug(
+            &json!({
+                "name": "   ",
+                "description": "d",
+                "steps_to_reproduce": "s",
+                "actual_result": "a",
+                "expected_result": "e",
+                "acceptance_criteria": ["Bug fixed"]
+            }),
+            &ctx,
+        )
+        .unwrap_err();
+        assert!(
+            err.contains("empty") || err.contains("whitespace"),
+            "error should mention empty/whitespace, got: {err}"
+        );
+    }
+
     #[test]
     fn tool_create_bug_missing_description() {
         let tmp = tempfile::tempdir().unwrap();

server/src/http/mcp/story_tools/refactor.rs

@@ -53,7 +53,7 @@ pub(crate) fn tool_create_refactor(args: &Value, ctx: &AppContext) -> Result<Str
         &root,
         name,
         description,
-        Some(&acceptance_criteria),
+        &acceptance_criteria,
         depends_on.as_deref(),
     )?;
 
@@ -78,6 +78,21 @@ mod tests {
     use crate::http::test_helpers::test_ctx;
     use serde_json::json;
 
+    #[test]
+    fn tool_create_refactor_rejects_whitespace_only_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let err = tool_create_refactor(
+            &json!({"name": "   ", "acceptance_criteria": ["Code is clean"]}),
+            &ctx,
+        )
+        .unwrap_err();
+        assert!(
+            err.contains("empty") || err.contains("whitespace"),
+            "error should mention empty/whitespace, got: {err}"
+        );
+    }
+
     #[test]
     fn tool_create_refactor_rejects_missing_acceptance_criteria() {
         let tmp = tempfile::tempdir().unwrap();

server/src/http/mcp/story_tools/spike.rs

@@ -103,6 +103,21 @@ mod tests {
         assert!(result.unwrap_err().contains("alphanumeric"));
     }
 
+    #[test]
+    fn tool_create_spike_rejects_whitespace_only_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let err = tool_create_spike(
+            &json!({"name": "   ", "acceptance_criteria": ["Findings documented"]}),
+            &ctx,
+        )
+        .unwrap_err();
+        assert!(
+            err.contains("empty") || err.contains("whitespace"),
+            "error should mention empty/whitespace, got: {err}"
+        );
+    }
+
     #[test]
     fn tool_create_spike_creates_file() {
         let tmp = tempfile::tempdir().unwrap();

server/src/http/mcp/story_tools/story/create.rs

@@ -42,7 +42,7 @@ pub(crate) fn tool_create_story(args: &Value, ctx: &AppContext) -> Result<String
         name,
         user_story,
         description,
-        Some(&acceptance_criteria),
+        &acceptance_criteria,
         depends_on.as_deref(),
         commit,
     )?;
@@ -138,6 +138,21 @@ mod tests {
         assert!(result.unwrap_err().contains("alphanumeric"));
     }
 
+    #[test]
+    fn tool_create_story_rejects_whitespace_only_name() {
+        let tmp = tempfile::tempdir().unwrap();
+        let ctx = test_ctx(tmp.path());
+        let err = tool_create_story(
+            &json!({"name": "   ", "acceptance_criteria": ["AC1"]}),
+            &ctx,
+        )
+        .unwrap_err();
+        assert!(
+            err.contains("empty") || err.contains("whitespace"),
+            "error should mention empty/whitespace, got: {err}"
+        );
+    }
+
     #[test]
     fn tool_create_story_rejects_missing_acceptance_criteria() {
         let tmp = tempfile::tempdir().unwrap();